Skip to contentSkip to conversation

mfd: sec-core: add missing sec_irq_init() return value checking

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 3 messages Aug 7, 2014 – Aug 8, 2014

Subsystems (3)
Arm Samsung Exynos Multifunction devices (MFD) Samsung multifunction PMIC device drivers
lore
Share & tools
lore

Bartlomiej Zolnierkiewicz

author
#0 lore raw

PATCH 1/1 mfd: sec-core: add missing sec_irq_init() return value checking

sec_irq_init() can fail if it encounters unknown device type or on regmap_add_irq_chip() error. Add missing sec_irq_init() return value checking to sec_pmic_probe().

Tested on Insignal's Exynos4412 based Origen board.

Cc Krzysztof Kozlowski <[email protected]>
Cc Sangbeom Kim <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Acked-by Kyungmin Park <[email protected]>

---
patch is against next-20140804 branch of linux-next kernel

 drivers/mfd/sec-core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mfd/sec-core.c +3 -1
index dba7e2b..f498867 100644
@@ -353,7 +353,9 @@ static int sec_pmic_probe(struct i2c_client *i2c,
 	if (pdata && pdata->cfg_pmic_irq)
 		pdata->cfg_pmic_irq();
 
-	sec_irq_init(sec_pmic);
+	ret = sec_irq_init(sec_pmic);
+	if (ret)
+		return ret;
 
 	pm_runtime_set_active(sec_pmic->dev);
Signature · 1 line
1.8.2.3
author
#1 lore raw

[ added missing linux-samsung-soc ML, sorry for the noise ]

Quoted 30 lines · Bartlomiej Zolnierkiewicz

sec_irq_init() can fail if it encounters unknown device type or on regmap_add_irq_chip() error. Add missing sec_irq_init() return value checking to sec_pmic_probe().

Tested on Insignal's Exynos4412 based Origen board.

Cc Krzysztof Kozlowski <[email protected]>
Cc Sangbeom Kim <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Acked-by Kyungmin Park <[email protected]>

---
patch is against next-20140804 branch of linux-next kernel

 drivers/mfd/sec-core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mfd/sec-core.c +3 -1
index dba7e2b..f498867 100644
@@ -353,7 +353,9 @@ static int sec_pmic_probe(struct i2c_client *i2c,
 	if (pdata && pdata->cfg_pmic_irq)
 		pdata->cfg_pmic_irq();
 
-	sec_irq_init(sec_pmic);
+	ret = sec_irq_init(sec_pmic);
+	if (ret)
+		return ret;
 
 	pm_runtime_set_active(sec_pmic->dev);
Reviewed-by Tested-by
#2 lore raw
Quoted 18 lines · Bartlomiej Zolnierkiewicz

[ added missing linux-samsung-soc ML, sorry for the noise ]

Quoted 15 lines · Bartlomiej Zolnierkiewicz

sec_irq_init() can fail if it encounters unknown device type or on regmap_add_irq_chip() error. Add missing sec_irq_init() return value checking to sec_pmic_probe().

Tested on Insignal's Exynos4412 based Origen board.

Cc Krzysztof Kozlowski <[email protected]>
Cc Sangbeom Kim <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Acked-by Kyungmin Park <[email protected]>

---
patch is against next-20140804 branch of linux-next kernel

 drivers/mfd/sec-core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Looks and works good (tested on board with S2MPS14).

Reviewed-by Krzysztof Kozlowski <[email protected]>
Tested-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

Quoted 15 lines
Quoted 15 lines
drivers/mfd/sec-core.c +3 -1
index dba7e2b..f498867 100644
@@ -353,7 +353,9 @@ static int sec_pmic_probe(struct i2c_client *i2c,
 	if (pdata && pdata->cfg_pmic_irq)
 		pdata->cfg_pmic_irq();
 
-	sec_irq_init(sec_pmic);
+	ret = sec_irq_init(sec_pmic);
+	if (ret)
+		return ret;
 
 	pm_runtime_set_active(sec_pmic->dev);