Skip to contentSkip to conversation

ov7670: Include media/v4l2-image-sizes.h

PATCH In review Axel Lin 2 participants 5 messages Aug 9, 2014 – Aug 11, 2014

Subsystems (3)
Media (V4L/DVB) V4L2 camera sensor drivers Omnivision OV7670 sensor driver
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/4 ov7670: Include media/v4l2-image-sizes.h

So we can remove the same defines in the driver code.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/media/i2c/ov7670.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)
drivers/media/i2c/ov7670.c +1 -13
index cdd7c1b..dd3db24 100644
@@ -19,6 +19,7 @@
 #include <media/v4l2-device.h>
 #include <media/v4l2-ctrls.h>
 #include <media/v4l2-mediabus.h>
+#include <media/v4l2-image-sizes.h>
 #include <media/ov7670.h>
 
 MODULE_AUTHOR("Jonathan Corbet <[email protected]>");

@@ -30,19 +31,6 @@ module_param(debug, bool, 0644);
 MODULE_PARM_DESC(debug, "Debug level (0-1)");
 
 /*
- * Basic window sizes.  These probably belong somewhere more globally
- * useful.
- */
-#define VGA_WIDTH	640
-#define VGA_HEIGHT	480
-#define QVGA_WIDTH	320
-#define QVGA_HEIGHT	240
-#define CIF_WIDTH	352
-#define CIF_HEIGHT	288
-#define QCIF_WIDTH	176
-#define	QCIF_HEIGHT	144
-
-/*
  * The 7670 sits on i2c with ID 0x42
  */
 #define OV7670_I2C_ADDR 0x42
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/4 vs6624: Include media/v4l2-image-sizes.h

So we can remove the same defines in the driver code.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/media/i2c/vs6624.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)
drivers/media/i2c/vs6624.c +1 -13
index 23f4f65..373f2df 100644
@@ -30,22 +30,10 @@
 #include <media/v4l2-ctrls.h>
 #include <media/v4l2-device.h>
 #include <media/v4l2-mediabus.h>
+#include <media/v4l2-image-sizes.h>
 
 #include "vs6624_regs.h"
 
-#define VGA_WIDTH       640
-#define VGA_HEIGHT      480
-#define QVGA_WIDTH      320
-#define QVGA_HEIGHT     240
-#define QQVGA_WIDTH     160
-#define QQVGA_HEIGHT    120
-#define CIF_WIDTH       352
-#define CIF_HEIGHT      288
-#define QCIF_WIDTH      176
-#define QCIF_HEIGHT     144
-#define QQCIF_WIDTH     88
-#define QQCIF_HEIGHT    72
-
 #define MAX_FRAME_RATE  30
 
 struct vs6624 {
Signature · 1 line
1.9.1
author
#2 lore raw

PATCH 3/4 soc_camera: mt9t112: Include media/v4l2-image-sizes.h

In reply to Axel Lin

So we can remove the same defines in the driver code.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/media/i2c/soc_camera/mt9t112.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/media/i2c/soc_camera/mt9t112.c +1 -3
index 46f431a..996d7b4 100644
@@ -29,6 +29,7 @@
 #include <media/soc_camera.h>
 #include <media/v4l2-clk.h>
 #include <media/v4l2-common.h>
+#include <media/v4l2-image-sizes.h>
 
 /* you can check PLL/clock info */
 /* #define EXT_CLOCK 24000000 */

@@ -42,9 +43,6 @@
 #define MAX_WIDTH   2048
 #define MAX_HEIGHT  1536
 
-#define VGA_WIDTH   640
-#define VGA_HEIGHT  480
-
 /*
  * macro of read/write
  */
Signature · 1 line
1.9.1
author
#3 lore raw

PATCH 4/4 soc_camera: ov772x: Include media/v4l2-image-sizes.h

In reply to Axel Lin

So we can remove the same defines in the driver code.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/media/i2c/soc_camera/ov772x.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/media/i2c/soc_camera/ov772x.c +1 -4
index 7f2b3c8..970a04e 100644
@@ -29,6 +29,7 @@
 #include <media/v4l2-clk.h>
 #include <media/v4l2-ctrls.h>
 #include <media/v4l2-subdev.h>
+#include <media/v4l2-image-sizes.h>
 
 /*
  * register offset

@@ -360,10 +361,6 @@
 #define SCAL0_ACTRL     0x08 /* Auto scaling factor control */
 #define SCAL1_2_ACTRL   0x04 /* Auto scaling factor control */
 
-#define VGA_WIDTH		640
-#define VGA_HEIGHT		480
-#define QVGA_WIDTH		320
-#define QVGA_HEIGHT		240
 #define OV772X_MAX_WIDTH	VGA_WIDTH
 #define OV772X_MAX_HEIGHT	VGA_HEIGHT
Signature · 1 line
1.9.1