Skip to contentSkip to conversation

Fix coding style in llite/remote_perm.c

PATCH In review Junien Fridrick 3 participants 4 messages Aug 9, 2014 – Aug 10, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix coding style in llite/remote_perm.c

Sorry for the noise, this is part of task 10 of the Eudyptula Challenge.

---
 drivers/staging/lustre/lustre/llite/remote_perm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/llite/remote_perm.c +1 -1
index f61fefc..3a9c8e8 100644
@@ -100,7 +100,7 @@ void free_rmtperm_hash(struct hlist_head *hash)
 	struct ll_remote_perm *lrp;
 	struct hlist_node *next;
 
-	if(!hash)
+	if (!hash)
 		return;
 
 	for (i = 0; i < REMOTE_PERM_HASHSIZE; i++)
Signature · 1 line
2.0.1
#1 lore raw
Quoted 1 line · Junien Fridrick

Sorry for the noise, this is part of task 10 of the Eudyptula Challenge.

Nothing wrong with the patch itself, but maybe in the future you could put such comments after the "---" line so that they won't be included in the git commit logs when the patch is applied (and will end up being "noise").

A.

#2 lore raw
In reply to Junien Fridrick
Quoted 1 line · Junien Fridrick

Sorry for the noise, this is part of task 10 of the Eudyptula Challenge.

It's not noise at all, but it's not needed in the changelog comment, as was pointed out.

Can you resend without this line, and actually say _what_ coding style change you made? And drop all of the [ ] in the subject, except for the [PATCH] part, that's not needed, just use ':' instead, so it would look like:
Subject: [PATCH] staging: lustre: fix...

thanks,

greg k-h

#3 lore raw

PATCH v2 1/1 staging: lustre: fix coding style issue: missing space after 'if'

Coding style issue reported by checkpatch.pl

---
This patch is part of task 10 of the eudyptula challenge Applies to next-20140808

v2 : fixed patch short summary and description

 drivers/staging/lustre/lustre/llite/remote_perm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/llite/remote_perm.c +1 -1
index f61fefc..3a9c8e8 100644
@@ -100,7 +100,7 @@ void free_rmtperm_hash(struct hlist_head *hash)
 	struct ll_remote_perm *lrp;
 	struct hlist_node *next;
 
-	if(!hash)
+	if (!hash)
 		return;
 
 	for (i = 0; i < REMOTE_PERM_HASHSIZE; i++)
Signature · 1 line
2.0.1