tst_device: use raw syscall in the tst_device.h
PATCH 1/1 tst_device: use raw syscall in the tst_device.h
From: Li Wang <[email protected]>
To follow up commit 447c223db ("tst_device: include unistd.h").
[pvorel: Removed _XOPEN_SOURCE from affected tests to really fix the issue and aren't needed]
---
Hi,
tested on
https://travis-ci.org/pevik/ltp/builds/635305638
Please anybody ack and merge, so we can move on with merging other things before git freeze.
NOTE: Debian failures are caused by bug in libtirpc 1.2.5, will be fixed by https://patchwork.ozlabs.org/patch/1216506/
Kind regards,
Petr
include/tst_device.h | 5 +++-- testcases/kernel/syscalls/fadvise/posix_fadvise01.c | 1 - testcases/kernel/syscalls/fadvise/posix_fadvise02.c | 1 - testcases/kernel/syscalls/fadvise/posix_fadvise03.c | 1 - testcases/kernel/syscalls/fadvise/posix_fadvise04.c | 1 - testcases/kernel/syscalls/pwrite/pwrite02.c | 2 -- 6 files changed, 3 insertions(+), 8 deletions(-)
include/tst_device.h +3 -2
@@ -19,6 +19,7 @@#define TST_DEVICE_H__ #include <unistd.h> +#include <sys/syscall.h> struct tst_device {const char *dev;
@@ -75,9 +76,9 @@ int tst_detach_device(const char *dev_path);* simply before the tst_dev_bytes_written invocation. For easy to use, * we create this inline function tst_dev_sync. */ -static inline void tst_dev_sync (int fd) +static inline int tst_dev_sync (int fd) { -syncfs (fd); +return syscall (__NR_syncfs, fd); }/*
testcases/kernel/syscalls/fadvise/posix_fadvise01.c +0 -1
@@ -20,7 +20,6 @@* None */ -#define _XOPEN_SOURCE 600#include <fcntl.h> #include <unistd.h>
testcases/kernel/syscalls/fadvise/posix_fadvise02.c +0 -1
@@ -20,7 +20,6 @@* None */ -#define _XOPEN_SOURCE 600#include <fcntl.h> #include <unistd.h> #include <signal.h>
testcases/kernel/syscalls/fadvise/posix_fadvise03.c +0 -1
@@ -20,7 +20,6 @@* None */ -#define _XOPEN_SOURCE 600#include <fcntl.h> #include <unistd.h> #include <signal.h>
testcases/kernel/syscalls/fadvise/posix_fadvise04.c +0 -1
@@ -20,7 +20,6 @@* None */ -#define _XOPEN_SOURCE 600#include <fcntl.h> #include <unistd.h> #include <signal.h>
testcases/kernel/syscalls/pwrite/pwrite02.c +0 -2
@@ -18,8 +18,6 @@* accessible address space, returns EFAULT. */ -#define _XOPEN_SOURCE 500 -#include <errno.h> #include <unistd.h> #include <string.h>
Signature · 1 line
2.24.0
PATCH 1/1 tst_device: use raw syscall in the tst_device.h
Hi!
Quoted 5 lines
tested on
https://travis-ci.org/pevik/ltp/builds/635305638Please anybody ack and merge, so we can move on with merging other things before git freeze.
Acked once and if the travis run finishes green.
Signature · 2 lines
Cyril Hrubis [email protected]
PATCH 1/1 tst_device: use raw syscall in the tst_device.h
Hi all,
Quoted 8 lines
Hi!
Quoted 5 lines
tested on
https://travis-ci.org/pevik/ltp/builds/635305638Please anybody ack and merge, so we can move on with merging other things before git freeze.
Acked once and if the travis run finishes green.
Merged. As I wrote, 3 broken Debian testing jobs are related to bug in libtirpc 1.2.5, which are fixed by following commit.
Kind regards,
Petr
PATCH 1/1 tst_device: use raw syscall in the tst_device.h
In reply to Cyril Hrubis----- Original Message -----
Quoted 8 lines
Hi!
Quoted 5 lines
tested on
https://travis-ci.org/pevik/ltp/builds/635305638Please anybody ack and merge, so we can move on with merging other things before git freeze.
Acked once and if the travis run finishes green.
Ack, looks good on RHEL too (6.10/7.8/8.1).
PATCH 1/1 tst_device: use raw syscall in the tst_device.h
Hi Jan,
Quoted 9 lines
Quoted 7 lines
Quoted 5 lines
tested on
https://travis-ci.org/pevik/ltp/builds/635305638Please anybody ack and merge, so we can move on with merging other things before git freeze.
Acked once and if the travis run finishes green.
Ack, looks good on RHEL too (6.10/7.8/8.1).
Thanks a lot for testing!
Sorry, I was faster, so merged without your ack.
Kind regards,
Petr
PATCH 1/1 tst_device: use raw syscall in the tst_device.h
----- Original Message -----
Quoted 8 lines
Hi Jan,
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
tested on
https://travis-ci.org/pevik/ltp/builds/635305638Please anybody ack and merge, so we can move on with merging other things before git freeze.
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Acked once and if the travis run finishes green.
Ack, looks good on RHEL too (6.10/7.8/8.1).
Thanks a lot for testing!
Sorry, I was faster, so merged without your ack.
No worries, thanks for getting this resolved.
PATCH 1/1 tst_device: use raw syscall in the tst_device.h
In reply to Petr VorelThanks Petr for help doing this, I'm on the way to visit Brno. Not convenient to connect internet until next week.
-- sending by my ph1 phone.
Quoted 129 lines · On Fri, Jan 10, 2020, 16:14 Petr Vorel <[email protected]> wrote:
From: Li Wang <[email protected]>
To follow up commit
447c223db("tst_device: includeunistd.h").Reported-by Petr Vorel <[email protected]>Suggested-by Cyril Hrubis <[email protected]>Signed-off-by Li Wang <[email protected]>Reviewed-by Cyril Hrubis <[email protected]>[pvorel: Removed
_XOPEN_SOURCEfrom affected tests to really fix the issue and aren't needed]Reviewed-by Petr Vorel <[email protected]>Tested-by Petr Vorel <[email protected]>Fixes eca0fa3c3 ("tst_device: add new tst_dev_sync")Signed-off-by Petr Vorel <[email protected]>---
Hi,tested on
https://travis-ci.org/pevik/ltp/builds/635305638Please anybody ack and merge, so we can move on with merging other things before git freeze.
NOTE: Debian failures are caused by bug in libtirpc 1.2.5, will be fixed by https://patchwork.ozlabs.org/patch/1216506/
Kind regards,
Petrinclude/tst_device.h | 5 +++-- testcases/kernel/syscalls/fadvise/posix_fadvise01.c | 1 - testcases/kernel/syscalls/fadvise/posix_fadvise02.c | 1 - testcases/kernel/syscalls/fadvise/posix_fadvise03.c | 1 - testcases/kernel/syscalls/fadvise/posix_fadvise04.c | 1 - testcases/kernel/syscalls/pwrite/pwrite02.c | 2 -- 6 files changed, 3 insertions(+), 8 deletions(-)include/tst_device.h +3
-2@@ -19,6 +19,7 @@#define TST_DEVICE_H__ #include <unistd.h> +#include <sys/syscall.h> struct tst_device {const char *dev;@@ -75,9 +76,9 @@ int tst_detach_device(const char *dev_path);* simply before the tst_dev_bytes_written invocation. For easy to use, * we create this inline function tst_dev_sync. */ -static inline void tst_dev_sync (int fd) +static inline int tst_dev_sync (int fd) { -syncfs (fd); +return syscall (__NR_syncfs, fd); }/* testcases/kernel/syscalls/fadvise/posix_fadvise01.c +0
-1@@ -20,7 +20,6 @@* None */ -#define _XOPEN_SOURCE 600#include <fcntl.h> #include <unistd.h> testcases/kernel/syscalls/fadvise/posix_fadvise02.c +0
-1@@ -20,7 +20,6 @@* None */ -#define _XOPEN_SOURCE 600#include <fcntl.h> #include <unistd.h> #include <signal.h> testcases/kernel/syscalls/fadvise/posix_fadvise03.c +0
-1@@ -20,7 +20,6 @@* None */ -#define _XOPEN_SOURCE 600#include <fcntl.h> #include <unistd.h> #include <signal.h> testcases/kernel/syscalls/fadvise/posix_fadvise04.c +0
-1@@ -20,7 +20,6 @@* None */ -#define _XOPEN_SOURCE 600#include <fcntl.h> #include <unistd.h> #include <signal.h> testcases/kernel/syscalls/pwrite/pwrite02.c +0
-3@@ -18,8 +18,6 @@* accessible address space, returns EFAULT. */ -#define _XOPEN_SOURCE 500 -#include <errno.h> #include <unistd.h> #include <string.h> --
Quoted 3 lines
2.24.0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200111/f89bbe68/attachment.htm>