Skip to contentSkip to conversation

fix checkpatch.pl issues of Base: attribute_container.c

PATCH New Tina Johnson 1 participant 3 messages Aug 11, 2014 Driver core

lore
Share & tools
lore
#0 lore raw

cover fix checkpatch.pl issues of Base: attribute_container.c

Clean-up patches to fix checkpatch.pl errors.

Tina Johnson (2):
Base: fix whitespace errors
Base: fix coding style issues

 drivers/base/attribute_container.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/2 Base: fix whitespace errors

This is a clean-up patch to the attribute_container.c file to fix the whitespace errors.

---
 drivers/base/attribute_container.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/base/attribute_container.c +5 -5
index b84ca8f..5917cc3 100644
@@ -76,7 +76,7 @@ attribute_container_register(struct attribute_container *cont)
 	INIT_LIST_HEAD(&cont->node);
 	klist_init(&cont->containers,internal_container_klist_get,
 		   internal_container_klist_put);
-		
+
 	mutex_lock(&attribute_container_mutex);
 	list_add_tail(&cont->node, &attribute_container_list);
 	mutex_unlock(&attribute_container_mutex);
@@ -104,14 +104,14 @@ attribute_container_unregister(struct attribute_container *cont)
 	spin_unlock(&cont->containers.k_lock);
 	mutex_unlock(&attribute_container_mutex);
 	return retval;
-		
+
 }
 EXPORT_SYMBOL_GPL(attribute_container_unregister);
 
 /* private function used as class release */
 static void attribute_container_release(struct device *classdev)
 {
-	struct internal_container *ic 
+	struct internal_container *ic
 		= container_of(classdev, struct internal_container, classdev);
 	struct device *dev = classdev->parent;
 
@@ -185,7 +185,7 @@ attribute_container_add_device(struct device *dev,
 		n ? container_of(n, typeof(*pos), member) : \
 			({ klist_iter_exit(iter) ; NULL; }); \
 	}) ) != NULL; )
-			
+
 
 /**
  * attribute_container_remove_device - make device eligible for removal.
@@ -247,7 +247,7 @@ attribute_container_remove_device(struct device *dev,
  * container, then use attribute_container_trigger() instead.
  */
 void
-attribute_container_device_trigger(struct device *dev, 
+attribute_container_device_trigger(struct device *dev,
 				   int (*fn)(struct attribute_container *,
 					     struct device *,
 					     struct device *))
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 2/2 Base: fix coding style issues

In reply to Tina Johnson

Fix checkpatch.pl issues with coding style. Added and removed spaces accordingly.

---
 drivers/base/attribute_container.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/base/attribute_container.c +2 -2
index 5917cc3..3ead3af 100644
@@ -74,7 +74,7 @@ int
 attribute_container_register(struct attribute_container *cont)
 {
 	INIT_LIST_HEAD(&cont->node);
-	klist_init(&cont->containers,internal_container_klist_get,
+	klist_init(&cont->containers, internal_container_klist_get,
 		   internal_container_klist_put);
 
 	mutex_lock(&attribute_container_mutex);
@@ -184,7 +184,7 @@ attribute_container_add_device(struct device *dev,
 		struct klist_node *n = klist_next(iter); \
 		n ? container_of(n, typeof(*pos), member) : \
 			({ klist_iter_exit(iter) ; NULL; }); \
-	}) ) != NULL; )
+	})) != NULL;)
 
 
 /**
Signature · 1 line
1.7.10.4