mfd: wm8994: declare dc servo register for wm8958 as volatile
Subsystems (2)
PATCH v2 1/1 mfd: wm8994: declare dc servo register for wm8958 as volatile
DC Servo register 57h holds the DC offset value after the hardware has completed the DC Servo Correction, so declare this register as volatile because it is changed by the hardware.
--- drivers/mfd/wm8994-regmap.c | 1 + 1 file changed, 1 insertion(+)
drivers/mfd/wm8994-regmap.c +1 -0
@@ -1169,6 +1169,7 @@ static bool wm8958_volatile_register(struct device *dev, unsigned int reg)case WM8958_FW_MINOR_0 :case WM8958_FW_PATCH_1 :case WM8958_FW_PATCH_0 : +case WM8994_DC_SERVO_4 :return true;default :return wm8994_volatile_register (dev, reg);
Signature · 1 line
1.7.9.5
Quoted 14 lines · Nikesh Oswal
DC Servo register 57h holds the DC offset value after the hardware has completed the DC Servo Correction, so declare this register as volatile because it is changed by the hardware.
Signed-off-by Nikesh Oswal <[email protected]>--- drivers/mfd/wm8994-regmap.c | 1 + 1 file changed, 1 insertion(+)drivers/mfd/wm8994-regmap.c +0
-0
drivers/mfd/wm8994-regmap.c static bool wm8958_volatile_register(struct device *dev, unsigned int reg) · line 1172
Quoted 4 lines
drivers/mfd/wm8994-regmap.c +1
-0@@ -1169,6 +1169,7 @@ static bool wm8958_volatile_register(struct device *dev, unsigned int reg)case WM8958_FW_MINOR_0 :case WM8958_FW_PATCH_1 :case WM8958_FW_PATCH_0 : +case WM8994_DC_SERVO_4 :
Looking at this again it looks like this should actually be in wm8994_volatile_register as some revs of the wm8994 use this register as well as the 8958 for the servo readback.
Then if you update the other patch to use this register for dsc_readback_mode = 1, then once we have a confirmation from hardware I think both of these patches are good to go.
Thanks,
Charles
Quoted 10 lines
drivers/mfd/wm8994-regmap.c +0
-0return true;default :return wm8994_volatile_register (dev, reg);Signature · 6 lines
1.7.9.5 _______________________________________________ patches mailing list [email protected] http://opensource.wolfsonmicro.com/cgi-bin/mailman/listinfo/patches