earlyprintk: re-enable earlyprintk calling early_param
PATCH 1/1 earlyprintk: re-enable earlyprintk calling early_param
From: Sahara <[email protected]>
Although there are many obs_kernel_param and its names are earlyprintk and also EARLY_PRINTK is also enabled, we could not see the early_printk output properly until now. This patch considers earlycon as well as earlyprintk.
--- init/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
init/main.c +2 -1
@@ -426,7 +426,8 @@ static int __init do_early_param(char *param, char *val, const char *unused)for (p = __setup_start; p < __setup_end; p++) {if ((p->early &¶meq (param, p->str)) || (strcmp (param,"console" ) ==0 && -strcmp (p->str,"earlycon" ) ==0 ) + ((strcmp (p->str,"earlycon" ) ==0 ) || + (strcmp (p->str,"earlyprintk" ) ==0 ))) ) {if (p->setup_func (val) !=0 )pr_warn ("Malformed early option '%s'\n" , param);
Signature · 1 line
1.7.9.5
Quoted 6 lines · On Thu, 14 Aug 2014 19:13:36 +0900 [email protected] wrote:
From: Sahara <[email protected]>
Although there are many
obs_kernel_paramand its names are earlyprintk and alsoEARLY_PRINTKis also enabled, we could not see theearly_printkoutput properly until now. This patch considers earlycon as well as earlyprintk.
Sorry, I just don't understand this description.
What does the patch actually do? What was the kernel behaviour without the patch and what is the kernel behaviour with the patch?
2014년 08월 15일 05:34, Andrew Morton 쓴 글:
Quoted 13 lines · On Thu, 14 Aug 2014 19:13:36 +0900 [email protected] wrote:
Quoted 7 lines
From: Sahara <[email protected]>
Although there are many
obs_kernel_paramand its names are earlyprintk and alsoEARLY_PRINTKis also enabled, we could not see theearly_printkoutput properly until now. This patch considers earlycon as well as earlyprintk.Sorry, I just don't understand this description.
What does the patch actually do? What was the kernel behaviour without the patch and what is the kernel behaviour with the patch?
Without this patch,
- earlycon case -
if early_param("earlycon", ...) is defined and
case #1: if cmdline has "earlycon", then it satisfies the condition "(p->early && parameq(param, p->str))". You can see early_printk(). case #2: if cmdline has "console", then it satisfies the condition "strcmp(param, "console") == 0 && strcmp(p->str, "earlycon") == 0". You can see early_printk().
- earlyprintk case -
if early_param("earlyprintk", ...) is defined and
case #1: if cmdline has "earlyprintk", then it satisfies the condition "(p->early && parameq(param, p->str))". You can see early_printk(). case #2: if cmdline has "console", it does not satisfies the condition, because it only checks out "earlycon" only.
This patch fixes the case #2 problem of earlyprintk.
Thanks.
Best Regards,
Sahara.
Quoted 6 lines · [email protected] writes:
From: Sahara <[email protected]>
Although there are many
obs_kernel_paramand its names are earlyprintk and alsoEARLY_PRINTKis also enabled, we could not see theearly_printkoutput properly until now. This patch considers earlycon as well as earlyprintk.
Hmm, the initial "earlycon" hack slipped in when I wasn't looking. I don't think we should extend it.
Why not make the thing(s) you want early_param()s?
Cheers,
Rusty.
Quoted 14 lines
init/main.c +2
-1@@ -426,7 +426,8 @@ static int __init do_early_param(char *param, char *val, const char *unused)for (p = __setup_start; p < __setup_end; p++) {if ((p->early &¶meq (param, p->str)) || (strcmp (param,"console" ) ==0 && -strcmp (p->str,"earlycon" ) ==0 ) + ((strcmp (p->str,"earlycon" ) ==0 ) || + (strcmp (p->str,"earlyprintk" ) ==0 ))) ) {if (p->setup_func (val) !=0 )pr_warn ("Malformed early option '%s'\n" , param);Signature · 1 line
1.7.9.5
2014년 08월 16일 03:34, Rusty Russell 쓴 글:
Quoted 7 lines
Quoted 6 lines · [email protected] writes:
From: Sahara <[email protected]>
Although there are many
obs_kernel_paramand its names are earlyprintk and alsoEARLY_PRINTKis also enabled, we could not see theearly_printkoutput properly until now. This patch considers earlycon as well as earlyprintk.
Quoted 7 lines
Hmm, the initial "earlycon" hack slipped in when I wasn't looking. I don't think we should extend it.
Why not make the thing(s) you want early_param()s?
Cheers,
Rusty.
The earlycon and the earlyprintk are scattered and used in many architectures.
It looks earlycon just could be a subset of earlyprintk.
The earlycon is for uart specific, while the earlyprintk is to support vga, efi, xen, serial, and so on. Especially ARM uses earlyprintk in many places. And, I am not sure if this is a good chance to replace all the earlyprintk with the earlycon. As of now, it's fair for both earlycon and earlyprintk. Or perhaps removing case#2, see in my previous email to Andrew Morton, is better?, so users be forced to specify earlycon and earlyprintk in cmdline if they want to see early_printk() output.
Thanks.
Best Regards,
Sahara.
Quoted 15 lines
Quoted 15 lines
init/main.c +2
-1@@ -426,7 +426,8 @@ static int __init do_early_param(char *param, char *val, const char *unused)for (p = __setup_start; p < __setup_end; p++) {if ((p->early &¶meq (param, p->str)) || (strcmp (param,"console" ) ==0 && -strcmp (p->str,"earlycon" ) ==0 ) + ((strcmp (p->str,"earlycon" ) ==0 ) || + (strcmp (p->str,"earlyprintk" ) ==0 ))) ) {if (p->setup_func (val) !=0 )pr_warn ("Malformed early option '%s'\n" , param);Signature · 1 line
1.7.9.5
FYI only if you missed my previous 2 replies which didn't reach the mailing list.
Thanks.
Quoted 56 lines · Sahara
2014년 08월 16일 03:34, Rusty Russell 쓴 글:
Quoted 9 lines
Quoted 7 lines · [email protected] writes:
From: Sahara <[email protected]>
Although there are many
obs_kernel_paramand its names are earlyprintk and alsoEARLY_PRINTKis also enabled, we could not see theearly_printkoutput properly until now. This patch considers earlycon as well as earlyprintk.Quoted 7 lines
Hmm, the initial "earlycon" hack slipped in when I wasn't looking. I don't think we should extend it.
Why not make the thing(s) you want early_param()s?
Cheers,
Rusty.The earlycon and the earlyprintk are scattered and used in many architectures.
It looks earlycon just could be a subset of earlyprintk.
The earlycon is for uart specific, while the earlyprintk is to support vga, efi, xen, serial, and so on. Especially ARM uses earlyprintk in many places. And, I am not sure if this is a good chance to replace all the earlyprintk with the earlycon. As of now, it's fair for both earlycon and earlyprintk. Or perhaps removing case#2, see in my previous email to Andrew Morton, is better?, so users be forced to specify earlycon and earlyprintk in cmdline if they want to seeearly_printk()output.Thanks.
Best Regards,
Sahara.Quoted 17 lines
Quoted 17 lines
init/main.c +2
-1@@ -426,7 +426,8 @@ static int __init do_early_param(char *param, char *val, const char *unused)for (p = __setup_start; p < __setup_end; p++) {if ((p->early &¶meq (param, p->str)) || (strcmp (param,"console" ) ==0 && -strcmp (p->str,"earlycon" ) ==0 ) + ((strcmp (p->str,"earlycon" ) ==0 ) || + (strcmp (p->str,"earlyprintk" ) ==0 ))) ) {if (p->setup_func (val) !=0 )pr_warn("Malformed early option '%s'\n",
param);
--
1.7.9.5
Quoted 17 lines · On Thu, Aug 14, 2014 at 07:13:36PM +0900, [email protected] wrote:
From: Sahara <[email protected]>
Although there are many
obs_kernel_paramand its names are earlyprintk and alsoEARLY_PRINTKis also enabled, we could not see theearly_printkoutput properly until now. This patch considers earlycon as well as earlyprintk.Signed-off-by Sahara <[email protected]>--- init/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)init/main.c +0
-0
init/main.c static int __init do_early_param(char *param, char *val, const char *unused) · line 433
Quoted 9 lines
init/main.c +2
-1@@ -426,7 +426,8 @@ static int __init do_early_param(char *param, char *val, const char *unused)for (p = __setup_start; p < __setup_end; p++) {if ((p->early &¶meq (param, p->str)) || (strcmp (param,"console" ) ==0 && -strcmp (p->str,"earlycon" ) ==0 ) + ((strcmp (p->str,"earlycon" ) ==0 ) || + (strcmp (p->str,"earlyprintk" ) ==0 ))) ) {if (p->setup_func (val) !=0 )pr_warn ("Malformed early option '%s'\n" , param);
It seems like this patch causes the following warning for me during boot:
[ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Initializing cgroup subsys cpu [ 0.000000] Initializing cgroup subsys cpuacct [ 0.000000] Linux version 3.17.0-rc2-next-20140827 (thierry.reding@ulmo) (gcc version 4.9.0 (GCC) ) #18 SMP PREEMPT Wed Aug 27 17:08:12 CEST 2014 [ 0.000000] CPU: ARMv7 Processor [413fc0f3] revision 3 (ARMv7), cr=10c5387d [ 0.000000] CPU: PIPT / VIPT nonaliasing data cache, PIPT instruction cache [ 0.000000] Machine model: NVIDIA Tegra124 Jetson TK1 [ 0.000000] bootconsole [earlycon0] enabled [ 0.000000] debug: ignoring loglevel setting. [ 0.000000] ------------[ cut here ]------------ [ 0.000000] WARNING: CPU: 0 PID: 0 at /home/thierry.reding/src/kernel/linux-work.git/kernel/printk/printk.c:2402 register_console+0x60/0x37c() [ 0.000000] console 'earlycon0' already registered [ 0.000000] Modules linked in: [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 3.17.0-rc2-next-20140827 #18 [ 0.000000] [<c0015fec>] (unwind_backtrace) from [<c0011aac>] (show_stack+0x10/0x14) [ 0.000000] [<c0011aac>] (show_stack) from [<c062b700>] (dump_stack+0x98/0xd8) [ 0.000000] [<c062b700>] (dump_stack) from [<c0025ba0>] (warn_slowpath_common+0x70/0x8c) [ 0.000000] [<c0025ba0>] (warn_slowpath_common) from [<c0025bec>] (warn_slowpath_fmt+0x30/0x40) [ 0.000000] [<c0025bec>] (warn_slowpath_fmt) from [<c00639b8>] (register_console+0x60/0x37c) [ 0.000000] [<c00639b8>] (register_console) from [<c0883870>] (setup_early_printk+0x20/0x28) [ 0.000000] [<c0883870>] (setup_early_printk) from [<c087f43c>] (do_early_param+0x6c/0xd0) [ 0.000000] [<c087f43c>] (do_early_param) from [<c003cba0>] (parse_args+0x238/0x3d0) [ 0.000000] [<c003cba0>] (parse_args) from [<c087f814>] (parse_early_options+0x38/0x40) [ 0.000000] [<c087f814>] (parse_early_options) from [<c087f84c>] (parse_early_param+0x30/0x40) [ 0.000000] [<c087f84c>] (parse_early_param) from [<c088206c>] (setup_arch+0x4b4/0x974) [ 0.000000] [<c088206c>] (setup_arch) from [<c087f8f8>] (start_kernel+0x98/0x3a8) [ 0.000000] [<c087f8f8>] (start_kernel) from [<80008074>] (0x80008074) [ 0.000000] ---[ end trace cb88537fdc8fa200 ]--- [ 0.000000] cma: Reserved 128 MiB at a7800000 [ 0.000000] Memory policy: Data cache writealloc [ 0.000000] On node 0 totalpages: 524032 [ 0.000000] free_area_init_node: node 0, pgdat c091cc00, node_mem_map e67b7000 [ 0.000000] Normal zone: 1520 pages used for memmap [ 0.000000] Normal zone: 0 pages reserved [ 0.000000] Normal zone: 194560 pages, LIFO batch:31 [ 0.000000] HighMem zone: 2574 pages used for memmap [ 0.000000] HighMem zone: 329472 pages, LIFO batch:31 [ 0.000000] PERCPU: Embedded 8 pages/cpu @e6767000 s8832 r8192 d15744 u32768 [ 0.000000] pcpu-alloc: s8832 r8192 d15744 u32768 alloc=8*4096 [ 0.000000] pcpu-alloc: [0] 0 [0] 1 [0] 2 [0] 3 [ 0.000000] Built 1 zonelists in Zone order, mobility grouping on. Total pages: 522512 [ 0.000000] Kernel command line: console=ttyS0,115200n8 ignore_loglevel rootwait ro earlyprintk ip=:::::eth0:dhcp root=/dev/nfs nfsroot=192.168.69.100:/srv/nfs/tegra124 drm.debug=0xf cma=128M
Reverting the patch eliminates the warning. earlyprintk does work fine for me without this patch.
Thierry
Quoted 13 lines · Thierry Reding
Quoted 12 lines · On Thu, Aug 14, 2014 at 07:13:36PM +0900, [email protected] wrote:
From: Sahara <[email protected]>
Although there are many
obs_kernel_paramand its names are earlyprintk and alsoEARLY_PRINTKis also enabled, we could not see theearly_printkoutput properly until now. This patch considers earlycon as well as earlyprintk.Signed-off-by Sahara <[email protected]>--- init/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 5 lines
init/main.c static int __init do_early_param(char *param, char
Quoted 5 lines
init/main.c +0
-0@@ -426,7 +426,8 @@ static int __init do_early_param(char *param, char
*val, const char *unused)
Quoted 9 lines
init/main.c static int __init do_early_param(char *param, char *val, const char *unused)
Quoted 9 lines
init/main.c +2
-1for (p = __setup_start; p < __setup_end; p++) {if ((p->early &¶meq (param, p->str)) || (strcmp (param,"console" ) ==0 && -strcmp (p->str,"earlycon" ) ==0 ) + ((strcmp (p->str,"earlycon" ) ==0 ) || + (strcmp (p->str,"earlyprintk" ) ==0 ))) ) {if (p->setup_func (val) !=0 ) pr_warn("Malformed early option '%s'\n",
param);
Quoted 8 lines
It seems like this patch causes the following warning for me during boot:
[ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Initializing cgroup subsys cpu [ 0.000000] Initializing cgroup subsys cpuacct [ 0.000000] Linux version 3.17.0-rc2-next-20140827
(thierry.reding@ulmo) (gcc version 4.9.0 (GCC) ) #18 SMP PREEMPT Wed Aug 27 17:08:12 CEST 2014
Quoted 1 line
[ 0.000000] CPU: ARMv7 Processor [413fc0f3] revision 3 (ARMv7),
cr=10c5387d
Quoted 1 line
[ 0.000000] CPU: PIPT / VIPT nonaliasing data cache, PIPT instruction
cache
Quoted 5 lines
[ 0.000000] Machine model: NVIDIA Tegra124 Jetson TK1 [ 0.000000] bootconsole [earlycon0] enabled [ 0.000000] debug: ignoring loglevel setting. [ 0.000000] ------------[ cut here ]------------ [ 0.000000] WARNING: CPU: 0 PID: 0 at
/home/thierry.reding/src/kernel/linux-work.git/kernel/printk/printk.c:2402 register_console+0x60/0x37c()
Quoted 3 lines
[ 0.000000] console 'earlycon0' already registered [ 0.000000] Modules linked in: [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted
3.17.0-rc2-next-20140827 #18
Quoted 1 line
[ 0.000000] [<c0015fec>] (unwind_backtrace) from [<c0011aac>]
(show_stack+0x10/0x14)
Quoted 1 line
[ 0.000000] [<c0011aac>] (show_stack) from [<c062b700>]
(dump_stack+0x98/0xd8)
Quoted 1 line
[ 0.000000] [<c062b700>] (dump_stack) from [<c0025ba0>]
(warn_slowpath_common+0x70/0x8c)
Quoted 1 line
[ 0.000000] [<c0025ba0>] (warn_slowpath_common) from [<c0025bec>]
(warn_slowpath_fmt+0x30/0x40)
Quoted 1 line
[ 0.000000] [<c0025bec>] (warn_slowpath_fmt) from [<c00639b8>]
(register_console+0x60/0x37c)
Quoted 1 line
[ 0.000000] [<c00639b8>] (register_console) from [<c0883870>]
(setup_early_printk+0x20/0x28)
Quoted 1 line
[ 0.000000] [<c0883870>] (setup_early_printk) from [<c087f43c>]
(do_early_param+0x6c/0xd0)
Quoted 1 line
[ 0.000000] [<c087f43c>] (do_early_param) from [<c003cba0>]
(parse_args+0x238/0x3d0)
Quoted 1 line
[ 0.000000] [<c003cba0>] (parse_args) from [<c087f814>]
(parse_early_options+0x38/0x40)
Quoted 1 line
[ 0.000000] [<c087f814>] (parse_early_options) from [<c087f84c>]
(parse_early_param+0x30/0x40)
Quoted 1 line
[ 0.000000] [<c087f84c>] (parse_early_param) from [<c088206c>]
(setup_arch+0x4b4/0x974)
Quoted 1 line
[ 0.000000] [<c088206c>] (setup_arch) from [<c087f8f8>]
(start_kernel+0x98/0x3a8)
Quoted 1 line
[ 0.000000] [<c087f8f8>] (start_kernel) from [<80008074>]
(0x80008074)
Quoted 5 lines
[ 0.000000] ---[ end trace cb88537fdc8fa200 ]--- [ 0.000000] cma: Reserved 128 MiB at a7800000 [ 0.000000] Memory policy: Data cache writealloc [ 0.000000] On node 0 totalpages: 524032 [ 0.000000] free_area_init_node: node 0, pgdat c091cc00, node_mem_map
e67b7000
Quoted 6 lines
[ 0.000000] Normal zone: 1520 pages used for memmap [ 0.000000] Normal zone: 0 pages reserved [ 0.000000] Normal zone: 194560 pages, LIFO batch:31 [ 0.000000] HighMem zone: 2574 pages used for memmap [ 0.000000] HighMem zone: 329472 pages, LIFO batch:31 [ 0.000000] PERCPU: Embedded 8 pages/cpu @e6767000 s8832 r8192 d15744
u32768
Quoted 3 lines
[ 0.000000] pcpu-alloc: s8832 r8192 d15744 u32768 alloc=8*4096 [ 0.000000] pcpu-alloc: [0] 0 [0] 1 [0] 2 [0] 3 [ 0.000000] Built 1 zonelists in Zone order, mobility grouping on.
Total pages: 522512
Quoted 1 line
[ 0.000000] Kernel command line: console=ttyS0,115200n8
ignore_loglevel rootwait ro earlyprintk ip=:::::eth0:dhcp root=/dev/nfs nfsroot=192.168.69.100:/srv/nfs/tegra124 drm.debug=0xf cma=128M
Quoted 5 lines
Reverting the patch eliminates the warning. earlyprintk does work fine for me without this patch.
Thierry
This warning message is caused by specifying 'earlyprintk' in your command line args. Same problem may happen if you specify 'earlycon' in your command line args and enable CONFIG_SERIAL_EARLYCON with the current code without this patch. I think it's appropriate result letting a developer know that both ways of using earlyprintk are enabled. With current code, although a developer enables CONFIG_EARLY_PRINTK and has "console=" arg in command line args, he/she should specify the 'earlyprintk' in command line args also to see early_printk() outputs. With this patch, simply enabling CONFIG_EARLY_PRINTK and having 'console=' line make you be able to the early_printk().
Nonetheless I want to retract this patch. It's good for ARM, but not good for other architectures such as x86. And, because CONFIG_EARLY_PRINTK is depending on DEBUG_LL in ARM, making a relation with "console=" is absurd. (see strcmp(param, "console") == 0 && strcmp(p->str, "earlyprintk") == 0)
- Sahara
Quoted 122 lines · Sahara
Quoted 13 lines · Thierry Reding
Quoted 12 lines · On Thu, Aug 14, 2014 at 07:13:36PM +0900, [email protected] wrote:
From: Sahara <[email protected]>
Although there are many
obs_kernel_paramand its names are earlyprintk and alsoEARLY_PRINTKis also enabled, we could not see theearly_printkoutput properly until now. This patch considers earlycon as well as earlyprintk.Signed-off-by Sahara <[email protected]>--- init/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 5 lines
init/main.c static int __init do_early_param(char *param, char
Quoted 5 lines
init/main.c +0
-0@@ -426,7 +426,8 @@ static int __init do_early_param(char *param, char*val, const char *unused)
Quoted 9 lines
init/main.c static int __init do_early_param(char *param, char *val, const char *unused)
Quoted 9 lines
init/main.c +2
-1for (p = __setup_start; p < __setup_end; p++) {if ((p->early &¶meq (param, p->str)) || (strcmp (param,"console" ) ==0 && -strcmp (p->str,"earlycon" ) ==0 ) + ((strcmp (p->str,"earlycon" ) ==0 ) || + (strcmp (p->str,"earlyprintk" ) ==0 ))) ) {if (p->setup_func (val) !=0 ) pr_warn("Malformed early option '%s'\n",param);
Quoted 8 lines
It seems like this patch causes the following warning for me during boot:
[ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Initializing cgroup subsys cpu [ 0.000000] Initializing cgroup subsys cpuacct [ 0.000000] Linux version 3.17.0-rc2-next-20140827(thierry.reding@ulmo) (gcc version 4.9.0 (GCC) ) #18 SMP PREEMPT Wed Aug 27 17:08:12 CEST 2014
Quoted 1 line
[ 0.000000] CPU: ARMv7 Processor [413fc0f3] revision 3 (ARMv7),cr=10c5387d
Quoted 1 line
[ 0.000000] CPU: PIPT / VIPT nonaliasing data cache, PIPT instructioncache
Quoted 5 lines
[ 0.000000] Machine model: NVIDIA Tegra124 Jetson TK1 [ 0.000000] bootconsole [earlycon0] enabled [ 0.000000] debug: ignoring loglevel setting. [ 0.000000] ------------[ cut here ]------------ [ 0.000000] WARNING: CPU: 0 PID: 0 at
/home/thierry.reding/src/kernel/linux-work.git/kernel/printk/printk.c:2402register_console+0x60/0x37c()Quoted 3 lines
[ 0.000000] console 'earlycon0' already registered [ 0.000000] Modules linked in: [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted3.17.0-rc2-next-20140827 #18
Quoted 1 line
[ 0.000000] [<c0015fec>] (unwind_backtrace) from [<c0011aac>](
show_stack+0x10/0x14)Quoted 1 line
[ 0.000000] [<c0011aac>] (show_stack) from [<c062b700>](
dump_stack+0x98/0xd8)Quoted 1 line
[ 0.000000] [<c062b700>] (dump_stack) from [<c0025ba0>](
warn_slowpath_common+0x70/0x8c)Quoted 1 line
[ 0.000000] [<c0025ba0>] (warn_slowpath_common) from [<c0025bec>](
warn_slowpath_fmt+0x30/0x40)Quoted 1 line
[ 0.000000] [<c0025bec>] (warn_slowpath_fmt) from [<c00639b8>](
register_console+0x60/0x37c)Quoted 1 line
[ 0.000000] [<c00639b8>] (register_console) from [<c0883870>](
setup_early_printk+0x20/0x28)Quoted 1 line
[ 0.000000] [<c0883870>] (setup_early_printk) from [<c087f43c>](
do_early_param+0x6c/0xd0)Quoted 1 line
[ 0.000000] [<c087f43c>] (do_early_param) from [<c003cba0>](
parse_args+0x238/0x3d0)Quoted 1 line
[ 0.000000] [<c003cba0>] (parse_args) from [<c087f814>](
parse_early_options+0x38/0x40)Quoted 1 line
[ 0.000000] [<c087f814>] (parse_early_options) from [<c087f84c>](
parse_early_param+0x30/0x40)Quoted 1 line
[ 0.000000] [<c087f84c>] (parse_early_param) from [<c088206c>](
setup_arch+0x4b4/0x974)Quoted 1 line
[ 0.000000] [<c088206c>] (setup_arch) from [<c087f8f8>](
start_kernel+0x98/0x3a8)Quoted 1 line
[ 0.000000] [<c087f8f8>] (start_kernel) from [<80008074>](
0x80008074)Quoted 5 lines
[ 0.000000] ---[ end trace cb88537fdc8fa200 ]--- [ 0.000000] cma: Reserved 128 MiB at a7800000 [ 0.000000] Memory policy: Data cache writealloc [ 0.000000] On node 0 totalpages: 524032 [ 0.000000] free_area_init_node: node 0, pgdat c091cc00, node_mem_map
e67b7000Quoted 6 lines
[ 0.000000] Normal zone: 1520 pages used for memmap [ 0.000000] Normal zone: 0 pages reserved [ 0.000000] Normal zone: 194560 pages, LIFO batch:31 [ 0.000000] HighMem zone: 2574 pages used for memmap [ 0.000000] HighMem zone: 329472 pages, LIFO batch:31 [ 0.000000] PERCPU: Embedded 8 pages/cpu @e6767000 s8832 r8192 d15744u32768
Quoted 3 lines
[ 0.000000] pcpu-alloc: s8832 r8192 d15744 u32768 alloc=8*4096 [ 0.000000] pcpu-alloc: [0] 0 [0] 1 [0] 2 [0] 3 [ 0.000000] Built 1 zonelists in Zone order, mobility grouping on.Total pages: 522512
Quoted 1 line
[ 0.000000] Kernel command line: console=ttyS0,115200n8
ignore_loglevelrootwait ro earlyprintk ip=:::::eth0:dhcp root=/dev/nfs nfsroot=192.168.69.100:/srv/nfs/tegra124 drm.debug=0xf cma=128MQuoted 5 lines
Reverting the patch eliminates the warning. earlyprintk does work fine for me without this patch.
Thierry
This warning message is caused by specifying 'earlyprintk' in your command line args. Same problem may happen if you specify 'earlycon' in your command line args and enable
CONFIG_SERIAL_EARLYCONwith the current code without this patch. I think it's appropriate result letting a developer know that both ways of using earlyprintk are enabled. With current code, although a developer enablesCONFIG_EARLY_PRINTKand has "console=" arg in command line args, he/she should specify the 'earlyprintk' in command line args also to seeearly_printk()outputs. With this patch, simply enablingCONFIG_EARLY_PRINTKand having 'console=' line make you be able to theearly_printk().
Quoted 4 lines
Nonetheless I want to retract this patch. It's good for ARM, but not good for other architectures such as x86. And, because
CONFIG_EARLY_PRINTKis depending onDEBUG_LLin ARM, making a relation with "console=" is absurd. (seestrcmp(param, "console")== 0 &&strcmp(p->str, "earlyprintk")== 0)
Even on ARM, this patch feels like the wrong thing. After all, I can build a DEBUG_LL enabled multi-platform kernel, and boot it on a bunch of different SoCs. However, earlyprintk will only work on one (or zero) of those SoCs, and hence shouldn't automatically enable itself; specifically requesting activation using the earlyprintk kernel command-line parameter is the correct approach.
Quoted 123 lines · Stephen Warren
Quoted 122 lines · Sahara
Quoted 13 lines · Thierry Reding
Quoted 12 lines · On Thu, Aug 14, 2014 at 07:13:36PM +0900, [email protected] wrote:
From: Sahara <[email protected]>
Although there are many
obs_kernel_paramand its names are earlyprintk and alsoEARLY_PRINTKis also enabled, we could not see theearly_printkoutput properly until now. This patch considers earlycon as well as earlyprintk.Signed-off-by Sahara <[email protected]>--- init/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 5 lines
init/main.c static int __init do_early_param(char *param, char
Quoted 5 lines
init/main.c +0
-0@@ -426,7 +426,8 @@ static int __init do_early_param(char *param, char*val, const char *unused)
Quoted 9 lines
init/main.c static int __init do_early_param(char *param, char *val, const char *unused)
Quoted 9 lines
init/main.c +2
-1for (p = __setup_start; p < __setup_end; p++) {if ((p->early &¶meq (param, p->str)) || (strcmp (param,"console" ) ==0 && -strcmp (p->str,"earlycon" ) ==0 ) + ((strcmp (p->str,"earlycon" ) ==0 ) || + (strcmp (p->str,"earlyprintk" ) ==0 ))) ) {if (p->setup_func (val) !=0 ) pr_warn("Malformed early option '%s'\n",param);
Quoted 8 lines
It seems like this patch causes the following warning for me during boot:
[ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Initializing cgroup subsys cpu [ 0.000000] Initializing cgroup subsys cpuacct [ 0.000000] Linux version 3.17.0-rc2-next-20140827(thierry.reding@ulmo) (gcc version 4.9.0 (GCC) ) #18 SMP PREEMPT Wed Aug 27 17:08:12 CEST 2014
Quoted 1 line
[ 0.000000] CPU: ARMv7 Processor [413fc0f3] revision 3 (ARMv7),cr=10c5387d
Quoted 1 line
[ 0.000000] CPU: PIPT / VIPT nonaliasing data cache, PIPT instructioncache
Quoted 5 lines
[ 0.000000] Machine model: NVIDIA Tegra124 Jetson TK1 [ 0.000000] bootconsole [earlycon0] enabled [ 0.000000] debug: ignoring loglevel setting. [ 0.000000] ------------[ cut here ]------------ [ 0.000000] WARNING: CPU: 0 PID: 0 at
/home/thierry.reding/src/kernel/linux-work.git/kernel/printk/printk.c:2402register_console+0x60/0x37c()Quoted 3 lines
[ 0.000000] console 'earlycon0' already registered [ 0.000000] Modules linked in: [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted3.17.0-rc2-next-20140827 #18
Quoted 1 line
[ 0.000000] [<c0015fec>] (unwind_backtrace) from [<c0011aac>](
show_stack+0x10/0x14)Quoted 1 line
[ 0.000000] [<c0011aac>] (show_stack) from [<c062b700>](
dump_stack+0x98/0xd8)Quoted 1 line
[ 0.000000] [<c062b700>] (dump_stack) from [<c0025ba0>](
warn_slowpath_common+0x70/0x8c)Quoted 1 line
[ 0.000000] [<c0025ba0>] (warn_slowpath_common) from [<c0025bec>](
warn_slowpath_fmt+0x30/0x40)Quoted 1 line
[ 0.000000] [<c0025bec>] (warn_slowpath_fmt) from [<c00639b8>](
register_console+0x60/0x37c)Quoted 1 line
[ 0.000000] [<c00639b8>] (register_console) from [<c0883870>](
setup_early_printk+0x20/0x28)Quoted 1 line
[ 0.000000] [<c0883870>] (setup_early_printk) from [<c087f43c>](
do_early_param+0x6c/0xd0)Quoted 1 line
[ 0.000000] [<c087f43c>] (do_early_param) from [<c003cba0>](
parse_args+0x238/0x3d0)Quoted 1 line
[ 0.000000] [<c003cba0>] (parse_args) from [<c087f814>](
parse_early_options+0x38/0x40)Quoted 1 line
[ 0.000000] [<c087f814>] (parse_early_options) from [<c087f84c>](
parse_early_param+0x30/0x40)Quoted 1 line
[ 0.000000] [<c087f84c>] (parse_early_param) from [<c088206c>](
setup_arch+0x4b4/0x974)Quoted 1 line
[ 0.000000] [<c088206c>] (setup_arch) from [<c087f8f8>](
start_kernel+0x98/0x3a8)Quoted 1 line
[ 0.000000] [<c087f8f8>] (start_kernel) from [<80008074>](
0x80008074)Quoted 5 lines
[ 0.000000] ---[ end trace cb88537fdc8fa200 ]--- [ 0.000000] cma: Reserved 128 MiB at a7800000 [ 0.000000] Memory policy: Data cache writealloc [ 0.000000] On node 0 totalpages: 524032 [ 0.000000] free_area_init_node: node 0, pgdat c091cc00, node_mem_map
e67b7000Quoted 6 lines
[ 0.000000] Normal zone: 1520 pages used for memmap [ 0.000000] Normal zone: 0 pages reserved [ 0.000000] Normal zone: 194560 pages, LIFO batch:31 [ 0.000000] HighMem zone: 2574 pages used for memmap [ 0.000000] HighMem zone: 329472 pages, LIFO batch:31 [ 0.000000] PERCPU: Embedded 8 pages/cpu @e6767000 s8832 r8192 d15744u32768
Quoted 3 lines
[ 0.000000] pcpu-alloc: s8832 r8192 d15744 u32768 alloc=8*4096 [ 0.000000] pcpu-alloc: [0] 0 [0] 1 [0] 2 [0] 3 [ 0.000000] Built 1 zonelists in Zone order, mobility grouping on.Total pages: 522512
Quoted 1 line
[ 0.000000] Kernel command line: console=ttyS0,115200n8
ignore_loglevelrootwait ro earlyprintk ip=:::::eth0:dhcp root=/dev/nfs nfsroot=192.168.69.100:/srv/nfs/tegra124 drm.debug=0xf cma=128MQuoted 5 lines
Reverting the patch eliminates the warning. earlyprintk does work fine for me without this patch.
Thierry
This warning message is caused by specifying 'earlyprintk' in your command line args. Same problem may happen if you specify 'earlycon' in your command line args and enable
CONFIG_SERIAL_EARLYCONwith the current code without this patch. I think it's appropriate result letting a developer know that both ways of using earlyprintk are enabled. With current code, although a developer enablesCONFIG_EARLY_PRINTKand has "console=" arg in command line args, he/she should specify the 'earlyprintk' in command line args also to seeearly_printk()outputs. With this patch, simply enablingCONFIG_EARLY_PRINTKand having 'console=' line make you be able to theearly_printk().
Quoted 7 lines
Quoted 4 lines
Nonetheless I want to retract this patch. It's good for ARM, but not good for other architectures such as x86. And, because
CONFIG_EARLY_PRINTKis depending onDEBUG_LLin ARM, making a relation with "console=" is absurd. (seestrcmp(param, "console")== 0 &&strcmp(p->str, "earlyprintk")== 0)Even on ARM, this patch feels like the wrong thing. After all, I can build a
DEBUG_LLenabled multi-platform kernel, and boot it on a bunch of different SoCs. However, earlyprintk will only work on one (or zero) of those SoCs, and hence shouldn't automatically enable itself; specifically requesting activation using the earlyprintk kernel command-line parameter is the correct approach.
So you are saying, because DEBUG_LL didn't work on several SoCs, using the earlyprintk in command line args is the correct approach?
You are misunderstanding how it works. On ARM with enabling multi-platform kernel, you should choose a specific low-level debug port for DEBUG_LL. For example, if you have OMAP ZOOM3, you should select CONFIG_DEBUG_ZOOM_UART from menu.
If you chose a right port for your SoCs and if it didn't work properly, that means its port code should be fixed. (Please report it.) All the code for low-level debugging is located at arch/arm/include/debug.
- Sahara
Quoted 150 lines · Sahara
Quoted 138 lines · Stephen Warren
Quoted 129 lines · Sahara
Quoted 13 lines · Thierry Reding
Quoted 12 lines · On Thu, Aug 14, 2014 at 07:13:36PM +0900, [email protected] wrote:
From: Sahara <[email protected]>
Although there are many
obs_kernel_paramand its names are earlyprintk and alsoEARLY_PRINTKis also enabled, we could not see theearly_printkoutput properly until now. This patch considers earlycon as well as earlyprintk.Signed-off-by Sahara <[email protected]>--- init/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 5 lines
init/main.c static int __init do_early_param(char *param, char
Quoted 5 lines
init/main.c +0
-0@@ -426,7 +426,8 @@ static int __init do_early_param(char *param, char*val, const char *unused)
Quoted 9 lines
init/main.c static int __init do_early_param(char *param, char *val, const char *unused)
Quoted 9 lines
init/main.c +2
-1for (p = __setup_start; p < __setup_end; p++) {if ((p->early &¶meq (param, p->str)) || (strcmp (param,"console" ) ==0 && -strcmp (p->str,"earlycon" ) ==0 ) + ((strcmp (p->str,"earlycon" ) ==0 ) || + (strcmp (p->str,"earlyprintk" ) ==0 ))) ) {if (p->setup_func (val) !=0 ) pr_warn("Malformed early option '%s'\n",param);
Quoted 8 lines
It seems like this patch causes the following warning for me during boot:
[ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Initializing cgroup subsys cpu [ 0.000000] Initializing cgroup subsys cpuacct [ 0.000000] Linux version 3.17.0-rc2-next-20140827(thierry.reding@ulmo) (gcc version 4.9.0 (GCC) ) #18 SMP PREEMPT Wed Aug 27 17:08:12 CEST 2014
Quoted 1 line
[ 0.000000] CPU: ARMv7 Processor [413fc0f3] revision 3 (ARMv7),cr=10c5387d
Quoted 2 lines
[ 0.000000] CPU: PIPT / VIPT nonaliasing data cache, PIPTinstruction
cache
Quoted 5 lines
[ 0.000000] Machine model: NVIDIA Tegra124 Jetson TK1 [ 0.000000] bootconsole [earlycon0] enabled [ 0.000000] debug: ignoring loglevel setting. [ 0.000000] ------------[ cut here ]------------ [ 0.000000] WARNING: CPU: 0 PID: 0 at
/home/thierry.reding/src/kernel/linux-work.git/kernel/printk/printk.c:2402register_console+0x60/0x37c()
Quoted 3 lines
[ 0.000000] console 'earlycon0' already registered [ 0.000000] Modules linked in: [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted3.17.0-rc2-next-20140827 #18
Quoted 1 line
[ 0.000000] [<c0015fec>] (unwind_backtrace) from [<c0011aac>](
show_stack+0x10/0x14)Quoted 1 line
[ 0.000000] [<c0011aac>] (show_stack) from [<c062b700>](
dump_stack+0x98/0xd8)Quoted 1 line
[ 0.000000] [<c062b700>] (dump_stack) from [<c0025ba0>](
warn_slowpath_common+0x70/0x8c)Quoted 1 line
[ 0.000000] [<c0025ba0>] (warn_slowpath_common) from [<c0025bec>](
warn_slowpath_fmt+0x30/0x40)Quoted 1 line
[ 0.000000] [<c0025bec>] (warn_slowpath_fmt) from [<c00639b8>](
register_console+0x60/0x37c)Quoted 1 line
[ 0.000000] [<c00639b8>] (register_console) from [<c0883870>](
setup_early_printk+0x20/0x28)Quoted 1 line
[ 0.000000] [<c0883870>] (setup_early_printk) from [<c087f43c>](
do_early_param+0x6c/0xd0)Quoted 1 line
[ 0.000000] [<c087f43c>] (do_early_param) from [<c003cba0>](
parse_args+0x238/0x3d0)Quoted 1 line
[ 0.000000] [<c003cba0>] (parse_args) from [<c087f814>](
parse_early_options+0x38/0x40)Quoted 1 line
[ 0.000000] [<c087f814>] (parse_early_options) from [<c087f84c>](
parse_early_param+0x30/0x40)Quoted 1 line
[ 0.000000] [<c087f84c>] (parse_early_param) from [<c088206c>](
setup_arch+0x4b4/0x974)Quoted 1 line
[ 0.000000] [<c088206c>] (setup_arch) from [<c087f8f8>](
start_kernel+0x98/0x3a8)Quoted 1 line
[ 0.000000] [<c087f8f8>] (start_kernel) from [<80008074>](
0x80008074)Quoted 6 lines
[ 0.000000] ---[ end trace cb88537fdc8fa200 ]--- [ 0.000000] cma: Reserved 128 MiB at a7800000 [ 0.000000] Memory policy: Data cache writealloc [ 0.000000] On node 0 totalpages: 524032 [ 0.000000] free_area_init_node: node 0, pgdat c091cc00,
node_mem_map
e67b7000Quoted 7 lines
[ 0.000000] Normal zone: 1520 pages used for memmap [ 0.000000] Normal zone: 0 pages reserved [ 0.000000] Normal zone: 194560 pages, LIFO batch:31 [ 0.000000] HighMem zone: 2574 pages used for memmap [ 0.000000] HighMem zone: 329472 pages, LIFO batch:31 [ 0.000000] PERCPU: Embedded 8 pages/cpu @e6767000 s8832 r8192d15744
u32768
Quoted 3 lines
[ 0.000000] pcpu-alloc: s8832 r8192 d15744 u32768 alloc=8*4096 [ 0.000000] pcpu-alloc: [0] 0 [0] 1 [0] 2 [0] 3 [ 0.000000] Built 1 zonelists in Zone order, mobility grouping on.Total pages: 522512
Quoted 1 line
[ 0.000000] Kernel command line: console=ttyS0,115200n8
ignore_loglevelrootwait ro earlyprintk ip=:::::eth0:dhcp root=/dev/nfs nfsroot=192.168.69.100:/srv/nfs/tegra124 drm.debug=0xf cma=128MQuoted 5 lines
Reverting the patch eliminates the warning. earlyprintk does work fine for me without this patch.
Thierry
This warning message is caused by specifying 'earlyprintk' in your command line args. Same problem may happen if you specify 'earlycon'
in your command line args and enableCONFIG_SERIAL_EARLYCONwith the current code without this patch. I think it's appropriate result letting a developer know that both ways of using earlyprintk are enabled.
With current code, although a developer enablesCONFIG_EARLY_PRINTKand has "console=" arg in command line args, he/she should specify the 'earlyprintk' in command line args also to seeearly_printk()outputs. With this patch, simply enablingCONFIG_EARLY_PRINTKand having 'console='
line make you be able to theearly_printk().Quoted 7 lines
Nonetheless I want to retract this patch. It's good for ARM, but not good
for other architectures such as x86. And, becauseCONFIG_EARLY_PRINTKis depending onDEBUG_LLin ARM, making a relation with "console=" is absurd.
(seestrcmp(param, "console")== 0 &&strcmp(p->str, "earlyprintk")== 0)Quoted 7 lines
Even on ARM, this patch feels like the wrong thing. After all, I can build a
DEBUG_LLenabled multi-platform kernel, and boot it on a bunch of different SoCs. However, earlyprintk will only work on one (or zero) of those SoCs, and hence shouldn't automatically enable itself; specifically requesting activation using the earlyprintk kernel command-line parameter is the correct approach.
Quoted 2 lines
So you are saying, because
DEBUG_LLdidn't work on several SoCs, using the earlyprintk in command line args is the correct approach?
No, I'm saying: Kconfig options DEBUG_LL/CONFIG_EARLY_PRINTK add code into the kernel. The earlyprintk command-line option activates the early printk feature at run-time.
Quoted 2 lines
You are misunderstanding how it works. On ARM with enabling multi-platform kernel, you should choose a specific low-level debug port for
DEBUG_LL.
Actually, I am well aware of how the feature works and use it daily.
Quoted 4 lines
For example, if you have OMAP ZOOM3, you should select
CONFIG_DEBUG_ZOOM_UARTfrom menu.
If you chose a right port for your SoCs and if it didn't work properly, that means its port code should be fixed. (Please report it.)
Everything works fine for me, at least on Tegra, for both Tegra-specific and IIRC also for multi-platform kernels (although I don't use those often).
Quoted 1 line
All the code for low-level debugging is located at
arch/arm/include/debug.
I know.