Skip to contentSkip to conversation

fix python3-distribute and gdb-cross-canadian

PATCH In review Robert Yang 2 participants 6 messages Aug 15, 2014

lore
Share & tools
lore
#0 lore raw

cover fix python3-distribute and gdb-cross-canadian

The following changes since commit 4321c553d5ae816e566234e981a0815bba046d39:

SIGGEN_EXCLUDERECIPES_ABISAFE: add initscripts (2014-08-11 17:44:09 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/python3-gdb
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/python3-gdb

Robert Yang (2):
python3-distribute: fix interpreter
gdb-cross-canadian: add nativesdk-ncurses-libncurses to RDEPENDS

 meta/recipes-devtools/gdb/gdb-cross-canadian.inc   |    4 +++-
 .../python/python3-distribute_0.6.32.bb            |    2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/2 python3-distribute: fix interpreter

It should use "/usr/bin/env python3" rather than python, otherwise it would cause python2 to be installed when we install python3-distribute.

---
 .../python/python3-distribute_0.6.32.bb            |    2 ++
 1 file changed, 2 insertions(+)
meta/recipes-devtools/python/python3-distribute_0.6.32.bb +2 -0
index 573096c..0ef3a87 100644
@@ -37,6 +37,8 @@ do_install_append() {
     rm ${D}${PYTHON_SITEPACKAGES_DIR}/setuptools.pth
     mv ${D}${bindir}/easy_install ${D}${bindir}/easy3_install
     echo "./${SRCNAME}-${PV}-py${PYTHON_BASEVERSION}.egg" > ${D}${PYTHON_SITEPACKAGES_DIR}/setuptools.pth
+    sed -i -e '1s|^#!.*python|#!/usr/bin/env python3|' \
+        ${D}${PYTHON_SITEPACKAGES_DIR}/distribute-${PV}-py${PYTHON_BASEVERSION}.egg/setuptools/tests/test_resources.py
 }
 
 RDEPENDS_${PN} = "\
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 2/2 gdb-cross-canadian: add nativesdk-ncurses-libncurses to RDEPENDS

In reply to Robert Yang

We had nativesdk-ncurses in the DEPENDS, also need add nativesdk-ncurses-libncurses to the RDEPENDS, otherwise libncurses.so.5 is not in the rdepends chain.

---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +3 -1
index e594bb1..2be427a 100644
@@ -7,7 +7,9 @@ BPN = "gdb"
 
 DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext nativesdk-readline nativesdk-python"
 RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang nativesdk-python-re \
-                   nativesdk-python-codecs nativesdk-python-netclient"
+                   nativesdk-python-codecs nativesdk-python-netclient \
+                   nativesdk-ncurses-libncurses \
+                  "
 
 GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 
Signature · 1 line
1.7.9.5
#3 lore raw

Re: [PATCH 2/2] gdb-cross-canadian: add nativesdk-ncurses-libncurses to RDEPENDS

Quoted 3 lines · Robert Yang

We had nativesdk-ncurses in the DEPENDS, also need add nativesdk-ncurses-libncurses to the RDEPENDS, otherwise libncurses.so.5 is not in the rdepends chain.

This doesn't make sense. Can you please give more information about the problem you're solving here please?

If its a dynamically linked lib, the dependency should be detected automatically.

Cheers,

Richard

Quoted 23 lines
---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +3 -1
index e594bb1..2be427a 100644
@@ -7,7 +7,9 @@ BPN = "gdb"
 
 DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext nativesdk-readline nativesdk-python"
 RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang nativesdk-python-re \
-                   nativesdk-python-codecs nativesdk-python-netclient"
+                   nativesdk-python-codecs nativesdk-python-netclient \
+                   nativesdk-ncurses-libncurses \
+                  "
 
 GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 
Signature · 1 line
1.7.9.5
#4 lore raw

Re: [PATCH 2/2] gdb-cross-canadian: add nativesdk-ncurses-libncurses to RDEPENDS

Quoted 7 lines · Richard Purdie
Quoted 3 lines · Robert Yang

We had nativesdk-ncurses in the DEPENDS, also need add nativesdk-ncurses-libncurses to the RDEPENDS, otherwise libncurses.so.5 is not in the rdepends chain.

This doesn't make sense. Can you please give more information about the problem you're solving here please?

Sorry, I should put more info in the commit message. Yes, it doesn't make sense to package_rpm, but makes sense to package_ipk (verified) and package_deb (not yet verified).

My host is X86_64 (doesn't matter)

# Make sure it is a clean build

$ bitbake meta-toolchain -ccleansstate
$ bitbake meta-toolchain
$ find tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/ | grep poky-linux-gdb
tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/opt/poky/1.6+snapshot/sysroots/x86_64-pokysdk-linux/usr/bin/x86_64-poky-linux/x86_64-poky-linux-gdb
#### Note gdb-cross has been installed
$ find tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/ | grep ncurses
### No output, libncurses.so isn't installed.

And if we use PACKAGE_CLASSES = "package_rpm", we can see that libncurses.so is installed.

This is because:

$ rpm -qpR tmp/deploy/rpm/x86_64_nativesdk/gdb-cross-canadian-x86-64-7.7.1-r0.x86_64_nativesdk.rpm | grep ncurses
libncurses.so.5()(64bit)
### There is a file depends (libncurses.so.5)
$ dpkg-deb -I tmp/deploy/ipk/x86_64-nativesdk/gdb-cross-canadian-x86-64_7.7.1-r0_x86_64-nativesdk.ipk | grep ncurses
### No output, ipk knows nothing about the file depends (libncurses.so.5),
### so that it would not be  installed.

I updated the commit message in the repo, please feel free to let me know if you have any questions.

git://git.openembedded.org/openembedded-core-contrib rbt/python3-gdb

We had nativesdk-ncurses in the DEPENDS, also need add nativesdk-ncurses-libncurses to the RDEPENDS, otherwise libncurses will not be installed when PACKAGE_CLASSES = "package_ipk" or deb.

Fixed:
- Set these in local.conf:
MACHINE = "qemux86-64"
PACKAGE_CLASSES = "package_ipk"

$ bitbake meta-toolchain
$ find tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/ | grep ncurses
  ## No output, ncurses isn't installed, but it should.

// Robert

Quoted 35 lines

If its a dynamically linked lib, the dependency should be detected automatically.

Cheers,

Richard

Quoted 23 lines
---
  meta/recipes-devtools/gdb/gdb-cross-canadian.inc |    4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +3 -2
index e594bb1..2be427a 100644
@@ -7,7 +7,9 @@ BPN = "gdb"
 
  DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext nativesdk-readline nativesdk-python"
  RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang nativesdk-python-re \
-                   nativesdk-python-codecs nativesdk-python-netclient"
+                   nativesdk-python-codecs nativesdk-python-netclient \
+                   nativesdk-ncurses-libncurses \
+                  "
 
  GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 
--

1.7.9.5

#5 lore raw

Re: [PATCH 2/2] gdb-cross-canadian: add nativesdk-ncurses-libncurses to RDEPENDS

Quoted 8 lines · Robert Yang
Quoted 5 lines · Richard Purdie
Quoted 3 lines · Robert Yang

We had nativesdk-ncurses in the DEPENDS, also need add nativesdk-ncurses-libncurses to the RDEPENDS, otherwise libncurses.so.5 is not in the rdepends chain.

Quoted 8 lines
Quoted 2 lines

This doesn't make sense. Can you please give more information about the problem you're solving here please?

Sorry, I should put more info in the commit message. Yes, it doesn't make sense to package_rpm, but makes sense to package_ipk (verified) and package_deb (not yet verified).

My host is X86_64 (doesn't matter)

(Sorry, I used a ctrl-X cut these mesasge, here is the set in local.conf to reproduce the problem):

- Set these in local.conf:
MACHINE = "qemux86-64"
PACKAGE_CLASSES = "package_ipk"

// Robert

Quoted 90 lines

# Make sure it is a clean build

$ bitbake meta-toolchain -ccleansstate
$ bitbake meta-toolchain
$ find tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/ | grep
poky-linux-gdb
tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/opt/poky/1.6+snapshot/sysroots/x86_64-pokysdk-linux/usr/bin/x86_64-poky-linux/x86_64-poky-linux-gdb

#### Note gdb-cross has been installed

$ find tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/ | grep ncurses
### No output, libncurses.so isn't installed.

And if we use PACKAGE_CLASSES = "package_rpm", we can see that libncurses.so is installed.

This is because:

$ rpm -qpR
tmp/deploy/rpm/x86_64_nativesdk/gdb-cross-canadian-x86-64-7.7.1-r0.x86_64_nativesdk.rpm
| grep ncurses
libncurses.so.5()(64bit)
### There is a file depends (libncurses.so.5)
$ dpkg-deb -I
tmp/deploy/ipk/x86_64-nativesdk/gdb-cross-canadian-x86-64_7.7.1-r0_x86_64-nativesdk.ipk
| grep ncurses
### No output, ipk knows nothing about the file depends (libncurses.so.5),
### so that it would not be  installed.

I updated the commit message in the repo, please feel free to let me know if you have any questions.

git://git.openembedded.org/openembedded-core-contrib rbt/python3-gdb

We had nativesdk-ncurses in the DEPENDS, also need add nativesdk-ncurses-libncurses to the RDEPENDS, otherwise libncurses will not be installed when PACKAGE_CLASSES = "package_ipk" or deb.

Fixed:
- Set these in local.conf:
MACHINE = "qemux86-64"
PACKAGE_CLASSES = "package_ipk"

$ bitbake meta-toolchain
$ find tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/ | grep ncurses
   ## No output, ncurses isn't installed, but it should.

// Robert

Quoted 38 lines

If its a dynamically linked lib, the dependency should be detected automatically.

Cheers,

Richard

Quoted 26 lines
---
  meta/recipes-devtools/gdb/gdb-cross-canadian.inc |    4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-cross-canadian.inc +0 -0
index e594bb1..2be427a 100644
@@ -7,7 +7,9 @@ BPN = "gdb"
 
  DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext

nativesdk-readline nativesdk-python"
RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang
nativesdk-python-re \

meta/recipes-devtools/gdb/gdb-cross-canadian.inc +3 -2
-                   nativesdk-python-codecs nativesdk-python-netclient"
+                   nativesdk-python-codecs nativesdk-python-netclient \
+                   nativesdk-ncurses-libncurses \
+                  "
 
  GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 
--

1.7.9.5