Skip to contentSkip to conversation

cpufreq: exynos: free memory immediately on unknown SoC

PATCH In review Arjun Sreedharan 2 participants 2 messages Aug 17, 2014 – Aug 18, 2014

Subsystems (2)
Arm Samsung Exynos CPU frequency scaling framework
lore
Share & tools
lore

Arjun Sreedharan

author
#0 lore raw

PATCH 1/1 cpufreq: exynos: free memory immediately on unknown SoC

Signed-off-by Arjun Sreedharan <[email protected]>
---
 drivers/cpufreq/exynos-cpufreq.c | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/exynos-cpufreq.c +1 -0
index 1e0ec57..e47d165 100644
@@ -178,6 +178,7 @@ static int exynos_cpufreq_probe(struct platform_device *pdev)
 		ret = exynos5250_cpufreq_init(exynos_info);
 	} else {
 		pr_err("%s: Unknown SoC type\n", __func__);
+		kfree(exynos_info);
 		return -ENODEV;
 	}
Signature · 1 line
1.7.11.7
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Arjun Sreedharan
Signed-off-by Arjun Sreedharan <[email protected]>
---
 drivers/cpufreq/exynos-cpufreq.c | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/exynos-cpufreq.c +0 -0
index 1e0ec57..e47d165 100644

drivers/cpufreq/exynos-cpufreq.c static int exynos_cpufreq_probe(struct platform_device *pdev) · line 183

Quoted 6 lines
drivers/cpufreq/exynos-cpufreq.c +1 -0
@@ -178,6 +178,7 @@ static int exynos_cpufreq_probe(struct platform_device *pdev)
                ret = exynos5250_cpufreq_init(exynos_info);
        } else {
                pr_err("%s: Unknown SoC type\n", __func__);
+               kfree(exynos_info);
                return -ENODEV;
        }

Apart from the fact that we could have added some logs and improved $subject a bit,
it looks fine.

Acked-by Viresh Kumar <[email protected]>