Skip to contentSkip to conversation

ASoC: Use dev_set_name() instead of init_name

PATCH Applied Lars-Peter Clausen 2 participants 2 messages Aug 17, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Use dev_set_name() instead of init_name

init_name is basically a hack and should only be used for statically allocated device structs. For dynamically allocated devices dev_set_name() should be used.

---
 sound/soc/soc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/soc-core.c +1 -1
index d4bfd4a..889f4e3 100644
@@ -1325,7 +1325,7 @@ static int soc_post_component_init(struct snd_soc_pcm_runtime *rtd,
 	device_initialize(rtd->dev);
 	rtd->dev->parent = rtd->card->dev;
 	rtd->dev->release = rtd_release;
-	rtd->dev->init_name = name;
+	dev_set_name(rtd->dev, "%s", name);
 	dev_set_drvdata(rtd->dev, rtd);
 	mutex_init(&rtd->pcm_mutex);
 	INIT_LIST_HEAD(&rtd->dpcm[SNDRV_PCM_STREAM_PLAYBACK].be_clients);
Signature · 1 line
1.8.0
maintainer Applied
#1 lore raw
Quoted 2 lines · Lars-Peter Clausen

init_name is basically a hack and should only be used for statically allocated device structs. For dynamically allocated devices dev_set_name() should be used.

Applied, thanks.