Skip to contentSkip to conversation

librsvg: disable Bsymbolic if it is not supported on some hosts

PATCH Superseded Chong Lu 2 participants 3 messages Aug 18, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Chong Lu

author
#0 lore raw

cover librsvg: disable Bsymbolic if it is not supported on some hosts

The following changes since commit 59b0f7f01bbac6f1c10ee00382c5136d1f327960:

chrpath: Drop warning from darwn builds (2014-08-17 10:01:36 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib chonglu/librsvg
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/librsvg

Chong Lu (1):
librsvg: disable Bsymbolic if it is not supported on some hosts

 meta/recipes-gnome/librsvg/librsvg_2.40.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/1 librsvg: disable Bsymbolic if it is not supported on some hosts

When trying to build on my Centos 5.5 machine, got below error:

| checking for gdk-pixbuf-query-loaders... /home/build/clu1/build/qemux86_standard_glibc-std/bitbake_build/tmp/sysroots/x86_64-linux/usr/bin/gdk-pixbuf-query-loaders
| checking if gcc  supports "-Wl,-Bsymbolic-functions" flag...
| configure: error: -Bsymbolic requested but not supported by ld. Use --disable-Bsymbolic to disable
| Configure failed. The contents of all config.log files follows to aid debugging
| ERROR: oe_runconf failed

Set --enable-Bsymbolic=auto to disable it when it is not suppported.

---
 meta/recipes-gnome/librsvg/librsvg_2.40.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-gnome/librsvg/librsvg_2.40.2.bb +1 -1
index 34d8ca1..d288d4b 100644
@@ -20,7 +20,7 @@ SRC_URI += "file://gtk-option.patch \
 SRC_URI[archive.md5sum] = "acdecdb9f08f3bf662a68bf7dafb8b82"
 SRC_URI[archive.sha256sum] = "48049b643294636df7de1a4b997414d699666f5dc44776945c218a257d2a291c"
 
-EXTRA_OECONF = "--disable-introspection --disable-vala"
+EXTRA_OECONF = "--disable-introspection --disable-vala --enable-Bsymbolic=auto"
 
 PACKAGECONFIG ??= "gdkpixbuf"
 # The gdk-pixbuf loader
Signature · 1 line
1.9.1
#2 lore raw
Quoted 19 lines · Chong Lu

When trying to build on my Centos 5.5 machine, got below error:

| checking for gdk-pixbuf-query-loaders... /home/build/clu1/build/qemux86_standard_glibc-std/bitbake_build/tmp/sysroots/x86_64-linux/usr/bin/gdk-pixbuf-query-loaders
| checking if gcc  supports "-Wl,-Bsymbolic-functions" flag...
| configure: error: -Bsymbolic requested but not supported by ld. Use --disable-Bsymbolic to disable
| Configure failed. The contents of all config.log files follows to aid debugging
| ERROR: oe_runconf failed

Set --enable-Bsymbolic=auto to disable it when it is not suppported.

---
 meta/recipes-gnome/librsvg/librsvg_2.40.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-gnome/librsvg/librsvg_2.40.2.bb +0 -0
index 34d8ca1..d288d4b 100644

meta/recipes-gnome/librsvg/librsvg_2.40.2.bb SRC_URI += "file://gtk-option.patch \ · line 23

Quoted 5 lines
meta/recipes-gnome/librsvg/librsvg_2.40.2.bb +1 -1
@@ -20,7 +20,7 @@ SRC_URI += "file://gtk-option.patch \
 SRC_URI[archive.md5sum] = "acdecdb9f08f3bf662a68bf7dafb8b82"
 SRC_URI[archive.sha256sum] = "48049b643294636df7de1a4b997414d699666f5dc44776945c218a257d2a291c"
 
-EXTRA_OECONF = "--disable-introspection --disable-vala"
+EXTRA_OECONF = "--disable-introspection --disable-vala --enable-Bsymbolic=auto"

Please can you add a comment in to the recipe alongside this explaining why we need to do this. In 12 months time, nobody will be able to remember why we're passing in this option without looking at the history.

Also, we only need this in the -native case, correct?

Cheers,

Richard

Quoted 5 lines
meta/recipes-gnome/librsvg/librsvg_2.40.2.bb +0 -0
 PACKAGECONFIG ??= "gdkpixbuf"
 # The gdk-pixbuf loader
Signature · 1 line
1.9.1