Skip to contentSkip to conversation

staging: android: fix style issue

PATCH In review Purnendu Kapadia 2 participants 2 messages Aug 20, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: android: fix style issue

checkpatch fix. add a line before the switch statement

---
 drivers/staging/android/sync.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/android/sync.c +1 -0
index e7b2e02..0d37495 100644
@@ -705,6 +705,7 @@ static long sync_fence_ioctl(struct file *file, unsigned int cmd,
 			     unsigned long arg)
 {
 	struct sync_fence *fence = file->private_data;
+
 	switch (cmd) {
 	case SYNC_IOC_WAIT:
 		return sync_fence_ioctl_wait(fence, arg);
Signature · 1 line
1.9.1
#1 lore raw
Quoted 1 line · Purnendu Kapadia

checkpatch fix. add a line before the switch statement

Hello Purnendu.

This is a suboptimal patch description.

There is no generic style asking for a blank line
before a switch statement.

You are actually adding a blank line separating
declarations and code.

Specifying the change as a "checkpatch fix" is
also unnecessary.

A patch subject of

"[PATCH] staging: android: Add blank line after declaration"

with no patch description at all is probably good
enough.

drivers/staging/androchd/sync.c

Quoted 1 line
drivers/staging/androchd/sync.c renamed from drivers/staging/android/sync.c +0 -0

[]

Quoted 8 lines
drivers/staging/androchd/sync.c renamed from drivers/staging/android/sync.c +1 -0
@@ -705,6 +705,7 @@ static long sync_fence_ioctl(struct file *file, unsigned int cmd,
 			     unsigned long arg)
 {
 	struct sync_fence *fence = file->private_data;
+
 	switch (cmd) {
 	case SYNC_IOC_WAIT:
 		return sync_fence_ioctl_wait(fence, arg);