Skip to contentSkip to conversation

command: Trigger updateCache to shut down any active parser threads

PATCH New Richard Purdie 1 participant 1 message Aug 21, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 command: Trigger updateCache to shut down any active parser threads

If we trigger a shutdown whilst parsing for whatever reason, in some cases we were not closing down the parser threads. This change ensures we do so. The function names are not entirely intuitive but the behaviour is more correct (and commented). The previous bug with the stdout failure would trigger this one, if there was a cold cache and parsing was required (but not otherwise).

bitbake/lib/bb/command.py +3 -0
index d797fcf..0cfed0a 100644
@@ -87,6 +87,9 @@ class Command:
     def runAsyncCommand(self):
         try:
             if self.cooker.state in (bb.cooker.state.error, bb.cooker.state.shutdown, bb.cooker.state.forceshutdown):
+                # updateCache will trigger a shutdown of the parser
+                # and then raise BBHandledException triggering an exit
+                self.cooker.updateCache()
                 return False
             if self.currentAsyncCommand is not None:
                 (command, options) = self.currentAsyncCommand