doc: memory-barriers.txt: Correct example for reorderings
Subsystems (2)
PATCH 1/1 doc: memory-barriers.txt: Correct example for reorderings
Correct the example of memory orderings in memory-barriers.txt
Commit 615cc2c9cf95 "Documentation/memory-barriers.txt: fix important typo re memory barriers" changed the assignment to x and y. Change the rest of the example to match this change.
--- Documentation/memory-barriers.txt | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
Documentation/memory-barriers.txt +11 -11
@@ -121,22 +121,22 @@ For example, consider the following sequence of events: The set of accesses as seen by the memory system in the middle can be arranged in 24 different combinations: - STORE A=3, STORE B=4, x=LOAD A->3, y=LOAD B->4 - STORE A=3, STORE B=4, y=LOAD B->4, x=LOAD A->3 - STORE A=3, x=LOAD A->3, STORE B=4, y=LOAD B->4 - STORE A=3, x=LOAD A->3, y=LOAD B->2, STORE B=4 - STORE A=3, y=LOAD B->2, STORE B=4, x=LOAD A->3 - STORE A=3, y=LOAD B->2, x=LOAD A->3, STORE B=4 - STORE B=4, STORE A=3, x=LOAD A->3, y=LOAD B->4 + STORE A=3, STORE B=4, x=LOAD B->4, y=LOAD A->3 + STORE A=3, STORE B=4, y=LOAD A->3, x=LOAD B->4 + STORE B=4, x=LOAD B->4, STORE A=3, y=LOAD A->3 + STORE A=3, x=LOAD B->2, y=LOAD A->3, STORE B=4 + STORE B=4, y=LOAD A->1, STORE A=3, x=LOAD B->4 + STORE B=4, y=LOAD A->1, x=LOAD B->4, STORE A=3 + STORE B=4, STORE A=3, x=LOAD B->4, y=LOAD A->3 STORE B=4, ... ... and can thus result in four different combinations of values: - x == 1, y == 2 - x == 1, y == 4 - x == 3, y == 2 - x == 3, y == 4 + x == 2, y == 1 + x == 2, y == 3 + x == 4, y == 1 + x == 4, y == 3 Furthermore, the stores committed by a CPU to the memory system may not be
Signature · 1 line
1.9.1
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 6 lines · Paul E. McKenney
I am really confused by the ordering of the new lines, as I would have expected the "x"s to be replaced with "y"s and vice versa. But the ordering of the various combinations does not matter, and each line looks OK.
Since x = A was replaced by x = B and y = B was replaced by y = A, I just converted all x = load A to x = load B. Similarly for y. I think we can do either this or as you suggested replacing x's with y's.
Signature · 1 line
Pranith
Quoted 11 lines · Pranith Kumar
Quoted 5 lines · Paul E. McKenney
I am really confused by the ordering of the new lines, as I would have expected the "x"s to be replaced with "y"s and vice versa. But the ordering of the various combinations does not matter, and each line looks OK.
Since x = A was replaced by x = B and y = B was replaced by y = A, I just converted all x = load A to x = load B. Similarly for y. I think we can do either this or as you suggested replacing x's with y's.
Fair enough. The other thing that confused me was the "STORE B=4," showing up early in your replacement.
Thanx, Paul
Quoted 9 lines · Paul E. McKenney
Quoted 8 lines · Pranith Kumar
Quoted 5 lines · Paul E. McKenney
I am really confused by the ordering of the new lines, as I would have expected the "x"s to be replaced with "y"s and vice versa. But the ordering of the various combinations does not matter, and each line looks OK.
Quoted 7 lines
Quoted 3 lines
Since x = A was replaced by x = B and y = B was replaced by y = A, I just converted all x = load A to x = load B. Similarly for y. I think we can do either this or as you suggested replacing x's with y's.
Fair enough. The other thing that confused me was the "STORE B=4," showing up early in your replacement.
So I converted
STORE A=3, x=LOAD A->3
to
STORE B=4, x=LOAD B->4
since the later load into x wanted an updated value of B and not the default. That is the reason you see STORE B = 4 in place of STORE A = 3
Signature · 1 line
Pranith
Quoted 22 lines · Pranith Kumar
Quoted 9 lines · Paul E. McKenney
Quoted 8 lines · Pranith Kumar
Quoted 5 lines · Paul E. McKenney
I am really confused by the ordering of the new lines, as I would have expected the "x"s to be replaced with "y"s and vice versa. But the ordering of the various combinations does not matter, and each line looks OK.
Quoted 6 lines
Quoted 3 lines
Since x = A was replaced by x = B and y = B was replaced by y = A, I just converted all x = load A to x = load B. Similarly for y. I think we can do either this or as you suggested replacing x's with y's.
Fair enough. The other thing that confused me was the "STORE B=4," showing up early in your replacement.
So I converted
STORE A=3, x=LOAD A->3
Quoted 7 lines
to
STORE B=4, x=LOAD B->4
since the later load into x wanted an updated value of B and not the default. That is the reason you see STORE B = 4 in place of STORE A = 3
Fair enough.
However, the list is supposed to be part of the full set of 24 possible outcomes. Many readers would therefore expect the permutations to be ordered in some way, so that the first column would have six of one thing, six of the next thing, and so on, according to some pattern.
Could you please adjust in this way? Again, the point is to be the first few items in a full set of permutations, not to illustrate selected orderings/outcomes.
Thanx, Paul
Quoted 4 lines · Paul E. McKenney
Could you please adjust in this way? Again, the point is to be the first few items in a full set of permutations, not to illustrate selected orderings/outcomes.
OK, if that is the case then replacing x with y is much easier. I will send an updated patch. Thanks!
Signature · 1 line
Pranith