Skip to contentSkip to conversation

ASoC: cs35l32: Remove unneeded regulator_bulk_free call in cs35l32_i2c_remove

PATCH Applied Axel Lin 3 participants 4 messages Aug 28, 2014

Subsystems (3)
Sound ASoC Cirrus Logic audio codecs
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 ASoC: cs35l32: Remove unneeded regulator_bulk_free call in cs35l32_i2c_remove

The regulator_bulk_free() call is not required because current code is using devm_regulator_bulk_get().

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/codecs/cs35l32.c | 2 --
 1 file changed, 2 deletions(-)
sound/soc/codecs/cs35l32.c +0 -2
index 380c212..718569f 100644
@@ -548,8 +548,6 @@ static int cs35l32_i2c_remove(struct i2c_client *i2c_client)
 	if (cs35l32->reset_gpio)
 		gpiod_set_value_cansleep(cs35l32->reset_gpio, 0);
 
-	regulator_bulk_free(ARRAY_SIZE(cs35l32->supplies), cs35l32->supplies);
-
 	return 0;
 }
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 ASoC: cs42l56: Remove unneeded regulator_bulk_free call in cs42l56_remove

The regulator_bulk_free() call is not required because current code is using devm_regulator_bulk_get().

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/codecs/cs42l56.c | 3 ---
 1 file changed, 3 deletions(-)
sound/soc/codecs/cs42l56.c +0 -3
index c766a5a..5a2d732 100644
@@ -1175,11 +1175,8 @@ static int cs42l56_probe(struct snd_soc_codec *codec)
 
 static int cs42l56_remove(struct snd_soc_codec *codec)
 {
-	struct cs42l56_private *cs42l56 = snd_soc_codec_get_drvdata(codec);
-
 	cs42l56_free_beep(codec);
 	cs42l56_set_bias_level(codec, SND_SOC_BIAS_OFF);
-	regulator_bulk_free(ARRAY_SIZE(cs42l56->supplies), cs42l56->supplies);
 
 	return 0;
 }
Signature · 1 line
1.9.1
Acked-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] ASoC: cs42l56: Remove unneeded regulator_bulk_free call in cs42l56_remove

Quoted 14 lines · Axel Lin

The regulator_bulk_free() call is not required because current code is using devm_regulator_bulk_get().

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/codecs/cs42l56.c | 3 ---
 1 file changed, 3 deletions(-)
sound/soc/codecs/cs42l56.c +0 -0
index c766a5a..5a2d732 100644
@@ -1175,11 +1175,8 @@ static int cs42l56_probe(struct snd_soc_codec *codec)

sound/soc/codecs/cs42l56.c static int cs42l56_probe(struct snd_soc_codec *codec) · line 1182

Quoted 10 lines
sound/soc/codecs/cs42l56.c +0 -3
 static int cs42l56_remove(struct snd_soc_codec *codec)
 {
-	struct cs42l56_private *cs42l56 = snd_soc_codec_get_drvdata(codec);
-
 	cs42l56_free_beep(codec);
 	cs42l56_set_bias_level(codec, SND_SOC_BIAS_OFF);
-	regulator_bulk_free(ARRAY_SIZE(cs42l56->supplies), cs42l56->supplies);
 
 	return 0;
 }

Thanks Axel,

For the series..

Acked-by Brian Austin <[email protected]>
maintainer Applied
#3 lore raw
In reply to Axel Lin
Quoted 2 lines · Axel Lin

The regulator_bulk_free() call is not required because current code is using devm_regulator_bulk_get().

Applied both, thanks.