Skip to contentSkip to conversation

usb: gadget: USB_RENESAS_USBHS_UDC should depend on HAS_DMA

PATCH In review Geert Uytterhoeven 2 participants 2 messages Aug 29, 2014 – Sep 3, 2014 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: gadget: USB_RENESAS_USBHS_UDC should depend on HAS_DMA

If NO_DMA=y:

drivers/built-in.o: In function `usbhsg_dma_map_ctrl':
mod_gadget.c:(.text+0x53b226): undefined reference to usb_gadget_map_request' mod_gadget.c:(.text+0x53b242): undefined reference to usb_gadget_unmap_request'

---
 drivers/usb/gadget/udc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/udc/Kconfig +1 -1
index 5151f947a4f5..00171d436cf8 100644
@@ -163,7 +163,7 @@ config USB_R8A66597
 
 config USB_RENESAS_USBHS_UDC
 	tristate 'Renesas USBHS controller'
-	depends on USB_RENESAS_USBHS
+	depends on USB_RENESAS_USBHS && HAS_DMA
 	help
 	   Renesas USBHS is a discrete USB host and peripheral controller chip
 	   that supports both full and high speed USB 2.0 data transfers.
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw

Hi Geert,

Quoted 17 lines · Geert Uytterhoeven

If NO_DMA=y:

drivers/built-in.o: In function `usbhsg_dma_map_ctrl':
mod_gadget.c:(.text+0x53b226): undefined reference to usb_gadget_map_request' mod_gadget.c:(.text+0x53b242): undefined reference to usb_gadget_unmap_request'

---
 drivers/usb/gadget/udc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/udc/Kconfig +0 -0
index 5151f947a4f5..00171d436cf8 100644

drivers/usb/gadget/udc/Kconfig config USB_R8A66597 · line 169

Quoted 8 lines
drivers/usb/gadget/udc/Kconfig +1 -1
@@ -163,7 +163,7 @@ config USB_R8A66597
 
 config USB_RENESAS_USBHS_UDC
 	tristate 'Renesas USBHS controller'
-	depends on USB_RENESAS_USBHS
+	depends on USB_RENESAS_USBHS && HAS_DMA
 	help
 	   Renesas USBHS is a discrete USB host and peripheral controller chip
 	   that supports both full and high speed USB 2.0 data transfers.

Best regards,
Yoshihiro Shimoda