gpio: make driver mcp23s08 to support both device tree and platform data
PATCH v3 1/1 gpio: make driver mcp23s08 to support both device tree and platform data
From: Sonic Zhang <[email protected]>
Device tree is not enabled in some archtecture where gpio driver mcp23s08 is still required.
Signed-off-by Sonic Zhang <[email protected]>
Reviewed-by Alexandre Courbot <[email protected]>
v2-changes:
- Parse device tree properties into platform data other than individual variables.
v3-changes:
- Use of_node in gpio_chip device structure, because the struct device * always has an of_node which is NULL when OF is not used.
--- drivers/gpio/Kconfig | 1 - drivers/gpio/gpio-mcp23s08.c | 64 +++++++++++++++++++++++--------------------- include/linux/spi/mcp23s08.h | 18 +++++++++++++ 3 files changed, 52 insertions(+), 31 deletions(-)
drivers/gpio/Kconfig +0 -1
@@ -796,7 +796,6 @@ config GPIO_MAX7301 config GPIO_MCP23S08 tristate "Microchip MCP23xxx I/O expander" - depends on OF_GPIO depends on (SPI_MASTER && !I2C) || I2C help SPI/I2C driver for Microchip MCP23S08/MCP23S17/MCP23008/MCP23017
drivers/gpio/gpio-mcp23s08.c +34 -30
153 lines not on this page · raw message
include/linux/spi/mcp23s08.h +18 -0
@@ -22,4 +22,22 @@ struct mcp23s08_platform_data {* base to base+15 (or base+31 for s17 variant). */ unsigned base; +/* Marks the device as a interrupt controller. +* NOTE: The interrupt functionality is only supported for i2c +* versions of the chips. The spi chips can also do the interrupts, +* but this is not supported by the linux driver yet. +*/ +bool irq_controller; + +/* Sets the mirror flag in the IOCON register. Devices +* with two interrupt outputs (these are the devices ending with 17 and +* those that have 16 IOs) have two IO banks: IO 0-7 form bank 1 and +* IO 8-15 are bank 2. These chips have two different interrupt outputs: +* One for bank 1 and another for bank 2. If irq-mirror is set, both +* interrupts are generated regardless of the bank that an input change +* occurred on. If it is not set, the interrupt are only generated for +* the bank they belong to. +* On devices with only one interrupt output this property is useless. +*/ +bool mirror; };
Signature · 1 line
1.8.2.3
Quoted 7 lines · Sonic Zhang
From: Sonic Zhang <[email protected]>
Device tree is not enabled in some archtecture where gpio driver mcp23s08 is still required.
Signed-off-by Sonic Zhang <[email protected]>Reviewed-by Alexandre Courbot <[email protected]>
OK this v2 version applied.
Yours,
Linus Walleij