drm: i915: reduce memory footprint when debugging
Subsystems (2)
PATCH 1/1 drm: i915: reduce memory footprint when debugging
There is no need to use hex_dump_to_buffer() since we have a kernel helper to dump up to 64 bytes just via printk(). In our case the actual size is 15 bytes.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/gpu/drm/i915/intel_dp.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +1 -5
@@ -3318,15 +3318,11 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp)struct drm_device *dev = dig_port->base.base.dev;struct drm_i915_private *dev_priv = dev->dev_private; -char dpcd_hex_dump[sizeof (intel_dp->dpcd) *3 ]; -if (intel_dp_dpcd_read_wake (&intel_dp->aux,0x000 , intel_dp->dpcd,sizeof (intel_dp->dpcd)) <0 )return false;/* aux transfer failed */ -hex_dump_to_buffer (intel_dp->dpcd,sizeof (intel_dp->dpcd), -32 ,1 , dpcd_hex_dump,sizeof (dpcd_hex_dump), false); -DRM_DEBUG_KMS ("DPCD: %s\n" , dpcd_hex_dump); +DRM_DEBUG_KMS ("DPCD: %*ph\n" ,sizeof (intel_dp->dpcd), intel_dp->dpcd);if (intel_dp->dpcd[DP_DPCD_REV ] ==0 )return false;/* DPCD not present */
Signature · 1 line
2.1.0
Quoted 2 lines · Andy Shevchenko
There is no need to use
hex_dump_to_buffer()since we have a kernel helper to dump up to 64 bytes just viaprintk(). In our case the actual size is 15 bytes.
Reviewed-by Jani Nikula <[email protected]>
Quoted 33 lines
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)drivers/gpu/drm/i915/intel_dp.c +1
-5@@ -3318,15 +3318,11 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp)struct drm_device *dev = dig_port->base.base.dev;struct drm_i915_private *dev_priv = dev->dev_private; -char dpcd_hex_dump[sizeof (intel_dp->dpcd) *3 ]; -if (intel_dp_dpcd_read_wake (&intel_dp->aux,0x000 , intel_dp->dpcd,sizeof (intel_dp->dpcd)) <0 )return false;/* aux transfer failed */ -hex_dump_to_buffer (intel_dp->dpcd,sizeof (intel_dp->dpcd), -32 ,1 , dpcd_hex_dump,sizeof (dpcd_hex_dump), false); -DRM_DEBUG_KMS ("DPCD: %s\n" , dpcd_hex_dump); +DRM_DEBUG_KMS ("DPCD: %*ph\n" ,sizeof (intel_dp->dpcd), intel_dp->dpcd);if (intel_dp->dpcd[DP_DPCD_REV ] ==0 )return false;/* DPCD not present */ Signature · 6 lines
2.1.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center