Skip to contentSkip to conversation

powercap/rapl: change domain detection message

PATCH New Jacob Pan 1 participant 1 message Sep 2, 2014 Power management core

lore
Share & tools
lore

Jacob Pan

author
#0 lore raw

PATCH 1/1 powercap/rapl: change domain detection message

Many CPUs do not support complete set of RAPL domains, as a result this detection failed message is very misleading and can be annoying.

 [    5.082632] intel_rapl: RAPL domain core detection failed
 [    5.088370] intel_rapl: RAPL domain uncore detection failed

So lower the warning message to info and only print out the RAPL domains that are supported.

---
 drivers/powercap/intel_rapl.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/powercap/intel_rapl.c +3 -4
index b1cda6f..d32b7a6 100644
@@ -1166,11 +1166,10 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu)
 
 	for (i = 0; i < RAPL_DOMAIN_MAX; i++) {
 		/* use physical package id to read counters */
-		if (!rapl_check_domain(cpu, i))
+		if (!rapl_check_domain(cpu, i)) {
 			rp->domain_map |= 1 << i;
-		else
-			pr_warn("RAPL domain %s detection failed\n",
-				rapl_domain_names[i]);
+			pr_info("Found RAPL domain %s\n", rapl_domain_names[i]);
+		}
 	}
 	rp->nr_domains = bitmap_weight(&rp->domain_map,	RAPL_DOMAIN_MAX);
 	if (!rp->nr_domains) {
Signature · 1 line
2.0.0.5.gbce14aa