Skip to contentSkip to conversation

sh: Fix build error caused by missing dependencies

PATCH In review Pranith Kumar 2 participants 2 messages Sep 2, 2014 SuperH

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sh: Fix build error caused by missing dependencies

Fix a sh4-randconfig build failure which has the following splat:

arch/sh/mm/cache-sh4.c:99:17: error: 'cached_to_uncached' undeclared (first use in this function) arch/sh/mm/cache-sh4.c:192:2: error: implicit declaration of function 'cpu_context' [-Werror=implicit-function-declaration]

These errors are caused by missing dependencies on UNCACHED_MAPPING and MMU.

---
 arch/sh/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/sh/Kconfig +2 -0
index 244fb4c..619d5eb 100644
@@ -194,6 +194,8 @@ config CPU_SH4
 	select SH_INTC
 	select SYS_SUPPORTS_SH_TMU
 	select SYS_SUPPORTS_HUGETLBFS if MMU
+	select UNCACHED_MAPPING
+	select MMU
 
 config CPU_SH4A
 	bool
Signature · 1 line
2.1.0
#1 lore raw

Hi Pranith,

Quoted 18 lines · Pranith Kumar

Fix a sh4-randconfig build failure which has the following splat:

arch/sh/mm/cache-sh4.c:99:17: error: 'cached_to_uncached' undeclared (first use in this function) arch/sh/mm/cache-sh4.c:192:2: error: implicit declaration of function 'cpu_context' [-Werror=implicit-function-declaration]

These errors are caused by missing dependencies on UNCACHED_MAPPING and MMU.

---
 arch/sh/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/sh/Kconfig +0 -0
index 244fb4c..619d5eb 100644

arch/sh/Kconfig config CPU_SH4 · line 198

Quoted 5 lines
arch/sh/Kconfig +2 -0
@@ -194,6 +194,8 @@ config CPU_SH4
        select SH_INTC
        select SYS_SUPPORTS_SH_TMU
        select SYS_SUPPORTS_HUGETLBFS if MMU
+       select UNCACHED_MAPPING
+       select MMU

Selecting MMU is never the correct solution, as it's a platform feature. Making something depend on MMU is something different, but I doubt SH4 can only work with a MMU, cfr. the "if MMU" in the line above.

Back to the drawing board...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds