vhost-scsi: init backend features earlier
PATCH 1/1 vhost-scsi: init backend features earlier
As vhost core uses backend_features during init, clear it earlier to avoid using uninitialized memory.
This is harmless since vhost scsi ignores the result anyway, but it avoids valgrind errors.
--- hw/scsi/vhost-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/scsi/vhost-scsi.c +1 -1
@@ -238,6 +238,7 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp) s->dev.nvqs =VHOST_SCSI_VQ_NUM_FIXED + vs->conf.num_queues; s->dev.vqs = g_new(struct vhost_virtqueue, s->dev.nvqs); s->dev.vq_index =0 ; + s->dev.backend_features =0 ; ret =vhost_dev_init (&s->dev, (void *)(uintptr_t )vhostfd,VHOST_BACKEND_TYPE_KERNEL , true);
@@ -246,7 +247,6 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp) strerror(-ret));return ; } - s->dev.backend_features =0 ;error_setg (&s->migration_blocker,"vhost-scsi does not support migration" );
Signature · 1 line
MST
Il 03/09/2014 11:02, Michael S. Tsirkin ha scritto:
Quoted 27 lines
As vhost core uses
backend_featuresduring init, clear it earlier to avoid using uninitialized memory.
This is harmless since vhost scsi ignores the result anyway, but it avoids valgrind errors.Cc Jason Wang <[email protected]>Signed-off-by Michael S. Tsirkin <[email protected]>--- hw/scsi/vhost-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/scsi/vhost-scsi.c +1
-0@@ -238,6 +238,7 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp) s->dev.nvqs =VHOST_SCSI_VQ_NUM_FIXED + vs->conf.num_queues; s->dev.vqs = g_new(struct vhost_virtqueue, s->dev.nvqs); s->dev.vq_index =0 ; + s->dev.backend_features =0 ; ret =vhost_dev_init (&s->dev, (void *)(uintptr_t )vhostfd,VHOST_BACKEND_TYPE_KERNEL , true);
hw/scsi/vhost-scsi.c static void vhost_scsi_realize(DeviceState *dev, Error **errp) · line 252
Quoted 7 lines
hw/scsi/vhost-scsi.c +0
-1@@ -246,7 +247,6 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp) strerror(-ret));return ; } - s->dev.backend_features =0 ;error_setg (&s->migration_blocker,"vhost-scsi does not support migration" );
want to keep it in your treee?
Paolo
Quoted 38 lines · Paolo Bonzini
Il 03/09/2014 11:02, Michael S. Tsirkin ha scritto:
Quoted 27 lines
As vhost core uses
backend_featuresduring init, clear it earlier to avoid using uninitialized memory.
This is harmless since vhost scsi ignores the result anyway, but it avoids valgrind errors.Cc Jason Wang <[email protected]>Signed-off-by Michael S. Tsirkin <[email protected]>--- hw/scsi/vhost-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/scsi/vhost-scsi.c +1
-0@@ -238,6 +238,7 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp) s->dev.nvqs =VHOST_SCSI_VQ_NUM_FIXED + vs->conf.num_queues; s->dev.vqs = g_new(struct vhost_virtqueue, s->dev.nvqs); s->dev.vq_index =0 ; + s->dev.backend_features =0 ; ret =vhost_dev_init (&s->dev, (void *)(uintptr_t )vhostfd,VHOST_BACKEND_TYPE_KERNEL , true);hw/scsi/vhost-scsi.c static void vhost_scsi_realize(DeviceState *dev, Error **errp) · line 252
Quoted 7 lines
hw/scsi/vhost-scsi.c +0
-1@@ -246,7 +247,6 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp) strerror(-ret));return ; } - s->dev.backend_features =0 ;error_setg (&s->migration_blocker,"vhost-scsi does not support migration" );Acked-by Paolo Bonzini <[email protected]>
Quoted 3 lines
want to keep it in your treee?
Paolo
Yes please.
Quoted 26 lines · Michael S. Tsirkin
As vhost core uses
backend_featuresduring init, clear it earlier to avoid using uninitialized memory.
This is harmless since vhost scsi ignores the result anyway, but it avoids valgrind errors.Cc Jason Wang <[email protected]>Signed-off-by Michael S. Tsirkin <[email protected]>--- hw/scsi/vhost-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/scsi/vhost-scsi.c +1
-0@@ -238,6 +238,7 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp) s->dev.nvqs =VHOST_SCSI_VQ_NUM_FIXED + vs->conf.num_queues; s->dev.vqs = g_new(struct vhost_virtqueue, s->dev.nvqs); s->dev.vq_index =0 ; + s->dev.backend_features =0 ; ret =vhost_dev_init (&s->dev, (void *)(uintptr_t )vhostfd,VHOST_BACKEND_TYPE_KERNEL , true);
hw/scsi/vhost-scsi.c static void vhost_scsi_realize(DeviceState *dev, Error **errp) · line 252
Quoted 7 lines
hw/scsi/vhost-scsi.c +0
-1@@ -246,7 +247,6 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp) strerror(-ret));return ; } - s->dev.backend_features =0 ;error_setg (&s->migration_blocker,"vhost-scsi does not support migration" );