staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert
PATCH v4 1/1 staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert
1) removed unused variables
2) fixed sparse warning of context imbalance in 'do_locked_client_insert' different lock contexts for basic block
3) removed the call to visor_signalqueue_empty() , this function is checking whether a signal queue is empty, but the return value of the function is not beeing used, so it is safe to remove.
---
v1 of the patch of the patch just fixed the sparse warning. On suggestion of Dan Carpenter v2 is the total rewrite of the function.
change from v2 to v3 : i messed up in writing a comment , which greg k-h pointed out. The comment was actually not needed , so that has been removed.
change from v3 to v4 : call to visor_signalqueue_empty() was removed and in the if condition comparison with 1 was removed.
drivers/staging/unisys/uislib/uisqueue.c | 37 ++++++-------------------------- 1 file changed, 7 insertions(+), 30 deletions(-)
drivers/staging/unisys/uislib/uisqueue.c +7 -30
@@ -78,41 +78,18 @@ do_locked_client_insert(struct uisqueue_info *queueinfo, u64 interruptHandle, u8 *channelId) { unsigned long flags; -unsigned char queueWasEmpty; -unsigned int locked =0 ; -unsigned int acquired =0 ;u8 rc =0 ;spin_lock_irqsave (lock, flags); - locked =1 ; -if (!ULTRA_CHANNEL_CLIENT_ACQUIRE_OS (queueinfo->chan, channelId,NULL )) - goto Away; - - acquired =1 ; - - queueWasEmpty =visor_signalqueue_empty (queueinfo->chan, whichqueue); -if (!visor_signal_insert (queueinfo->chan, whichqueue, pSignal)) - goto Away; -ULTRA_CHANNEL_CLIENT_RELEASE_OS (queueinfo->chan, channelId,NULL ); - acquired =0 ; -spin_unlock_irqrestore (lock, flags); - locked =0 ; - - queueinfo->packets_sent++; - - rc =1 ; -Away: -if (acquired) { -ULTRA_CHANNEL_CLIENT_RELEASE_OS (queueinfo->chan, channelId, -NULL ); - acquired =0 ; + goto unlock; +if (visor_signal_insert (queueinfo->chan, whichqueue, pSignal)) { + queueinfo->packets_sent++; + rc =1 ; } -if (locked) { -spin_unlock_irqrestore ((spinlock_t *) lock, flags); - locked =0 ; - } - +ULTRA_CHANNEL_CLIENT_RELEASE_OS (queueinfo->chan, channelId,NULL ); +unlock: +spin_unlock_irqrestore ((spinlock_t *)lock, flags);return rc; }
--
1.8.1.2
Quoted 8 lines · Sudip Mukherjee
1) removed unused variables
2) fixed sparse warning of context imbalance in 'do_locked_client_insert' different lock contexts for basic block
3) removed the call tovisor_signalqueue_empty(), this function is checking whether a signal queue is empty, but the return value of the function is not beeing used, so it is safe to remove.Signed-off-by Sudip Mukherjee <[email protected]>
Looks good. Thanks!
regards,
dan carpenter
Quoted 8 lines · Dan Carpenter
Quoted 7 lines · Sudip Mukherjee
1) removed unused variables
2) fixed sparse warning of context imbalance in 'do_locked_client_insert' different lock contexts for basic block
3) removed the call tovisor_signalqueue_empty(), this function is checking whether a signal queue is empty, but the return value of the function is not beeing used, so it is safe to remove.
Quoted 8 lines
Quoted 1 line
Signed-off-by Sudip Mukherjee <[email protected]>Looks good. Thanks!
Reviewed-by Dan Carpenter <[email protected]>regards,
dan carpenter
do i need to resend the patch after adding Reviewed-by to it ?
thanks
sudip
Quoted 7 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 11 lines · Sudip Mukherjee
Quoted 10 lines · Dan Carpenter
Quoted 8 lines · Sudip Mukherjee
1) removed unused variables
2) fixed sparse warning of context imbalance in 'do_locked_client_insert' different lock contexts for basic block
3) removed the call tovisor_signalqueue_empty(), this function is checking whether a signal queue is empty, but the return value of the function is not beeing used, so it is safe to remove.Signed-off-by Sudip Mukherjee <[email protected]>
Quoted 9 lines
Quoted 6 lines
Looks good. Thanks!
Reviewed-by Dan Carpenter <[email protected]>regards,
dan carpenterdo i need to resend the patch after adding Reviewed-by to it ?
No. Greg will reply (perhaps an automated message) when he gets to the patch. Otherwise your job is done.
regards,
dan carpenter