lpfc 10.4.8000.0: random32: do not feed jiffies as seed from lpfc driver
Subsystems (2)
PATCH 8/19 lpfc 10.4.8000.0: random32: do not feed jiffies as seed from lpfc driver
Incorporating prior patch:
http://marc.info/?l=linux-scsi&m=140688548016998&w=2
Daniel Borkmann <[email protected]>
[PATCH] random32: do not feed jiffies as seed from lpfc driver
In prandom we have already reseeding mechanisms that trigger periodically from a much better entropy source than just feeding in jiffies through lpfc_mbx_cmpl_fcf_scan_read_fcf_rec() [what a function name 8-)]. Therefore, just remove this.
Signed-off-by Daniel Borkmann <[email protected]>
Reviewed-by James Smart <[email protected]>
--- drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/scsi/lpfc/lpfc_hbadisc.c +0 -4
@@ -2147,7 +2147,6 @@ lpfc_mbx_cmpl_fcf_scan_read_fcf_rec(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq)uint16_t fcf_index, next_fcf_index;struct lpfc_fcf_rec *fcf_rec =NULL ;uint16_t vlan_id; -uint32_t seed;bool select_new_fcf;int rc;
@@ -2384,9 +2383,6 @@ lpfc_mbx_cmpl_fcf_scan_read_fcf_rec(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq) phba->fcf.fcf_flag |=FCF_AVAILABLE ;/* Setup initial running random FCF selection count */ phba->fcf.eligible_fcf_cnt =1 ; -/* Seeding the random number generator for random selection */ - seed = (uint32_t )(0xFFFFFFFF & jiffies); -prandom_seed (seed); }spin_unlock_irq (&phba->hbalock); goto read_next_fcf;
Signature · 1 line
1.7.11.7