mfd: pcf50633: use sprintf directly
PATCH 1/1 mfd: pcf50633: use sprintf directly
When dump a content of the registers let's use snprintf() directly with %*ph specifier.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/mfd/pcf50633-core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/mfd/pcf50633-core.c +1 -4
@@ -106,10 +106,7 @@ static ssize_t show_dump_regs(struct device *dev, struct device_attribute *attr, }else dump[n1] =pcf50633_reg_read (pcf, n + n1); -hex_dump_to_buffer (dump,sizeof (dump),16 ,1 , buf1,128 ,0 ); - buf1 +=strlen (buf1); - *buf1++ ='\n' ; - *buf1 ='\0' ; + buf1 +=sprintf (buf1,"%*ph\n" , (int )sizeof (dump), dump); }return buf1 - buf;
Signature · 1 line
2.1.0
Lee Jones
AppliedQuoted 7 lines · Andy Shevchenko
When dump a content of the registers let's use
snprintf()directly with %*ph specifier.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/mfd/pcf50633-core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
Applied, thanks.
Quoted 16 lines
drivers/mfd/pcf50633-core.c +1
-4@@ -106,10 +106,7 @@ static ssize_t show_dump_regs(struct device *dev, struct device_attribute *attr, }else dump[n1] =pcf50633_reg_read (pcf, n + n1); -hex_dump_to_buffer (dump,sizeof (dump),16 ,1 , buf1,128 ,0 ); - buf1 +=strlen (buf1); - *buf1++ ='\n' ; - *buf1 ='\0' ; + buf1 +=sprintf (buf1,"%*ph\n" , (int )sizeof (dump), dump); }return buf1 - buf;
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog