gpio: fix comment typos 'CONFIG_GPIO_IRQCHIP'
PATCH 1/1 gpio: fix comment typos 'CONFIG_GPIO_IRQCHIP'
---
Untested.
These two typos were introduced in commit 1425052097b5 ("gpio: add IRQ chip helpers in gpiolib"), which has just been merged.
include/linux/gpio/driver.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/gpio/driver.h +2 -2
@@ -102,7 +102,7 @@ struct gpio_chip {#ifdef CONFIG_GPIOLIB_IRQCHIP /* -* With CONFIG_GPIO_IRQCHIP we get an irqchip inside the gpiolib +* With CONFIG_GPIOLIB_IRQCHIP we get an irqchip inside the gpiolib * to handle IRQs for most practical cases. */ struct irq_chip *irqchip;
@@ -218,7 +218,7 @@ int gpiochip_irqchip_add(struct gpio_chip *gpiochip,irq_flow_handler_t handler, unsigned int type); -#endif /* CONFIG_GPIO_IRQCHIP */ +#endif /* CONFIG_GPIOLIB_IRQCHIP */ #else /* CONFIG_GPIOLIB */
Signature · 1 line
1.9.0
Hi Jiri,
Quoted 24 lines · Paul Bolle
Signed-off-by Paul Bolle <[email protected]>---
Untested.These two typos were introduced in commit
1425052097b5("gpio: add IRQ chip helpers in gpiolib"), which has just been merged.include/linux/gpio/driver.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)include/linux/gpio/driver.h +1
-1@@ -102,7 +102,7 @@ struct gpio_chip {#ifdef CONFIG_GPIOLIB_IRQCHIP /* -* With CONFIG_GPIO_IRQCHIP we get an irqchip inside the gpiolib +* With CONFIG_GPIOLIB_IRQCHIP we get an irqchip inside the gpiolib * to handle IRQs for most practical cases. */ struct irq_chip *irqchip;
include/linux/gpio/driver.h int gpiochip_irqchip_add(struct gpio_chip *gpiochip, · line 223
Quoted 7 lines
include/linux/gpio/driver.h +1
-1@@ -218,7 +218,7 @@ int gpiochip_irqchip_add(struct gpio_chip *gpiochip,irq_flow_handler_t handler, unsigned int type); -#endif /* CONFIG_GPIO_IRQCHIP */ +#endif /* CONFIG_GPIOLIB_IRQCHIP */ #else /* CONFIG_GPIOLIB */
Did you ever had a chance to look at this patch? It still applies to next-20140904.
Paul Bolle
PATCH RESEND 1/1 gpio: fix comment typos 'CONFIG_GPIO_IRQCHIP'
---
Resending at Jiri's request.
Build tested, actually (but only by building drivers/gpio/gpiolib.o).
These two typos were introduced in commit 1425052097b5 ("gpio: add IRQ chip helpers in gpiolib").
include/linux/gpio/driver.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/gpio/driver.h +2 -2
@@ -105,7 +105,7 @@ struct gpio_chip {#ifdef CONFIG_GPIOLIB_IRQCHIP /* -* With CONFIG_GPIO_IRQCHIP we get an irqchip inside the gpiolib +* With CONFIG_GPIOLIB_IRQCHIP we get an irqchip inside the gpiolib * to handle IRQs for most practical cases. */ struct irq_chip *irqchip;
@@ -164,7 +164,7 @@ int gpiochip_irqchip_add(struct gpio_chip *gpiochip,irq_flow_handler_t handler, unsigned int type); -#endif /* CONFIG_GPIO_IRQCHIP */ +#endif /* CONFIG_GPIOLIB_IRQCHIP */ struct gpio_desc *gpiochip_request_own_desc (struct gpio_chip *chip,u16 hwnum,const char *label);
Signature · 1 line
1.9.3