rose: use %*ph specifier
Subsystems (2)
PATCH v2 1/1 rose: use %*ph specifier
Instead of dereference each byte let's use %*ph specifier in the printk() calls.
Signed-off-by Andy Shevchenko <[email protected]>
---
- Since v1:
- compile tested
- fix a wrong argument list
net/rose/rose_link.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/rose/rose_link.c +2 -1
@@ -160,7 +160,8 @@ void rose_link_rx_restart(struct sk_buff *skb, struct rose_neigh *neigh, unsignebreak ;case ROSE_DIAGNOSTIC : -printk (KERN_WARNING "ROSE: received diagnostic #%d - %02X %02X %02X\n" , skb->data[3 ], skb->data[4 ], skb->data[5 ], skb->data[6 ]); +pr_warn ("ROSE: received diagnostic #%d - %3ph\n" , skb->data[3 ], + skb->data +4 );break ;default :
Signature · 1 line
2.1.0
Quoted 16 lines · Andy Shevchenko
Instead of dereference each byte let's use %*ph specifier in the
printk()calls.Signed-off-by Andy Shevchenko <[email protected]>---
- Since v1:
- compile tested
- fix a wrong argument listnet/rose/rose_link.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)net/rose/rose_link.c +0
-0
net/rose/rose_link.c void rose_link_rx_restart(struct sk_buff *skb, struct rose_neigh *neigh, unsigne · line 167
Quoted 9 lines
net/rose/rose_link.c +2
-1@@ -160,7 +160,8 @@ void rose_link_rx_restart(struct sk_buff *skb, struct rose_neigh *neigh, unsignebreak ;case ROSE_DIAGNOSTIC : -printk (KERN_WARNING "ROSE: received diagnostic #%d - %02X %02X %02X\n" , skb->data[3 ], skb->data[4 ], skb->data[5 ], skb->data[6 ]); +pr_warn ("ROSE: received diagnostic #%d - %3ph\n" , skb->data[3 ], + skb->data +4 );break ;default :
This looks better ;)
Acked-by Eric Dumazet <[email protected]>
From: Andy Shevchenko <[email protected]>
Date: Fri, 5 Sep 2014 18:32:18 +0300
Quoted 4 lines
Instead of dereference each byte let's use %*ph specifier in the
printk()calls.Signed-off-by Andy Shevchenko <[email protected]>
Applied.