Skip to contentSkip to conversation

mx6qsabreauto: Remove imx6q-sabreauto.dts

PATCH New Fabio Estevam 4 participants 4 messages Sep 5, 2014 – Sep 9, 2014

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 mx6qsabreauto: Remove imx6q-sabreauto.dts

From: Fabio Estevam <[email protected]>

Commit fa9c021632473 ("mx6: add example DTB for mx6qsabreauto") introduced 'imx6q-sabreauto.dts' but it adds no real value as the dts file only contains the 'model' and 'compatible' strings.

After this commit the final binary is also changed from 'u-boot.imx' to 'u-boot-dtb.imx', which may confuse users.

So revert it until a more complete and useful device tree could be provided.

---
 arch/arm/dts/Makefile            |  1 -
 arch/arm/dts/imx6q-sabreauto.dts | 13 -------------
 include/configs/mx6qsabreauto.h  |  3 ---
 3 files changed, 17 deletions(-)
 delete mode 100644 arch/arm/dts/imx6q-sabreauto.dts
arch/arm/dts/Makefile +0 -1
index 6e2e313..8b35bb8 100644
@@ -8,7 +8,6 @@ dtb-$(CONFIG_EXYNOS5) += exynos5250-arndale.dtb \
 	exynos5250-smdk5250.dtb \
 	exynos5420-smdk5420.dtb \
 	exynos5420-peach-pit.dtb
-dtb-$(CONFIG_MX6) += imx6q-sabreauto.dtb
 dtb-$(CONFIG_TEGRA) += tegra20-harmony.dtb \
 	tegra20-medcom-wide.dtb \
 	tegra20-paz00.dtb \
arch/arm/dts/imx6q-sabreauto.dts deleted +0 -13
deleted file mode 100644
index 7af2a88..0000000
@@ -1,13 +0,0 @@
-/*
- * Copyright 2012 Freescale Semiconductor, Inc.
- * Copyright 2011 Linaro Ltd.
- *
- * SPDX-License-Identifier:     GPL-2.0+
- */
-
-/dts-v1/;
-
-/ {
-	model = "Freescale i.MX6 Quad SABRE Automotive Board";
-	compatible = "fsl,imx6q-sabreauto", "fsl,imx6q";
-};
include/configs/mx6qsabreauto.h +0 -3
index d1639c4..0ab3127 100644
@@ -45,7 +45,4 @@
 #define CONFIG_SYS_I2C_MXC
 #define CONFIG_SYS_I2C_SPEED		100000
 
-#define CONFIG_OF_SEPARATE
-#define CONFIG_DEFAULT_DEVICE_TREE   imx6q-sabreauto
-
 #endif                         /* __MX6QSABREAUTO_CONFIG_H */
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 mx6qsabreauto: Remove imx6q-sabreauto.dts

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Commit fa9c021632473 ("mx6: add example DTB for mx6qsabreauto") introduced 'imx6q-sabreauto.dts' but it adds no real value as the dts file only contains the 'model' and 'compatible' strings.

Quoted 6 lines

After this commit the final binary is also changed from 'u-boot.imx' to 'u-boot-dtb.imx', which may confuse users.

So revert it until a more complete and useful device tree could be provided.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#2 lore raw

PATCH 1/1 mx6qsabreauto: Remove imx6q-sabreauto.dts

Hi Stefano,

Quoted 7 lines · On Fri, 5 Sep 2014 16:26:48 -0300 Otavio Salvador <[email protected]>…
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Commit fa9c021632473 ("mx6: add example DTB for mx6qsabreauto") introduced 'imx6q-sabreauto.dts' but it adds no real value as the dts file only contains the 'model' and 'compatible' strings.

Quoted 9 lines
Quoted 6 lines

After this commit the final binary is also changed from 'u-boot.imx' to 'u-boot-dtb.imx', which may confuse users.

So revert it until a more complete and useful device tree could be provided.

Could you pick up this trivial one and send a pull-req?

I am moving CONFIG_OF_SEPARATE and CONFIG_DEFAULT_DEVICE_TREE to Kconfig.

Ideally, this patch should come first.

See this thread:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/

Best Regards
Masahiro Yamada

#3 lore raw

PATCH 1/1 mx6qsabreauto: Remove imx6q-sabreauto.dts

Hi Masahiro,

Quoted 27 lines · Masahiro Yamada

Hi Stefano,

Quoted 7 lines · On Fri, 5 Sep 2014 16:26:48 -0300 Otavio Salvador <[email protected]>…
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Commit fa9c021632473 ("mx6: add example DTB for mx6qsabreauto") introduced 'imx6q-sabreauto.dts' but it adds no real value as the dts file only contains the 'model' and 'compatible' strings.

Quoted 9 lines
Quoted 6 lines

After this commit the final binary is also changed from 'u-boot.imx' to 'u-boot-dtb.imx', which may confuse users.

So revert it until a more complete and useful device tree could be provided.

Could you pick up this trivial one and send a pull-req?

Quoted 9 lines

I am moving CONFIG_OF_SEPARATE and CONFIG_DEFAULT_DEVICE_TREE to Kconfig.

Ideally, this patch should come first.

See this thread:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/

I am preparing the PR - it comes soon.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================