Skip to contentSkip to conversation

x86: Restore missing cpumask_copy() in __x2apic_send_IPI_mask

PATCH In review Ted Percival 1 participant 3 messages Sep 5, 2014 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: Restore missing cpumask_copy() in __x2apic_send_IPI_mask

This fixes a hang when initializing SMP CPUs at this point in the boot:

x86: Booting SMP configuration
.... node #0, CPUs: #1_

Fixes 4ba2968420fa ("percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t")
---
 arch/x86/kernel/apic/x2apic_cluster.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/kernel/apic/x2apic_cluster.c +1 -0
index 1f5d5f2ffae6..e658f21681c8 100644
@@ -43,6 +43,7 @@ __x2apic_send_IPI_mask(const struct cpumask *mask, int vector, int apic_dest)
 	 * and be sure it's manipulated with irq off.
 	 */
 	ipi_mask_ptr = this_cpu_cpumask_var_ptr(ipi_mask);
+	cpumask_copy(ipi_mask_ptr, mask);
 
 	/*
 	 * The idea is to send one IPI per cluster.
Signature · 1 line
1.9.1
#1 lore raw
Quoted 1 line · Ted Percival

This fixes a hang when initializing SMP CPUs at this point in the boot:

Looks like git-send-email picked up the wrong From address. I'll resubmit with a consistent email address.

#2 lore raw

PATCH 1/1 x86: Restore missing cpumask_copy() in __x2apic_send_IPI_mask

This fixes a hang when initializing SMP CPUs at this point in the boot:

x86: Booting SMP configuration
.... node #0, CPUs: #1_

Fixes 4ba2968420fa ("percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t")
---
 arch/x86/kernel/apic/x2apic_cluster.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/kernel/apic/x2apic_cluster.c +1 -0
index 1f5d5f2ffae6..e658f21681c8 100644
@@ -43,6 +43,7 @@ __x2apic_send_IPI_mask(const struct cpumask *mask, int vector, int apic_dest)
 	 * and be sure it's manipulated with irq off.
 	 */
 	ipi_mask_ptr = this_cpu_cpumask_var_ptr(ipi_mask);
+	cpumask_copy(ipi_mask_ptr, mask);
 
 	/*
 	 * The idea is to send one IPI per cluster.
Signature · 1 line
1.9.1