Skip to contentSkip to conversation

tcp: remove obsolete comment about TCP_SKB_CB(skb)->when in tcp_fragment()

PATCH Applied Neal Cardwell 3 participants 3 messages Sep 6, 2014

Subsystems (3)
lore
Share & tools
lore

Neal Cardwell

author maintainer
#0 lore raw

PATCH 1/1 tcp: remove obsolete comment about TCP_SKB_CB(skb)->when in tcp_fragment()

The TCP_SKB_CB(skb)->when field no longer exists as of recent change 7faee5c0d514 ("tcp: remove TCP_SKB_CB(skb)->when"). And in any case, tcp_fragment() is called on already-transmitted packets from the __tcp_retransmit_skb() call site, so copying timestamps of any kind in this spot is quite sensible.

---
 net/ipv4/tcp_output.c | 3 ---
 1 file changed, 3 deletions(-)
net/ipv4/tcp_output.c +0 -3
index 3b22dcb..7f1280d 100644
@@ -1146,9 +1146,6 @@ int tcp_fragment(struct sock *sk, struct sk_buff *skb, u32 len,
 
 	buff->ip_summed = skb->ip_summed;
 
-	/* Looks stupid, but our code really uses when of
-	 * skbs, which it never sent before. --ANK
-	 */
 	buff->tstamp = skb->tstamp;
 	tcp_fragment_tstamp(skb, buff);
 
Signature · 1 line
2.1.0.rc2.206.gedb03e5
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Neal Cardwell

The TCP_SKB_CB(skb)->when field no longer exists as of recent change 7faee5c0d514 ("tcp: remove TCP_SKB_CB(skb)->when"). And in any case, tcp_fragment() is called on already-transmitted packets from the __tcp_retransmit_skb() call site, so copying timestamps of any kind in this spot is quite sensible.

---
 net/ipv4/tcp_output.c | 3 ---
maintainer Applied
#2 lore raw
In reply to Neal Cardwell

From: Neal Cardwell <[email protected]>
Date: Sat, 6 Sep 2014 11:18:20 -0400

Quoted 8 lines

The TCP_SKB_CB(skb)->when field no longer exists as of recent change 7faee5c0d514 ("tcp: remove TCP_SKB_CB(skb)->when"). And in any case, tcp_fragment() is called on already-transmitted packets from the __tcp_retransmit_skb() call site, so copying timestamps of any kind in this spot is quite sensible.

Applied, thanks Neal.