Skip to contentSkip to conversation

kernel.bbclass: handle .dsp firmware

PATCH In review Carlos Rafael Giani 3 participants 4 messages Sep 8, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel.bbclass: handle .dsp firmware

A few firmware files use this filename extension, like korg/k1212.dsp . Create respective packages.

---
 meta/classes/kernel.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/kernel.bbclass +1 -0
index b02036f..4710719 100644
@@ -387,6 +387,7 @@ python split_kernel_packages () {
     do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.bin$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
     do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.fw$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
     do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.cis$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
+    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.dsp$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
 }
 
 do_strip() {
Signature · 1 line
1.9.1
#1 lore raw
Quoted 13 lines · Carlos Rafael Giani

A few firmware files use this filename extension, like korg/k1212.dsp . Create respective packages.

---
 meta/classes/kernel.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/kernel.bbclass +0 -0
index b02036f..4710719 100644

meta/classes/kernel.bbclass python split_kernel_packages () { · line 391

Quoted 5 lines
meta/classes/kernel.bbclass +1 -0
@@ -387,6 +387,7 @@ python split_kernel_packages () {
     do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.bin$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
     do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.fw$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
     do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.cis$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
+    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.dsp$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
 }

Perhaps its time to improve the regex slightly here and use something like file_regex='^(.*)\.(bin|fw|cis|dsp)$ rather than multiple calls to do_split_packages?

Cheers,

Richard

#2 lore raw
Quoted 23 lines · Richard Purdie
Quoted 13 lines · Carlos Rafael Giani

A few firmware files use this filename extension, like korg/k1212.dsp . Create respective packages.

---
  meta/classes/kernel.bbclass | 1 +
  1 file changed, 1 insertion(+)
meta/classes/kernel.bbclass +0 -0
index b02036f..4710719 100644

meta/classes/kernel.bbclass python split_kernel_packages () { · line 391

Quoted 5 lines
meta/classes/kernel.bbclass +1 -0
@@ -387,6 +387,7 @@ python split_kernel_packages () {
      do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.bin$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
      do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.fw$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
      do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.cis$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
+    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.dsp$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
  }

Perhaps its time to improve the regex slightly here and use something like file_regex='^(.*)\.(bin|fw|cis|dsp)$ rather than multiple calls to do_split_packages?

Quoted 6 lines

Cheers,

Richard

I had the same thought. However, I figured that perhaps it would be better to do this in a followup patch, to keep the two distinct changes separate (add .dsp support + modify regex to the new and improved version).

#3 lore raw
Quoted 8 lines · Carlos Rafael Giani
Quoted 7 lines · Richard Purdie
Quoted 5 lines · Carlos Rafael Giani

A few firmware files use this filename extension, like korg/k1212.dsp . Create respective packages.

...

Quoted 7 lines
Quoted 3 lines

Perhaps its time to improve the regex slightly here and use something like file_regex='^(.*)\.(bin|fw|cis|dsp)$ rather than multiple calls to do_split_packages?

I had the same thought. However, I figured that perhaps it would be better to do this in a followup patch, to keep the two distinct changes separate (add .dsp support + modify regex to the new and improved version).

Agreed.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750