Skip to contentSkip to conversation

Version number cleanup

PATCH In review Philip Tricca 2 participants 6 messages Sep 8, 2014 – Sep 17, 2014

lore
Share & tools
lore
#0 lore raw

cover Version number cleanup

Patch set to use wildcards in the version numbers of the at and shadow bbappends and to remove the 3.4 kernel bbappend.

Philip Tricca (3):
shadow: Use wildcard for version number in bbappend.
at: Use wildcard for version number in bbappend.
linux-yocto: Remove bbappend for old 3.4 kernel.

 recipes-extended/at/at_%.bbappend               |    7 +++++++
 recipes-extended/at/at_3.1.14.bbappend          |    7 -------
 recipes-extended/shadow/shadow_%.bbappend       |    5 +++++
 recipes-extended/shadow/shadow_4.1.4.3.bbappend |    5 -----
 recipes-kernel/linux/linux-yocto_3.4.bbappend   |    7 -------
 5 files changed, 12 insertions(+), 19 deletions(-)
 create mode 100644 recipes-extended/at/at_%.bbappend
 delete mode 100644 recipes-extended/at/at_3.1.14.bbappend
 create mode 100644 recipes-extended/shadow/shadow_%.bbappend
 delete mode 100644 recipes-extended/shadow/shadow_4.1.4.3.bbappend
 delete mode 100644 recipes-kernel/linux/linux-yocto_3.4.bbappend
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/3 shadow: Use wildcard for version number in bbappend.

---
 recipes-extended/shadow/shadow_%.bbappend       |    5 +++++
 recipes-extended/shadow/shadow_4.1.4.3.bbappend |    5 -----
 2 files changed, 5 insertions(+), 5 deletions(-)
 create mode 100644 recipes-extended/shadow/shadow_%.bbappend
 delete mode 100644 recipes-extended/shadow/shadow_4.1.4.3.bbappend
recipes-extended/shadow/shadow_%.bbappend new file +5 -0
new file mode 100644
index 0000000..befe620
@@ -0,0 +1,5 @@
+PR .= ".6"
+
+inherit with-selinux with-audit
+
+FILESEXTRAPATHS_prepend := "${@target_selinux(d, '${THISDIR}/files:')}"
recipes-extended/shadow/shadow_4.1.4.3.bbappend deleted +0 -5
deleted file mode 100644
index befe620..0000000
@@ -1,5 +0,0 @@
-PR .= ".6"
-
-inherit with-selinux with-audit
-
-FILESEXTRAPATHS_prepend := "${@target_selinux(d, '${THISDIR}/files:')}"
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 2/3 at: Use wildcard for version number in bbappend.

In reply to Philip Tricca
---
 recipes-extended/at/at_%.bbappend      |    7 +++++++
 recipes-extended/at/at_3.1.14.bbappend |    7 -------
 2 files changed, 7 insertions(+), 7 deletions(-)
 create mode 100644 recipes-extended/at/at_%.bbappend
 delete mode 100644 recipes-extended/at/at_3.1.14.bbappend
recipes-extended/at/at_%.bbappend new file +7 -0
new file mode 100644
index 0000000..f30abab
@@ -0,0 +1,7 @@
+PR .= ".2"
+
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+
+SRC_URI += "file://at-3.1.13-selinux.patch"
+
+inherit with-selinux
recipes-extended/at/at_3.1.14.bbappend deleted +0 -7
deleted file mode 100644
index f30abab..0000000
@@ -1,7 +0,0 @@
-PR .= ".2"
-
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-SRC_URI += "file://at-3.1.13-selinux.patch"
-
-inherit with-selinux
Signature · 1 line
1.7.10.4
#3 lore raw

PATCH 3/3 linux-yocto: Remove bbappend for old 3.4 kernel.

In reply to Philip Tricca
---
 recipes-kernel/linux/linux-yocto_3.4.bbappend |    7 -------
 1 file changed, 7 deletions(-)
 delete mode 100644 recipes-kernel/linux/linux-yocto_3.4.bbappend
recipes-kernel/linux/linux-yocto_3.4.bbappend deleted +0 -7
deleted file mode 100644
index f9487f2..0000000
@@ -1,7 +0,0 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-# Enable selinux support in the kernel if the feature is enabled
-SRC_URI += "${@base_contains('DISTRO_FEATURES', 'selinux', 'file://selinux.cfg', '', d)}"
-# For inconsistent kallsyms data bug on ARM
-# http://lists.infradead.org/pipermail/linux-arm-kernel/2012-March/thread.html#89718 
-EXTRA_OEMAKE += "${@base_contains('TARGET_ARCH', 'arm', ' KALLSYMS_EXTRA_PASS=1', '', d)}"
Signature · 1 line
1.7.10.4
#4 lore raw
In reply to Philip Tricca

Hello Xin,

Just noticed that you pushed these patches to the meta-selinux repo but with your name and a slightly different commit message in one case. Other than forgetting to copy you on my initial message to the list was there a problem with my patches? Just want to be sure that the next time I send out patches I get them right if there was in fact an issue with these ones.

Thanks,
Philip

Quoted 20 lines · Philip Tricca

Patch set to use wildcards in the version numbers of the at and shadow bbappends and to remove the 3.4 kernel bbappend.

Philip Tricca (3):
shadow: Use wildcard for version number in bbappend.
at: Use wildcard for version number in bbappend.
linux-yocto: Remove bbappend for old 3.4 kernel.

 recipes-extended/at/at_%.bbappend               |    7 +++++++
 recipes-extended/at/at_3.1.14.bbappend          |    7 -------
 recipes-extended/shadow/shadow_%.bbappend       |    5 +++++
 recipes-extended/shadow/shadow_4.1.4.3.bbappend |    5 -----
 recipes-kernel/linux/linux-yocto_3.4.bbappend   |    7 -------
 5 files changed, 12 insertions(+), 19 deletions(-)
 create mode 100644 recipes-extended/at/at_%.bbappend
 delete mode 100644 recipes-extended/at/at_3.1.14.bbappend
 create mode 100644 recipes-extended/shadow/shadow_%.bbappend
 delete mode 100644 recipes-extended/shadow/shadow_4.1.4.3.bbappend
 delete mode 100644 recipes-kernel/linux/linux-yocto_3.4.bbappend
#5 lore raw
Quoted 9 lines · Philip Tricca

Hello Xin,

Just noticed that you pushed these patches to the meta-selinux repo but with your name and a slightly different commit message in one case. Other than forgetting to copy you on my initial message to the list was there a problem with my patches? Just want to be sure that the next time I send out patches I get them right if there was in fact an issue with these ones.

Hi Philip,

I'm sorry that I had missed your mail before pushing.

I used to do small fixes with diectly pushing and not sending review in the maillist, that's why I missed your mail. In the future commits, I will send reivews and check the maillist carefully to avoid similar missing.

Thanks you for your contribution to meta-selinux. :)

- Pascal

Quoted 26 lines

Thanks,
Philip

Quoted 20 lines · Philip Tricca

Patch set to use wildcards in the version numbers of the at and shadow bbappends and to remove the 3.4 kernel bbappend.

Philip Tricca (3):
shadow: Use wildcard for version number in bbappend.
at: Use wildcard for version number in bbappend.
linux-yocto: Remove bbappend for old 3.4 kernel.

  recipes-extended/at/at_%.bbappend               |    7 +++++++
  recipes-extended/at/at_3.1.14.bbappend          |    7 -------
  recipes-extended/shadow/shadow_%.bbappend       |    5 +++++
  recipes-extended/shadow/shadow_4.1.4.3.bbappend |    5 -----
  recipes-kernel/linux/linux-yocto_3.4.bbappend   |    7 -------
  5 files changed, 12 insertions(+), 19 deletions(-)

create mode 100644 recipes-extended/at/at_%.bbappend delete mode 100644 recipes-extended/at/at_3.1.14.bbappend create mode 100644 recipes-extended/shadow/shadow_%.bbappend delete mode 100644 recipes-extended/shadow/shadow_4.1.4.3.bbappend delete mode 100644 recipes-kernel/linux/linux-yocto_3.4.bbappend

Signature · 1 line
- Pascal