Skip to contentSkip to conversation

qt4 webkit: Disable for MIPS64 n32

PATCH New Vicente Olivert Riera 3 participants 5 messages Sep 8, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qt4 webkit: Disable for MIPS64 n32

qt4 webkit fails to compile for MIPS64 n32. A bug has been reported upstream, so we disable this package until upstream fixes the problem.

Upstream bug:
https://bugreports.qt-project.org/browse/QTBUG-39224

Fixes:
http://autobuild.buildroot.net/results/2ab/2ab5ab179dab9e1a47092b066f97d48c75ab935b/

---
 package/qt/Config.in |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
package/qt/Config.in +3 -0
index da159b4..8c0fe54 100644
@@ -371,6 +371,9 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 
 config BR2_PACKAGE_QT_WEBKIT
 	bool "WebKit Module"
+	# qt-4.8.6 webkit: fails to compile on MIPS64 n32 platforms
+	# https://bugreports.qt-project.org/browse/QTBUG-39224
+	depends on !BR2_MIPS_NABI32
 	depends on BR2_PACKAGE_QT_SHARED
 	depends on BR2_PACKAGE_QT_GUI_MODULE
 	depends on BR2_PACKAGE_QT_NETWORK
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 qt4 webkit: Disable for MIPS64 n32

Hi Vicente,

Quoted 20 lines · Vicente Olivert Riera

qt4 webkit fails to compile for MIPS64 n32. A bug has been reported upstream, so we disable this package until upstream fixes the problem.

Upstream bug:
https://bugreports.qt-project.org/browse/QTBUG-39224

Fixes:
http://autobuild.buildroot.net/results/2ab/2ab5ab179dab9e1a47092b066f97d48c75ab935b/

---
 package/qt/Config.in |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
package/qt/Config.in +0 -0
index da159b4..8c0fe54 100644

package/qt/Config.in config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT · line 376

Quoted 6 lines
package/qt/Config.in +3 -0
@@ -371,6 +371,9 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 
 config BR2_PACKAGE_QT_WEBKIT
 	bool "WebKit Module"
+	# qt-4.8.6 webkit: fails to compile on MIPS64 n32 platforms
+	# https://bugreports.qt-project.org/browse/QTBUG-39224
+	depends on !BR2_MIPS_NABI32

Please update the dependencies of the comment below accordingly.

baruch

Quoted 3 lines
package/qt/Config.in +0 -0
 	depends on BR2_PACKAGE_QT_SHARED
 	depends on BR2_PACKAGE_QT_GUI_MODULE
 	depends on BR2_PACKAGE_QT_NETWORK
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 qt4 webkit: Disable for MIPS64 n32

Quoted 32 lines · Baruch Siach

Hi Vicente,

Quoted 20 lines · Vicente Olivert Riera

qt4 webkit fails to compile for MIPS64 n32. A bug has been reported upstream, so we disable this package until upstream fixes the problem.

Upstream bug:

   https://bugreports.qt-project.org/browse/QTBUG-39224

Fixes:

   http://autobuild.buildroot.net/results/2ab/2ab5ab179dab9e1a47092b066f97d48c75ab935b/
---
  package/qt/Config.in |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)
package/qt/Config.in +0 -0
index da159b4..8c0fe54 100644

package/qt/Config.in config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT · line 376

Quoted 6 lines
package/qt/Config.in +3 -0
@@ -371,6 +371,9 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 
  config BR2_PACKAGE_QT_WEBKIT
  	bool "WebKit Module"
+	# qt-4.8.6 webkit: fails to compile on MIPS64 n32 platforms
+	# https://bugreports.qt-project.org/browse/QTBUG-39224
+	depends on !BR2_MIPS_NABI32

Please update the dependencies of the comment below accordingly.

Quoted 6 lines

baruch

Quoted 3 lines
package/qt/Config.in +0 -0
  	depends on BR2_PACKAGE_QT_SHARED
  	depends on BR2_PACKAGE_QT_GUI_MODULE
  	depends on BR2_PACKAGE_QT_NETWORK

Are you sure this is necessary? I thought that was needed only for toolchain dependencies.

For instance, there are packages which depend on !BR2_MIPS_NABI32 and they don't have a comment for that:

ecryptfs-utils/Config.in
tinymembench/Config.in

Signature · 1 line
Vincent
#3 lore raw

PATCH 1/1 qt4 webkit: Disable for MIPS64 n32

Hi Vicente,

Quoted 37 lines · Vicente Olivert Riera
Quoted 30 lines · Baruch Siach
Quoted 20 lines · Vicente Olivert Riera

qt4 webkit fails to compile for MIPS64 n32. A bug has been reported upstream, so we disable this package until upstream fixes the problem.

Upstream bug:
https://bugreports.qt-project.org/browse/QTBUG-39224

Fixes:
http://autobuild.buildroot.net/results/2ab/2ab5ab179dab9e1a47092b066f97d48c75ab935b/

---
 package/qt/Config.in |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
package/qt/Config.in +0 -0
index da159b4..8c0fe54 100644

package/qt/Config.in config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT · line 376

Quoted 6 lines
package/qt/Config.in +3 -0
@@ -371,6 +371,9 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 
 config BR2_PACKAGE_QT_WEBKIT
 	bool "WebKit Module"
+	# qt-4.8.6 webkit: fails to compile on MIPS64 n32 platforms
+	# https://bugreports.qt-project.org/browse/QTBUG-39224
+	depends on !BR2_MIPS_NABI32

Please update the dependencies of the comment below accordingly.

Quoted 5 lines

baruch

Quoted 3 lines
package/qt/Config.in +0 -0
 	depends on BR2_PACKAGE_QT_SHARED
 	depends on BR2_PACKAGE_QT_GUI_MODULE
 	depends on BR2_PACKAGE_QT_NETWORK
Quoted 8 lines

Are you sure this is necessary? I thought that was needed only for toolchain dependencies.

For instance, there are packages which depend on !BR2_MIPS_NABI32 and they don't have a comment for that:

ecryptfs-utils/Config.in
tinymembench/Config.in

You don't need the comment text to refer to architecture dependencies, since the user can't do much about them. But you do need to not show the comment when not applicable for the same reason. Note that the comment already depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT for this reason.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#4 lore raw

PATCH 1/1 qt4 webkit: Disable for MIPS64 n32

In reply to Vicente Olivert Riera

Dear Vicente Olivert Riera,

package/qt/Config.in config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT · line 379

Quoted 8 lines · Vicente Olivert Riera

config BR2_PACKAGE_QT_WEBKIT

package/qt/Config.in +3 -0
 	bool "WebKit Module"
+	# qt-4.8.6 webkit: fails to compile on MIPS64 n32 platforms
+	# https://bugreports.qt-project.org/browse/QTBUG-39224
+	depends on !BR2_MIPS_NABI32
 	depends on BR2_PACKAGE_QT_SHARED
 	depends on BR2_PACKAGE_QT_GUI_MODULE
 	depends on BR2_PACKAGE_QT_NETWORK

No. As explained in a separate thread, you should use BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com