mwait_idle: Disable Baytrail Core and Module C6 auto-demotion
PATCH 1/2 mwait_idle: Disable Baytrail Core and Module C6 auto-demotion
From: Len Brown <[email protected]>
Power efficiency improves on Baytrail (Intel Atom Processor E3000) when C6 auto-demotion is disabled.
Based on work by Srinidhi Kasagar <[email protected]>.
--- xen/arch/x86/cpu/mwait-idle.c | 7 +++++++ xen/include/asm-x86/msr-index.h | 3 +++ 2 files changed, 10 insertions(+)
xen/arch/x86/cpu/mwait-idle.c +7 -0
@@ -88,6 +88,7 @@ struct idle_cpu {* Indicate which enable bits to clear here. */ unsigned long auto_demotion_disable_flags; +bool_t byt_auto_demotion_disable_flag;bool_t disable_promotion_to_c1e; };
@@ -569,6 +570,7 @@ static const struct idle_cpu idle_cpu_snb = {static const struct idle_cpu idle_cpu_byt = { .state_table = byt_cstates, .disable_promotion_to_c1e =1 , + .byt_auto_demotion_disable_flag =1 , };static const struct idle_cpu idle_cpu_ivb = {
@@ -767,6 +769,11 @@ static int mwait_idle_cpu_init(struct notifier_block *nfb,if (icpu->auto_demotion_disable_flags)on_selected_cpus (cpumask_of (cpu), auto_demotion_disable,NULL ,1 ); +if (icpu->byt_auto_demotion_disable_flag) { +wrmsrl (MSR_CC6_DEMOTION_POLICY_CONFIG ,0 ); +wrmsrl (MSR_MC6_DEMOTION_POLICY_CONFIG ,0 ); + } +if (icpu->disable_promotion_to_c1e)on_selected_cpus (cpumask_of (cpu), c1e_promotion_disable,NULL ,1 );
xen/include/asm-x86/msr-index.h +3 -0
@@ -102,6 +102,9 @@#define CMCI_EN (1UL<<30)#define CMCI_THRESHOLD_MASK 0x7FFF +#define MSR_CC6_DEMOTION_POLICY_CONFIG 0x00000668 +#define MSR_MC6_DEMOTION_POLICY_CONFIG 0x00000669 +#define MSR_AMD64_MC0_MASK 0xc0010044#define MSR_IA32_MCx_CTL (x) (MSR_IA32_MC0_CTL + 4*(x))
Signature · 1 line
1.9.3
PATCH 2/2 mwait_idle: Broadwell support
From: Len Brown <[email protected]>
Broadwell (BDW) is similar to Haswell (HSW), the preceding processor generation.
Currently, the only difference in their C-state tables is that PC3 max exit latency is 33usec on HSW and 40usec on BDW.
--- xen/arch/x86/cpu/mwait-idle.c | 60 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+)
xen/arch/x86/cpu/mwait-idle.c +60 -0
@@ -398,6 +398,58 @@ static const struct cpuidle_state hsw_cstates[] = { {} }; +static struct cpuidle_state bdw_cstates[] = { + { + .name ="C1-BDW" , + .flags =MWAIT2flg (0x00 ), + .exit_latency =2 , + .target_residency =2 , + }, + { + .name ="C1E-BDW" , + .flags =MWAIT2flg (0x01 ), + .exit_latency =10 , + .target_residency =20 , + }, + { + .name ="C3-BDW" , + .flags =MWAIT2flg (0x10 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =40 , + .target_residency =100 , + }, + { + .name ="C6-BDW" , + .flags =MWAIT2flg (0x20 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =133 , + .target_residency =400 , + }, + { + .name ="C7s-BDW" , + .flags =MWAIT2flg (0x32 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =166 , + .target_residency =500 , + }, + { + .name ="C8-BDW" , + .flags =MWAIT2flg (0x40 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =300 , + .target_residency =900 , + }, + { + .name ="C9-BDW" , + .flags =MWAIT2flg (0x50 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =600 , + .target_residency =1800 , + }, + { + .name ="C10-BDW" , + .flags =MWAIT2flg (0x60 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =2600 , + .target_residency =7700 , + }, + {} +}; +static const struct cpuidle_state atom_cstates[] = { { .name ="C1E-ATM" ,
@@ -588,6 +640,11 @@ static const struct idle_cpu idle_cpu_hsw = { .disable_promotion_to_c1e = 1, }; +static const struct idle_cpu idle_cpu_bdw = { + .state_table = bdw_cstates, + .disable_promotion_to_c1e =1 , +}; +static const struct idle_cpu idle_cpu_avn = { .state_table = avn_cstates, .disable_promotion_to_c1e =1 ,
@@ -619,6 +676,9 @@ static struct intel_idle_id {ICPU (0x45 , hsw),ICPU (0x46 , hsw),ICPU (0x4d , avn), +ICPU (0x3d , bdw), +ICPU (0x4f , bdw), + ICPU(0x56, bdw), {} };
Signature · 1 line
1.9.3
Re: [PATCH 2/2] mwait_idle: Broadwell support
Quoted 6 lines
Quoted 1 line
Quoted 1 line · On 08.09.14 at 14:42, <[email protected]> wrote:
From: Len Brown <[email protected]>
Broadwell (BDW) is similar to Haswell (HSW), the preceding processor generation.
Quoted 6 lines
Currently, the only difference in their C-state tables is that PC3 max exit latency
is 33usec on HSW and 40usec on BDW.Signed-off-by Len Brown <[email protected]>Signed-off-by Ross Lagerwall <[email protected]>
Here yours is almost identical to mine - yours lacking a "const" and having some indentation issues.
Jan
x86/mwait-idle: Broadwell support
Broadwell (BDW) is similar to Haswell (HSW), the preceding processor generation.
Currently, the only difference in their C-state tables is that PC3 max exit latency is 33usec on HSW and 40usec on BDW.
xen/arch/x86/cpu/mwait-idle.c +60 -0
@@ -398,6 +398,58 @@ static const struct cpuidle_state hsw_cs {} }; +static const struct cpuidle_state bdw_cstates[] = { + { + .name ="C1-BDW" , + .flags =MWAIT2flg (0x00 ), + .exit_latency =2 , + .target_residency =2 , + }, + { + .name ="C1E-BDW" , + .flags =MWAIT2flg (0x01 ), + .exit_latency =10 , + .target_residency =20 , + }, + { + .name ="C3-BDW" , + .flags =MWAIT2flg (0x10 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =40 , + .target_residency =100 , + }, + { + .name ="C6-BDW" , + .flags =MWAIT2flg (0x20 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =133 , + .target_residency =400 , + }, + { + .name ="C7s-BDW" , + .flags =MWAIT2flg (0x32 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =166 , + .target_residency =500 , + }, + { + .name ="C8-BDW" , + .flags =MWAIT2flg (0x40 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =300 , + .target_residency =900 , + }, + { + .name ="C9-BDW" , + .flags =MWAIT2flg (0x50 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =600 , + .target_residency =1800 , + }, + { + .name ="C10-BDW" , + .flags =MWAIT2flg (0x60 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =2600 , + .target_residency =7700 , + }, + {} +}; +static const struct cpuidle_state atom_cstates[] = { { .name ="C1E-ATM" ,
@@ -596,6 +648,11 @@ static const struct idle_cpu idle_cpu_hs .disable_promotion_to_c1e = 1, }; +static const struct idle_cpu idle_cpu_bdw = { + .state_table = bdw_cstates, + .disable_promotion_to_c1e =1 , +}; +static const struct idle_cpu idle_cpu_avn = { .state_table = avn_cstates, .disable_promotion_to_c1e =1 ,
@@ -627,6 +684,9 @@ static struct intel_idle_id {ICPU (0x45 , hsw),ICPU (0x46 , hsw),ICPU (0x4d , avn), +ICPU (0x3d , bdw), +ICPU (0x4f , bdw), + ICPU(0x56, bdw), {} };
x86/mwait-idle: Broadwell support
Broadwell (BDW) is similar to Haswell (HSW), the preceding processor generation.
Currently, the only difference in their C-state tables is that PC3 max exit latency is 33usec on HSW and 40usec on BDW.
xen/arch/x86/cpu/mwait-idle.c +60 -0
78 lines not on this page · raw message
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
Re: [PATCH 2/2] mwait_idle: Broadwell support
In reply to Ross LagerwallDid you guys validate this in real machine? Or any potential side affect?
When I do IGD GFX passthrough with qemu-xen-traditional, I found in the boot phase of VM, the target will reboot. After I revert this everything is fine.
Note I don't add anything into codes. Here I just build Xen unstable 4.5 to use qemu-xen-traditional. And additionally, my BDW is based on stepping E, and guest is WindXP.
Thanks
Tiejun
Quoted 99 lines · Ross Lagerwall
From: Len Brown <[email protected]>
Broadwell (BDW) is similar to Haswell (HSW), the preceding processor generation.
Currently, the only difference in their C-state tables is that PC3 max exit latency is 33usec on HSW and 40usec on BDW.
Signed-off-by Len Brown <[email protected]>Signed-off-by Ross Lagerwall <[email protected]>--- xen/arch/x86/cpu/mwait-idle.c | 60 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+)xen/arch/x86/cpu/mwait-idle.c +60
-0@@ -398,6 +398,58 @@ static const struct cpuidle_state hsw_cstates[] = { {} }; +static struct cpuidle_state bdw_cstates[] = { + { + .name ="C1-BDW" , + .flags =MWAIT2flg (0x00 ), + .exit_latency =2 , + .target_residency =2 , + }, + { + .name ="C1E-BDW" , + .flags =MWAIT2flg (0x01 ), + .exit_latency =10 , + .target_residency =20 , + }, + { + .name ="C3-BDW" , + .flags =MWAIT2flg (0x10 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =40 , + .target_residency =100 , + }, + { + .name ="C6-BDW" , + .flags =MWAIT2flg (0x20 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =133 , + .target_residency =400 , + }, + { + .name ="C7s-BDW" , + .flags =MWAIT2flg (0x32 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =166 , + .target_residency =500 , + }, + { + .name ="C8-BDW" , + .flags =MWAIT2flg (0x40 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =300 , + .target_residency =900 , + }, + { + .name ="C9-BDW" , + .flags =MWAIT2flg (0x50 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =600 , + .target_residency =1800 , + }, + { + .name ="C10-BDW" , + .flags =MWAIT2flg (0x60 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =2600 , + .target_residency =7700 , + }, + {} +}; +static const struct cpuidle_state atom_cstates[] = { { .name ="C1E-ATM" ,@@ -588,6 +640,11 @@ static const struct idle_cpu idle_cpu_hsw = { .disable_promotion_to_c1e = 1, }; +static const struct idle_cpu idle_cpu_bdw = { + .state_table = bdw_cstates, + .disable_promotion_to_c1e =1 , +}; +static const struct idle_cpu idle_cpu_avn = { .state_table = avn_cstates, .disable_promotion_to_c1e =1 ,@@ -619,6 +676,9 @@ static struct intel_idle_id {ICPU (0x45 , hsw),ICPU (0x46 , hsw),ICPU (0x4d , avn), +ICPU (0x3d , bdw), +ICPU (0x4f , bdw), + ICPU(0x56, bdw), {} };
Re: [PATCH 2/2] mwait_idle: Broadwell support
Quoted 6 lines
Quoted 1 line
Quoted 1 line · On 16.10.14 at 14:54, <[email protected]> wrote:
Did you guys validate this in real machine? Or any potential side affect?
When I do IGD GFX passthrough with qemu-xen-traditional, I found in the boot phase of VM, the target will reboot. After I revert this everything is fine.
Please be more precise. What is "target" here? Host? Guest? Also, reporting issues just verbally (i.e. without any logs or other actual technical information) rarely makes a lot of sense.
Quoted 3 lines
Note I don't add anything into codes. Here I just build Xen unstable 4.5 to use qemu-xen-traditional. And additionally, my BDW is based on stepping E, and guest is WindXP.
But the change is only about C-state handling for a particular CPU model. There's really nothing being added that doesn't already work fine elsewhere. I.e. this patch being the apparent culprit of a problem you see makes it relatively likely that your hardware is having some issue.
Jan
Re: [PATCH 2/2] mwait_idle: Broadwell support
Quoted 8 lines · Jan Beulich
Quoted 6 lines
Quoted 1 line
Quoted 1 line · On 16.10.14 at 14:54, <[email protected]> wrote:
Did you guys validate this in real machine? Or any potential side affect?
When I do IGD GFX passthrough with qemu-xen-traditional, I found in the boot phase of VM, the target will reboot. After I revert this everything is fine.
Please be more precise. What is "target" here? Host? Guest?
The real target is BDW based on stepping E. When I use qemu-xen-traditional to validate IGD passthrough like this,
gfx_passthru=1
pci=["00:02.0", "00:14.0"]
Here the device at "00:02.0" is IGD device, another is USB controller.
And we should pass 'no-sharept' to disable shared EPT table since you know there is a well-know RMRR problem I'm trying to fix.
During the Windows7 guest VM boot phase, the physical machine reboot directly.
Quoted 2 lines
Also, reporting issues just verbally (i.e. without any logs or other actual technical information) rarely makes a lot of sense.
As I said above the machine reboot directly. I can't see any output.
Quoted 4 lines
Quoted 4 lines
Note I don't add anything into codes. Here I just build Xen unstable 4.5 to use qemu-xen-traditional. And additionally, my BDW is based on stepping E, and guest is WindXP.
Any other technical information you guys want to know?
Quoted 6 lines
But the change is only about C-state handling for a particular CPU model. There's really nothing being added that doesn't already work fine elsewhere. I.e. this patch being the apparent culprit of a problem you see makes it relatively likely that your hardware is having some issue.
Yes I also suspect this point but I tried two machine, I still can see the same problem. Maybe this is related to CPU stepping, BIOS or some errata we may ignore previously. So I just post this to ask if anybody know this in detail.
Thanks
Tiejun
Quoted 4 lines
Jan
Re: [PATCH 2/2] mwait_idle: Broadwell support
Quoted 6 lines
Quoted 1 line
Quoted 1 line · On 17.10.14 at 03:22, <[email protected]> wrote:
Quoted 2 lines · Jan Beulich
Also, reporting issues just verbally (i.e. without any logs or other actual technical information) rarely makes a lot of sense.
As I said above the machine reboot directly. I can't see any output.
Triple faults are extremely rare. Are you sure you have "sync_console noreboot" in place on your hypervisor command line (and of course a serial console properly set up)?
Jan
Re: [PATCH 2/2] mwait_idle: Broadwell support
Quoted 10 lines · Jan Beulich
Quoted 6 lines
Quoted 1 line
Quoted 1 line · On 17.10.14 at 03:22, <[email protected]> wrote:
Quoted 2 lines · Jan Beulich
Also, reporting issues just verbally (i.e. without any logs or other actual technical information) rarely makes a lot of sense.
As I said above the machine reboot directly. I can't see any output.
Triple faults are extremely rare. Are you sure you have "
sync_consolenoreboot" in place on your hypervisor command line (and of course a serial console properly set up)?
Looks current BIOS can't output anything so I will try this once I get the latest.
Thanks
Tiejun
Re: [PATCH 2/2] mwait_idle: Broadwell support
In reply to Chen, TiejunQuoted 1 line · Tiejun
Did you guys validate this in real machine? Or any potential side affect?
Any comments?
Quoted 3 lines
When I do IGD GFX passthrough with qemu-xen-traditional, I found in the boot phase of VM, the target will reboot. After I revert this everything
Especially after reboot APCI can't be parsed correctly then Xen will disable VT-d. So I have to power off the target then power on to recover this.
Quoted 5 lines
is fine.
Note I don't add anything into codes. Here I just build Xen unstable 4.5 to use qemu-xen-traditional. And additionally, my BDW is based on stepping E, and guest is WindXP.
s/WindXP/Wind7
Thanks
Tiejun
Quoted 114 lines
Thanks
TiejunQuoted 94 lines · Ross Lagerwall
From: Len Brown <[email protected]>
Broadwell (BDW) is similar to Haswell (HSW), the preceding processor generation.
Currently, the only difference in their C-state tables is that PC3 max exit latency
is 33usec on HSW and 40usec on BDW.Signed-off-by Len Brown <[email protected]>Signed-off-by Ross Lagerwall <[email protected]>--- xen/arch/x86/cpu/mwait-idle.c | 60 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+)xen/arch/x86/cpu/mwait-idle.c +57
-0@@ -398,6 +398,58 @@ static const struct cpuidle_state hsw_cstates[] = { {} }; +static struct cpuidle_state bdw_cstates[] = { + { + .name ="C1-BDW" , + .flags =MWAIT2flg (0x00 ), + .exit_latency =2 , + .target_residency =2 , + }, + { + .name ="C1E-BDW" , + .flags =MWAIT2flg (0x01 ), + .exit_latency =10 , + .target_residency =20 , + }, + { + .name ="C3-BDW" , + .flags =MWAIT2flg (0x10 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =40 , + .target_residency =100 , + }, + { + .name ="C6-BDW" , + .flags =MWAIT2flg (0x20 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =133 , + .target_residency =400 , + }, + { + .name ="C7s-BDW" , + .flags =MWAIT2flg (0x32 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =166 , + .target_residency =500 , + }, + { + .name ="C8-BDW" , + .flags =MWAIT2flg (0x40 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =300 , + .target_residency =900 , + }, + { + .name ="C9-BDW" , + .flags =MWAIT2flg (0x50 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =600 , + .target_residency =1800 , + }, + { + .name ="C10-BDW" , + .flags =MWAIT2flg (0x60 ) |CPUIDLE_FLAG_TLB_FLUSHED , + .exit_latency =2600 , + .target_residency =7700 , + }, + {} +}; +static const struct cpuidle_state atom_cstates[] = { { .name ="C1E-ATM" ,@@ -588,6 +640,11 @@ static const struct idle_cpu idle_cpu_hsw = { .disable_promotion_to_c1e = 1, }; +static const struct idle_cpu idle_cpu_bdw = { + .state_table = bdw_cstates, + .disable_promotion_to_c1e =1 , +}; +static const struct idle_cpu idle_cpu_avn = { .state_table = avn_cstates, .disable_promotion_to_c1e =1 ,xen/arch/x86/cpu/mwait-idle.c static struct intel_idle_id { · line 684
Quoted 9 lines
xen/arch/x86/cpu/mwait-idle.c +3
-0@@ -619,6 +676,9 @@ static struct intel_idle_id {ICPU (0x45 , hsw),ICPU (0x46 , hsw),ICPU (0x4d , avn), +ICPU (0x3d , bdw), +ICPU (0x4f , bdw), + ICPU(0x56, bdw), {} };_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
Quoted 10 lines
Quoted 1 line
Quoted 1 line · On 08.09.14 at 14:42, <[email protected]> wrote:
From: Len Brown <[email protected]>
Power efficiency improves on Baytrail (Intel Atom Processor E3000) when C6 auto-demotion is disabled.
Based on work by Srinidhi Kasagar <[email protected]>.
Signed-off-by Len Brown <[email protected]>Signed-off-by Ross Lagerwall <[email protected]>
So we raced on pulling these over - I did so late last week too and just didn't get to send them out yet. On this one I in fact doubt (and sent a respective query to Len; no response yet) that the MSR handling is. Hence my ported over patch is a little different:
x86/mwait-idle: disable Baytrail Core and Module C6 auto-demotion
Power efficiency improves on Baytrail (Intel Atom Processor E3000) when Linux disables C6 auto-demotion.
Based on work by Srinidhi Kasagar <[email protected]>.
Do the MSR writes on all CPUs rather than just the current one.
xen/include/asm-x86/msr-index.h +3 -0
@@ -483,4 +483,7 @@#define _MSR_MISC_FEATURES_CPUID_FAULTING 0#define MSR_MISC_FEATURES_CPUID_FAULTING (1ULL << _MSR_MISC_FEATURES_CPUID_FAULTING) +#define MSR_CC6_DEMOTION_POLICY_CONFIG 0x00000668 +#define MSR_MC6_DEMOTION_POLICY_CONFIG 0x00000669 +#endif /* __ASM_MSR_INDEX_H */
xen/arch/x86/cpu/mwait-idle.c +11 -0
@@ -88,6 +88,7 @@ struct idle_cpu {* Indicate which enable bits to clear here. */ unsigned long auto_demotion_disable_flags; +bool_t byt_auto_demotion_disable_flag;bool_t disable_promotion_to_c1e; };
@@ -539,6 +540,12 @@ static void auto_demotion_disable(void *wrmsrl (MSR_NHM_SNB_PKG_CST_CFG_CTL , msr_bits); } +static void byt_auto_demotion_disable (void *dummy) +{ +wrmsrl (MSR_CC6_DEMOTION_POLICY_CONFIG ,0 ); +wrmsrl (MSR_MC6_DEMOTION_POLICY_CONFIG ,0 ); +} +static void c1e_promotion_disable (void *dummy) {u64 msr_bits;
@@ -571,6 +578,7 @@ static const struct idle_cpu idle_cpu_snstatic const struct idle_cpu idle_cpu_byt = { .state_table = byt_cstates, .disable_promotion_to_c1e =1 , + .byt_auto_demotion_disable_flag =1 , };static const struct idle_cpu idle_cpu_ivb = {
@@ -769,6 +777,9 @@ static int mwait_idle_cpu_init(struct noif (icpu->auto_demotion_disable_flags)on_selected_cpus (cpumask_of (cpu), auto_demotion_disable,NULL ,1 ); +if (icpu->byt_auto_demotion_disable_flag) +on_selected_cpus (cpumask_of (cpu), byt_auto_demotion_disable,NULL ,1 ); +if (icpu->disable_promotion_to_c1e)on_selected_cpus (cpumask_of (cpu), c1e_promotion_disable,NULL ,1 );
x86/mwait-idle: disable Baytrail Core and Module C6 auto-demotion
Power efficiency improves on Baytrail (Intel Atom Processor E3000) when Linux disables C6 auto-demotion.
Based on work by Srinidhi Kasagar <[email protected]>.
Do the MSR writes on all CPUs rather than just the current one.
xen/include/asm-x86/msr-index.h +3 -0
@@ -483,4 +483,7 @@#define _MSR_MISC_FEATURES_CPUID_FAULTING 0#define MSR_MISC_FEATURES_CPUID_FAULTING (1ULL << _MSR_MISC_FEATURES_CPUID_FAULTING) +#define MSR_CC6_DEMOTION_POLICY_CONFIG 0x00000668 +#define MSR_MC6_DEMOTION_POLICY_CONFIG 0x00000669 +#endif /* __ASM_MSR_INDEX_H */
xen/arch/x86/cpu/mwait-idle.c +11 -0
@@ -88,6 +88,7 @@ struct idle_cpu {* Indicate which enable bits to clear here. */ unsigned long auto_demotion_disable_flags; +bool_t byt_auto_demotion_disable_flag;bool_t disable_promotion_to_c1e; };
@@ -539,6 +540,12 @@ static void auto_demotion_disable(void *wrmsrl (MSR_NHM_SNB_PKG_CST_CFG_CTL , msr_bits); } +static void byt_auto_demotion_disable (void *dummy) +{ +wrmsrl (MSR_CC6_DEMOTION_POLICY_CONFIG ,0 ); +wrmsrl (MSR_MC6_DEMOTION_POLICY_CONFIG ,0 ); +} +static void c1e_promotion_disable (void *dummy) {u64 msr_bits;
@@ -571,6 +578,7 @@ static const struct idle_cpu idle_cpu_snstatic const struct idle_cpu idle_cpu_byt = { .state_table = byt_cstates, .disable_promotion_to_c1e =1 , + .byt_auto_demotion_disable_flag =1 , };static const struct idle_cpu idle_cpu_ivb = {
@@ -769,6 +777,9 @@ static int mwait_idle_cpu_init(struct noif (icpu->auto_demotion_disable_flags)on_selected_cpus (cpumask_of (cpu), auto_demotion_disable,NULL ,1 ); +if (icpu->byt_auto_demotion_disable_flag) +on_selected_cpus (cpumask_of (cpu), byt_auto_demotion_disable,NULL ,1 ); +if (icpu->disable_promotion_to_c1e)on_selected_cpus (cpumask_of (cpu), c1e_promotion_disable,NULL ,1 );
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
Quoted 8 lines · Jan Beulich
Quoted 8 lines
Quoted 1 line
Quoted 1 line · On 08.09.14 at 14:42, <[email protected]> wrote:
From: Len Brown <[email protected]>
Power efficiency improves on Baytrail (Intel Atom Processor E3000) when C6 auto-demotion is disabled.
Based on work by Srinidhi Kasagar <[email protected]>.
Quoted 8 lines
Quoted 2 lines
Signed-off-by Len Brown <[email protected]>Signed-off-by Ross Lagerwall <[email protected]>So we raced on pulling these over - I did so late last week too and just didn't get to send them out yet. On this one I in fact doubt (and sent a respective query to Len; no response yet) that the MSR handling is. Hence my ported over patch is a little different:
According to Intel's manual, those two registers have package scope, i.e. all processor cores in the package share the same MSR, so presumably the original commit is OK.
Signature · 1 line
Ross Lagerwall
Quoted 19 lines
Quoted 1 line
Quoted 1 line · On 08.09.14 at 16:02, <[email protected]> wrote:
Quoted 8 lines · Jan Beulich
Quoted 8 lines
Quoted 1 line
Quoted 1 line · On 08.09.14 at 14:42, <[email protected]> wrote:
From: Len Brown <[email protected]>
Power efficiency improves on Baytrail (Intel Atom Processor E3000) when C6 auto-demotion is disabled.
Based on work by Srinidhi Kasagar <[email protected]>.
Quoted 8 lines
Quoted 2 lines
Signed-off-by Len Brown <[email protected]>Signed-off-by Ross Lagerwall <[email protected]>So we raced on pulling these over - I did so late last week too and just didn't get to send them out yet. On this one I in fact doubt (and sent a respective query to Len; no response yet) that the MSR handling is. Hence my ported over patch is a little different:
Quoted 3 lines
According to Intel's manual, those two registers have package scope, i.e. all processor cores in the package share the same MSR, so presumably the original commit is OK.
Provided none of these can occur in multi-socket systems (which seems likely to be the case for Atoms, but I'm not finally certain, and there's definitely no harm in doing this redundantly).
Jan