Skip to contentSkip to conversation

xen/efi: Directly include needed headers

PATCH Applied Daniel Kiper 2 participants 5 messages Sep 8, 2014 – Sep 9, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/efi: Directly include needed headers

I discovered that some needed stuff is defined/declared in headers which are not included directly. Currently it works but if somebody remove required headers from currently included headers then build will break. So, just in case directly include all needed headers.

---
 arch/x86/xen/efi.c |    2 ++
 drivers/xen/efi.c  |    2 ++
 2 files changed, 4 insertions(+)
arch/x86/xen/efi.c +2 -0
index a02e09e..be14cc3 100644
@@ -15,12 +15,14 @@
  * with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <linux/bitops.h>
 #include <linux/efi.h>
 #include <linux/init.h>
 #include <linux/string.h>
 
 #include <xen/xen-ops.h>
 
+#include <asm/page.h>
 #include <asm/setup.h>
 
 void __init xen_efi_init(void)
drivers/xen/efi.c +2 -0
index 31f618a..1f850c9 100644
@@ -27,6 +27,8 @@
 #include <xen/interface/platform.h>
 #include <xen/xen.h>
 
+#include <asm/page.h>
+
 #include <asm/xen/hypercall.h>
 
 #define INIT_EFI_OP(name) \
Signature · 1 line
1.7.10.4
Applied
#1 lore raw
Quoted 4 lines · Daniel Kiper

I discovered that some needed stuff is defined/declared in headers which are not included directly. Currently it works but if somebody remove required headers from currently included headers then build will break. So, just in case directly include all needed headers.

Seems rather pointless, but harmless.

Applied to devel/for-linus-3.18

Thanks.

David

#2 lore raw
Quoted 9 lines · David Vrabel
Quoted 4 lines · Daniel Kiper

I discovered that some needed stuff is defined/declared in headers which are not included directly. Currently it works but if somebody remove required headers from currently included headers then build will break. So, just in case directly include all needed headers.

Seems rather pointless, but harmless.

Applied to devel/for-linus-3.18

Thanks.

Daniel

#3 lore raw
In reply to David Vrabel
Quoted 9 lines · David Vrabel
Quoted 4 lines · Daniel Kiper

I discovered that some needed stuff is defined/declared in headers which are not included directly. Currently it works but if somebody remove required headers from currently included headers then build will break. So, just in case directly include all needed headers.

Seems rather pointless, but harmless.

Applied to devel/for-linus-3.18

Thanks.

Daniel

Applied
#4 lore raw
In reply to Daniel Kiper
Quoted 4 lines · Daniel Kiper

I discovered that some needed stuff is defined/declared in headers which are not included directly. Currently it works but if somebody remove required headers from currently included headers then build will break. So, just in case directly include all needed headers.

Seems rather pointless, but harmless.

Applied to devel/for-linus-3.18

Thanks.

David