Skip to contentSkip to conversation

xen/balloon: Remove unused pr_fmt() macro

PATCH In review Daniel Kiper 2 participants 9 messages Sep 8, 2014 Xen hypervisor interface

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/balloon: Remove unused pr_fmt() macro

Remove unused pr_fmt() macro. Additionally, remove surplus empty lines which left after earlier various fixes and cleanups.

---
 drivers/xen/balloon.c |    5 -----
 1 file changed, 5 deletions(-)
drivers/xen/balloon.c +0 -5
index 5c660c7..08417b3 100644
@@ -36,8 +36,6 @@
  * IN THE SOFTWARE.
  */
 
-#define pr_fmt(fmt) "xen:" KBUILD_MODNAME ": " fmt
-
 #include <linux/cpu.h>
 #include <linux/kernel.h>
 #include <linux/sched.h>
@@ -84,7 +82,6 @@ enum bp_state {
 	BP_ECANCELED
 };
 
-
 static DEFINE_MUTEX(balloon_mutex);
 
 struct balloon_stats balloon_stats;
@@ -94,7 +91,6 @@ EXPORT_SYMBOL_GPL(balloon_stats);
 static xen_pfn_t frame_list[PAGE_SIZE / sizeof(unsigned long)];
 static DEFINE_PER_CPU(struct page *, balloon_scratch_page);
 
-
 /* List of ballooned pages, threaded through the mem_map array. */
 static LIST_HEAD(ballooned_pages);
 
@@ -616,7 +612,6 @@ static int alloc_balloon_scratch_page(int cpu)
 	return 0;
 }
 
-
 static int balloon_cpu_notify(struct notifier_block *self,
 				    unsigned long action, void *hcpu)
 {
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 2 lines · Daniel Kiper

Remove unused pr_fmt() macro. Additionally, remove surplus empty lines which left after earlier various fixes and cleanups.

A patch in the 3.17 queue uses this.

David

#2 lore raw
Quoted 5 lines · David Vrabel
Quoted 2 lines · Daniel Kiper

Remove unused pr_fmt() macro. Additionally, remove surplus empty lines which left after earlier various fixes and cleanups.

A patch in the 3.17 queue uses this.

Hmmm... Which one? I am not able to find anything relevant in xen/tip. Am I missing something?

Daniel

#3 lore raw
In reply to David Vrabel
Quoted 5 lines · David Vrabel
Quoted 2 lines · Daniel Kiper

Remove unused pr_fmt() macro. Additionally, remove surplus empty lines which left after earlier various fixes and cleanups.

A patch in the 3.17 queue uses this.

Hmmm... Which one? I am not able to find anything relevant in xen/tip. Am I missing something?

Daniel

#4 lore raw
Quoted 9 lines · Daniel Kiper
Quoted 5 lines · David Vrabel
Quoted 2 lines · Daniel Kiper

Remove unused pr_fmt() macro. Additionally, remove surplus empty lines which left after earlier various fixes and cleanups.

A patch in the 3.17 queue uses this.

Hmmm... Which one? I am not able to find anything relevant in xen/tip. Am I missing something?

The balloon driver already uses it. It is used in the pr_info() and pr_warn() etc. macros.

David

#5 lore raw
Quoted 6 lines · David Vrabel
Quoted 5 lines · Daniel Kiper
Quoted 4 lines · David Vrabel
Quoted 2 lines · Daniel Kiper

Remove unused pr_fmt() macro. Additionally, remove surplus empty lines which left after earlier various fixes and cleanups.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

A patch in the 3.17 queue uses this.

Hmmm... Which one? I am not able to find anything relevant in xen/tip. Am I missing something?

The balloon driver already uses it. It is used in the pr_info() and pr_warn() etc. macros.

Ahhh... OK, I see. We override default macro definition in include/linux/printk.h. So, forget about that patch. Sorry for confusion.

Daniel

#6 lore raw
In reply to David Vrabel
Quoted 6 lines · David Vrabel
Quoted 5 lines · Daniel Kiper
Quoted 4 lines · David Vrabel
Quoted 2 lines · Daniel Kiper

Remove unused pr_fmt() macro. Additionally, remove surplus empty lines which left after earlier various fixes and cleanups.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

A patch in the 3.17 queue uses this.

Hmmm... Which one? I am not able to find anything relevant in xen/tip. Am I missing something?

The balloon driver already uses it. It is used in the pr_info() and pr_warn() etc. macros.

Ahhh... OK, I see. We override default macro definition in include/linux/printk.h. So, forget about that patch. Sorry for confusion.

Daniel

#7 lore raw
In reply to Daniel Kiper
Quoted 9 lines · Daniel Kiper
Quoted 5 lines · David Vrabel
Quoted 2 lines · Daniel Kiper

Remove unused pr_fmt() macro. Additionally, remove surplus empty lines which left after earlier various fixes and cleanups.

A patch in the 3.17 queue uses this.

Hmmm... Which one? I am not able to find anything relevant in xen/tip. Am I missing something?

The balloon driver already uses it. It is used in the pr_info() and pr_warn() etc. macros.

David

#8 lore raw
In reply to Daniel Kiper
Quoted 2 lines · Daniel Kiper

Remove unused pr_fmt() macro. Additionally, remove surplus empty lines which left after earlier various fixes and cleanups.

A patch in the 3.17 queue uses this.

David