Skip to contentSkip to conversation

net: ethernet: arc: Don't free Rockchip resources before disconnect from phy

PATCH Applied Romain Perier 2 participants 2 messages Sep 10, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ethernet: arc: Don't free Rockchip resources before disconnect from phy

Free resources before being disconnected from phy and calling core driver is wrong and should not happen. It avoids a delay of 4-5s caused by the timeout of phy_disconnect().

---
 drivers/net/ethernet/arc/emac_rockchip.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/arc/emac_rockchip.c +2 -1
index 51d0585..c31c740 100644
@@ -202,12 +202,13 @@ static int emac_rockchip_remove(struct platform_device *pdev)
 	struct rockchip_priv_data *priv = netdev_priv(ndev);
 	int err;
 
+	err = arc_emac_remove(ndev);
+
 	clk_disable_unprepare(priv->refclk);
 
 	if (priv->regulator)
 		regulator_disable(priv->regulator);
 
-	err = arc_emac_remove(ndev);
 	free_netdev(ndev);
 	return err;
 }
Signature · 1 line
1.9.1
maintainer Applied
#1 lore raw

From: Romain Perier <[email protected]>
Date: Wed, 10 Sep 2014 07:51:13 +0000

Quoted 5 lines

Free resources before being disconnected from phy and calling core driver is wrong and should not happen. It avoids a delay of 4-5s caused by the timeout of phy_disconnect().

Applied, thanks.