Skip to contentSkip to conversation

ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC

PATCH New klightspeed at killerwolves.net 2 participants 4 messages Sep 10, 2014 – Sep 14, 2014

Subsystems (2)
Device tree bindings Memory technology devices (MTD)
lore
Share & tools
lore

klightspeed at killerwolves.net

author
#0 lore raw

PATCH 1/1 ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC

The bootloader on the Netgear ReadyNAS RN102 uses Hardware BCH ECC (strength = 4), while the pxa3xx NAND driver by default uses Hamming ECC (strength = 1).

This patch changes the ECC mode on these machines to match that of the bootloader and of the stock firmware. That way, it is now possible to update the kernel from userland (e.g. using standard tools from mtd-utils package); u-boot will happily load and boot it.

Fixes 92beaccd8b49 ("ARM: mvebu: Enable NAND controller in ReadyNAS 102 .dts file")
Signed-off-by Ben Peddell <[email protected]>
Acked-by Ezequiel Garcia <[email protected]>
Tested-by Arnaud Ebalard <[email protected]>
---
 arch/arm/boot/dts/armada-370-netgear-rn102.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/armada-370-netgear-rn102.dts +4 -0
index d6d572e..285524f 100644
@@ -143,6 +143,10 @@
 				marvell,nand-enable-arbiter;
 				nand-on-flash-bbt;
 
+				/* Use Hardware BCH ECC */
+				nand-ecc-strength = <4>;
+				nand-ecc-step-size = <512>;
+
 				partition at 0 {
 					label = "u-boot";
 					reg = <0x0000000 0x180000>;  /* 1.5MB */
Signature · 1 line
1.8.5.5
#1 lore raw

PATCH 1/1 ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC

Quoted 10 lines · klightspeed at killerwolves.net

The bootloader on the Netgear ReadyNAS RN102 uses Hardware BCH ECC (strength = 4), while the pxa3xx NAND driver by default uses Hamming ECC (strength = 1).

This patch changes the ECC mode on these machines to match that of the bootloader and of the stock firmware. That way, it is now possible to update the kernel from userland (e.g. using standard tools from mtd-utils package); u-boot will happily load and boot it.

Quoted 7 lines
Fixes 92beaccd8b49 ("ARM: mvebu: Enable NAND controller in ReadyNAS 102 .dts file")
Signed-off-by Ben Peddell <[email protected]>
Acked-by Ezequiel Garcia <[email protected]>
Tested-by Arnaud Ebalard <[email protected]>
---
 arch/arm/boot/dts/armada-370-netgear-rn102.dts | 4 ++++
 1 file changed, 4 insertions(+)

I've already applied this the mvebu/fixes:

500abb6ccb9e ARM: mvebu: Netgear RN2120: Use Hardware BCH ECC

thx,

Jason.

author
#2 lore raw

PATCH 1/1 ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC

Quoted 19 lines · Jason Cooper
Quoted 10 lines · klightspeed at killerwolves.net

The bootloader on the Netgear ReadyNAS RN102 uses Hardware BCH ECC (strength = 4), while the pxa3xx NAND driver by default uses Hamming ECC (strength = 1).

This patch changes the ECC mode on these machines to match that of the bootloader and of the stock firmware. That way, it is now possible to update the kernel from userland (e.g. using standard tools from mtd-utils package); u-boot will happily load and boot it.

Quoted 7 lines
Fixes 92beaccd8b49 ("ARM: mvebu: Enable NAND controller in ReadyNAS 102 .dts file")
Signed-off-by Ben Peddell <[email protected]>
Acked-by Ezequiel Garcia <[email protected]>
Tested-by Arnaud Ebalard <[email protected]>
---
 arch/arm/boot/dts/armada-370-netgear-rn102.dts | 4 ++++
 1 file changed, 4 insertions(+)
Quoted 3 lines

I've already applied this the mvebu/fixes:

500abb6ccb9e ARM: mvebu: Netgear RN2120: Use Hardware BCH ECC

That patch only affects arch/arm/boot/dts/armada-xp-netgear-rn2120.dts

The patch I posted affects arch/arm/boot/dts/armada-370-netgear-rn102.dts

#3 lore raw

PATCH 1/1 ARM: MVEBU: Netgear RN102: Use Hardware BCH ECC

Quoted 20 lines · Ben Peddell
Quoted 19 lines · Jason Cooper
Quoted 17 lines · klightspeed at killerwolves.net

The bootloader on the Netgear ReadyNAS RN102 uses Hardware BCH ECC (strength = 4), while the pxa3xx NAND driver by default uses Hamming ECC (strength = 1).

This patch changes the ECC mode on these machines to match that of the bootloader and of the stock firmware. That way, it is now possible to update the kernel from userland (e.g. using standard tools from mtd-utils package); u-boot will happily load and boot it.

Fixes 92beaccd8b49 ("ARM: mvebu: Enable NAND controller in ReadyNAS 102 .dts file")
Signed-off-by Ben Peddell <[email protected]>
Acked-by Ezequiel Garcia <[email protected]>
Tested-by Arnaud Ebalard <[email protected]>
---
 arch/arm/boot/dts/armada-370-netgear-rn102.dts | 4 ++++
 1 file changed, 4 insertions(+)
Quoted 7 lines
Quoted 3 lines

I've already applied this the mvebu/fixes:

500abb6ccb9e ARM: mvebu: Netgear RN2120: Use Hardware BCH ECC

That patch only affects arch/arm/boot/dts/armada-xp-netgear-rn2120.dts

The patch I posted affects arch/arm/boot/dts/armada-370-netgear-rn102.dts

Gah! You're right. Applied to mvebu/fixes and Cc'd the stable v3.14+

thx,

Jason.