iwlwifi: mvm: set the TX disable bit when doing a chanctx switch

Hello Luciano Coelho,

The patch 0ce04ce797f8: "iwlwifi: mvm: set the TX disable bit when doing a chanctx switch" from May 8, 2014, leads to the following static checker warning:

	drivers/net/wireless/iwlwifi/mvm/mac80211.c:2768 __iwl_mvm_assign_vif_chanctx()
	warn: missing error code here? 'iwl_mvm_sta_from_staid_protected()' failed. 'ret' = '0'

drivers/net/wireless/iwlwifi/mvm/mac80211.c
2761 if (vif->csa_active && vif->type == NL80211_IFTYPE_STATION) {
2762 struct iwl_mvm_sta *mvmsta;
2763
2764 mvmsta = iwl_mvm_sta_from_staid_protected(mvm,
2765 mvmvif->ap_sta_id);
2766
2767 if (WARN_ON(!mvmsta))
2768 goto out;

Did you want to set an error code here? I don't know the code well enough to say.

  2769  
  2770                  /* TODO: only re-enable after the first beacon */
  2771                  iwl_mvm_sta_modify_disable_tx(mvm, mvmsta, false);
  2772          }
  2773  
  2774          goto out;
  2775  
  2776  out_remove_binding:
  2777          iwl_mvm_binding_remove_vif(mvm, vif);
  2778          iwl_mvm_power_update_mac(mvm);
  2779  out:
  2780          if (ret)
  2781                  mvmvif->phy_ctxt = NULL;
  2782          return ret;
  2783  }

regards,
dan carpenter

SGkgRGFuLA0KDQpTb3JyeSBmb3IgdGhlIGxhdGUgcmVwbHkuDQoNCk9uIFR1ZSwgMjAxNC0wOS0w OSBhdCAxMjo0MCArMDMwMCwgRGFuIENhcnBlbnRlciB3cm90ZToNCj4gSGVsbG8gTHVjaWFubyBD b2VsaG8sDQo+IA0KPiBUaGUgcGF0Y2ggMGNlMDRjZTc5N2Y4OiAiaXdsd2lmaTogbXZtOiBzZXQg dGhlIFRYIGRpc2FibGUgYml0IHdoZW4NCj4gZG9pbmcgYSBjaGFuY3R4IHN3aXRjaCIgZnJvbSBN YXkgOCwgMjAxNCwgbGVhZHMgdG8gdGhlIGZvbGxvd2luZw0KPiBzdGF0aWMgY2hlY2tlciB3YXJu aW5nOg0KPiANCj4gCWRyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdpZmkvbXZtL21hYzgwMjExLmM6 Mjc2OCBfX2l3bF9tdm1fYXNzaWduX3ZpZl9jaGFuY3R4KCkNCj4gCXdhcm46IG1pc3NpbmcgZXJy b3IgY29kZSBoZXJlPyAnaXdsX212bV9zdGFfZnJvbV9zdGFpZF9wcm90ZWN0ZWQoKScgZmFpbGVk LiAncmV0JyA9ICcwJw0KPiANCj4gZHJpdmVycy9uZXQvd2lyZWxlc3MvaXdsd2lmaS9tdm0vbWFj ODAyMTEuYw0KPiAgIDI3NjEgICAgICAgICAgaWYgKHZpZi0+Y3NhX2FjdGl2ZSAmJiB2aWYtPnR5 cGUgPT0gTkw4MDIxMV9JRlRZUEVfU1RBVElPTikgew0KPiAgIDI3NjIgICAgICAgICAgICAgICAg ICBzdHJ1Y3QgaXdsX212bV9zdGEgKm12bXN0YTsNCj4gICAyNzYzICANCj4gICAyNzY0ICAgICAg ICAgICAgICAgICAgbXZtc3RhID0gaXdsX212bV9zdGFfZnJvbV9zdGFpZF9wcm90ZWN0ZWQobXZt LA0KPiAgIDI3NjUgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBtdm12aWYtPmFwX3N0YV9pZCk7DQo+ICAgMjc2NiAgDQo+ICAgMjc2NyAg ICAgICAgICAgICAgICAgIGlmIChXQVJOX09OKCFtdm1zdGEpKQ0KPiAgIDI3NjggICAgICAgICAg ICAgICAgICAgICAgICAgIGdvdG8gb3V0Ow0KPiANCj4gRGlkIHlvdSB3YW50IHRvIHNldCBhbiBl cnJvciBjb2RlIGhlcmU/ICBJIGRvbid0IGtub3cgdGhlIGNvZGUgd2VsbA0KPiBlbm91Z2ggdG8g c2F5Lg0KDQpHb29kIGNhdGNoIQ0KDQpUaGlzIGdldHMgZml4ZWQgaW4gYW5vdGhlciBwYXRjaCBJ IGltcGxlbWVudGVkICh0aGF0IEVtbWFudWVsIGlzDQpwcm9iYWJseSBnb2luZyB0byBzZW5kIG91 dCBzb29uKSB3aGVyZSBJIG1vdmUgdGhlIGNvZGUgdG8gYW5vdGhlcg0KZnVuY3Rpb24uDQoNClNp bmNlIHRoaXMgc2hvdWxkIG5vdCByZWFsbHkgaGFwcGVuIGluIG5vcm1hbCBjYXNlcywgYW5kIHNp bmNlIHRoaXMgd2lsbA0KYmUgZml4ZWQgdmVyeSBzb29uIGFueXdheSwgd2UgY291bGQgcHJvYmFi bHkgbGVhdmUgdGhpcyBwYXRjaCBhcyBpdCBpcy4NCg0KVGhlIHBhdGNoIHRoYXQgZml4ZXMgdGhp cyBpcyBjYWxsZWQgIml3bHdpZmk6IG12bTogZmluYWxpemUgb24NCnBvc3Rfc3dpdGNoIGluc3Rl YWQgb2YgdW5hc3NpZ24iIGFuZCB5b3Ugc2hvdWxkIHNlZSBpdCBjb21pbmcgc29vbiB0byBhDQp0 aGVhdGVyIG5lYXIgeW91LiA7KQ0KDQpUaGFua3MgZm9yIHJ1bm5pbmcgeW91ciBjb29sIHNjcmlw dHMhIDopDQoNCi0tDQpDaGVlcnMsDQpMdWNhLg0K