Skip to contentSkip to conversation

drivers: net: b44: Fix typo in returning multicast stats

PATCH RESEND Applied Mark Einon 2 participants 2 messages Sep 11, 2014 – Sep 12, 2014

Subsystems (3)
lore
Share & tools
lore

Mark Einon

author
#0 lore raw

PATCH RESEND 1/1 drivers: net: b44: Fix typo in returning multicast stats

nstat->multicast refers to received packets, not transmitted as is returned here. Change it so that received packet stats are given.

---

changing to send to alternate address for Gary Zambrano, maintainers entry bounced.

 drivers/net/ethernet/broadcom/b44.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/broadcom/b44.c +1 -1
index 4a7028d..d588136 100644
@@ -1697,7 +1697,7 @@ static struct rtnl_link_stats64 *b44_get_stats64(struct net_device *dev,
 				     hwstat->tx_underruns +
 				     hwstat->tx_excessive_cols +
 				     hwstat->tx_late_cols);
-		nstat->multicast  = hwstat->tx_multicast_pkts;
+		nstat->multicast  = hwstat->rx_multicast_pkts;
 		nstat->collisions = hwstat->tx_total_cols;
 
 		nstat->rx_length_errors = (hwstat->rx_oversize_pkts +
Signature · 1 line
2.1.0
maintainer Applied
#1 lore raw

From: Mark Einon <[email protected]>
Date: Thu, 11 Sep 2014 23:19:49 +0100

Quoted 5 lines

nstat->multicast refers to received packets, not transmitted as is returned here. Change it so that received packet stats are given.

Applied, thank you.