mx6sxsabresd: Staticize i2c_pad_info1
PATCH 1/2 mx6sxsabresd: Staticize i2c_pad_info1
From: Fabio Estevam <[email protected]>
i2c_pad_info1 is only used locally, so it can be made static.
Fix the following sparse warning:
board/freescale/mx6sxsabresd/mx6sxsabresd.c:160:22: warning: symbol 'i2c_pad_info1' was not declared. Should it be static?
--- board/freescale/mx6sxsabresd/mx6sxsabresd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/mx6sxsabresd/mx6sxsabresd.c +1 -1
@@ -157,7 +157,7 @@ int board_eth_init(bd_t *bis)#define PC MUX_PAD_CTRL(I2C_PAD_CTRL)/* I2C1 for PMIC */ -struct i2c_pads_info i2c_pad_info1 = { +static struct i2c_pads_info i2c_pad_info1 = { .scl = { .i2c_mode =MX6_PAD_GPIO1_IO00__I2C1_SCL |PC , .gpio_mode =MX6_PAD_GPIO1_IO00__GPIO1_IO_0 |PC ,
Signature · 1 line
1.9.1
PATCH 2/2 mx6qsabreauto: Staticize when possible
From: Fabio Estevam <[email protected]>
Turn all local symbols into static in order to make sparse happy.
--- board/freescale/mx6qsabreauto/mx6qsabreauto.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
board/freescale/mx6qsabreauto/mx6qsabreauto.c +8 -8
@@ -50,12 +50,12 @@ int dram_init(void)return 0 ; } -iomux_v3_cfg_t const uart4_pads[] = { +static iomux_v3_cfg_t const uart4_pads[] = {MX6_PAD_KEY_COL0__UART4_TX_DATA |MUX_PAD_CTRL (UART_PAD_CTRL ),MX6_PAD_KEY_ROW0__UART4_RX_DATA |MUX_PAD_CTRL (UART_PAD_CTRL ), }; -iomux_v3_cfg_t const enet_pads[] = { +static iomux_v3_cfg_t const enet_pads[] = {MX6_PAD_KEY_COL1__ENET_MDIO |MUX_PAD_CTRL (ENET_PAD_CTRL ),MX6_PAD_KEY_COL2__ENET_MDC |MUX_PAD_CTRL (ENET_PAD_CTRL ),MX6_PAD_RGMII_TXC__RGMII_TXC |MUX_PAD_CTRL (ENET_PAD_CTRL ),
@@ -74,7 +74,7 @@ iomux_v3_cfg_t const enet_pads[] = { };/* I2C2 PMIC, iPod, Tuner, Codec, Touch, HDMI EDID, MIPI CSI2 card */ -struct i2c_pads_info i2c_pad_info1 = { +static struct i2c_pads_info i2c_pad_info1 = { .scl = { .i2c_mode =MX6_PAD_EIM_EB2__I2C2_SCL |PC , .gpio_mode =MX6_PAD_EIM_EB2__GPIO2_IO30 |PC ,
@@ -91,7 +91,7 @@ struct i2c_pads_info i2c_pad_info1 = {* I2C3 MLB, Port Expanders (A, B, C), Video ADC, Light Sensor, * Compass Sensor, Accelerometer, Res Touch */ -struct i2c_pads_info i2c_pad_info2 = { +static struct i2c_pads_info i2c_pad_info2 = { .scl = { .i2c_mode =MX6_PAD_GPIO_3__I2C3_SCL |PC , .gpio_mode =MX6_PAD_GPIO_3__GPIO1_IO03 |PC ,
@@ -104,11 +104,11 @@ struct i2c_pads_info i2c_pad_info2 = { } }; -iomux_v3_cfg_t const i2c3_pads[] = { +static iomux_v3_cfg_t const i2c3_pads[] = {MX6_PAD_EIM_A24__GPIO5_IO04 |MUX_PAD_CTRL (NO_PAD_CTRL ), }; -iomux_v3_cfg_t const port_exp[] = { +static iomux_v3_cfg_t const port_exp[] = {MX6_PAD_SD2_DAT0__GPIO1_IO15 |MUX_PAD_CTRL (NO_PAD_CTRL ), };
@@ -117,7 +117,7 @@ static void setup_iomux_enet(void)imx_iomux_v3_setup_multiple_pads (enet_pads,ARRAY_SIZE (enet_pads)); } -iomux_v3_cfg_t const usdhc3_pads[] = { +static iomux_v3_cfg_t const usdhc3_pads[] = {MX6_PAD_SD3_CLK__SD3_CLK |MUX_PAD_CTRL (USDHC_PAD_CTRL ),MX6_PAD_SD3_CMD__SD3_CMD |MUX_PAD_CTRL (USDHC_PAD_CTRL ),MX6_PAD_SD3_DAT0__SD3_DATA0 |MUX_PAD_CTRL (USDHC_PAD_CTRL ),
@@ -138,7 +138,7 @@ static void setup_iomux_uart(void) }#ifdef CONFIG_FSL_ESDHC -struct fsl_esdhc_cfg usdhc_cfg[1 ] = { +static struct fsl_esdhc_cfg usdhc_cfg[1 ] = { {USDHC3_BASE_ADDR }, };
Signature · 1 line
1.9.1
PATCH 2/2 mx6qsabreauto: Staticize when possible
Quoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Turn all local symbols into static in order to make sparse happy.
Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/2 mx6sxsabresd: Staticize i2c_pad_info1
In reply to Fabio EstevamQuoted 10 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
i2c_pad_info1is only used locally, so it can be made static.Fix the following sparse warning:
board/freescale/mx6sxsabresd/mx6sxsabresd.c:160:22: warning: symbol 'i2c_pad_info1' was not declared. Should it be static?Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================