Skip to contentSkip to conversation

Staging: android: ion: fix coding style

PATCH In review Sorin Facaoaru 2 participants 2 messages Sep 13, 2014 – Sep 14, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: android: ion: fix coding style

- add line after declaration
- remove return statement in empty void function

---
 drivers/staging/android/ion/ion.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/android/ion/ion.c +1 -1
index 2703609..56604f4 100644
@@ -805,6 +805,7 @@ struct ion_client *ion_client_create(struct ion_device *dev,
 						client, &debug_client_fops);
 	if (!client->debug_root) {
 		char buf[256], *path;
+
 		path = dentry_path(dev->clients_debug_root, buf, 256);
 		pr_err("Failed to create client debugfs at %s/%s\n",
 			path, client->display_name);
@@ -1056,7 +1057,6 @@ static void *ion_dma_buf_kmap(struct dma_buf *dmabuf, unsigned long offset)
 static void ion_dma_buf_kunmap(struct dma_buf *dmabuf, unsigned long offset,
 			       void *ptr)
 {
-	return;
 }
 
 static int ion_dma_buf_begin_cpu_access(struct dma_buf *dmabuf, size_t start,
Signature · 1 line
1.9.1
#1 lore raw

First off, thanks for the patches.

But, they need some tweaks before I can accept them.

You sent a bunch of patches, all with the same exact subject, with no hint of which order they should be applied in, or what exactly they do.

Quoted 2 lines · Sorin Facaoaru

- add line after declaration
- remove return statement in empty void function

For this patch, you are doing two different things, in the same file, that should be two different patches. But you might be able to merge them with your other patches.

Make your patches do "just one thing" from a logical point of view.

For example, you could have a patch titled:
[PATCH 01/05] staging: android: ion: remove unneeded returns

that just removed the unneeded return statemnents for all of the ion files.

Then 4 other patches that do 4 other "logical" things, telling me what order to apply them in.

Can you please fix up all of your recent submissions and resend in that format?

Quoted 1 line

You have trailing whitespace here :(

thanks,

greg k-h