Skip to contentSkip to conversation

arm/virt: mark timer in fdt as armv8-compatible

RFC In review [email protected] 2 participants 4 messages Sep 15, 2014 – Sep 26, 2014

lore
Share & tools
lore
#0 lore raw

RFC 1/1 arm/virt: mark timer in fdt as armv8-compatible

From: Claudio Fontana <[email protected]>

---
 hw/arm/virt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Is the timer armv8-compatible? I think it is, at least the virtual timer seems to work as expected.

When looking up the timer information in the guest btw, where the guest is running AArch64, does it make sense to look for an armv8-timer compatible string?
Or is the "/timer" path standard enough that I should look for the node using that fixed path instead?

Thanks,

Claudio

hw/arm/virt.c +1 -1
index d6fffc7..8dbaf9d 100644
@@ -245,7 +245,7 @@ static void fdt_add_timer_nodes(const VirtBoardInfo *vbi)
 
     qemu_fdt_add_subnode(vbi->fdt, "/timer");
     qemu_fdt_setprop_string(vbi->fdt, "/timer",
-                                "compatible", "arm,armv7-timer");
+                                "compatible", "arm,armv7-timer,armv8-timer");
     qemu_fdt_setprop_cells(vbi->fdt, "/timer", "interrupts",
                                GIC_FDT_IRQ_TYPE_PPI, 13, irqflags,
                                GIC_FDT_IRQ_TYPE_PPI, 14, irqflags,
Signature · 1 line
1.8.5.3
#1 lore raw

This is obviously wrong, we have to put a \0 to separate the two options.

But thee question remains, should we mark that as arm,armv8-timer compatible?

Thanks,

Claudio

Quoted 36 lines · On 15 September 2014 10:14, <[email protected]> wrote:

From: Claudio Fontana <[email protected]>

---
 hw/arm/virt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Is the timer armv8-compatible? I think it is, at least the virtual timer seems to work as expected.

When looking up the timer information in the guest btw, where the guest is running AArch64, does it make sense to look for an armv8-timer compatible string?
Or is the "/timer" path standard enough that I should look for the node using that fixed path instead?

Thanks,

Claudio

hw/arm/virt.c +1 -2
index d6fffc7..8dbaf9d 100644
@@ -245,7 +245,7 @@ static void fdt_add_timer_nodes(const VirtBoardInfo *vbi)
 
     qemu_fdt_add_subnode(vbi->fdt, "/timer");
     qemu_fdt_setprop_string(vbi->fdt, "/timer",
-                                "compatible", "arm,armv7-timer");
+                                "compatible", "arm,armv7-timer,armv8-timer");
     qemu_fdt_setprop_cells(vbi->fdt, "/timer", "interrupts",
                                GIC_FDT_IRQ_TYPE_PPI, 13, irqflags,
                                GIC_FDT_IRQ_TYPE_PPI, 14, irqflags,
--

1.8.5.3

#2 lore raw
Quoted 3 lines · Claudio Fontana

This is obviously wrong, we have to put a \0 to separate the two options.

But thee question remains, should we mark that as arm,armv8-timer compatible?

I think we should, but only if the CPU we're presenting to the guest is a v8 CPU (ie the ARM_FEATURE_V8 bit is set for the CPU).

-- PMM

#3 lore raw
Quoted 10 lines · Peter Maydell
Quoted 3 lines · Claudio Fontana

This is obviously wrong, we have to put a \0 to separate the two options.

But thee question remains, should we mark that as arm,armv8-timer compatible?

I think we should, but only if the CPU we're presenting to the guest is a v8 CPU (ie the ARM_FEATURE_V8 bit is set for the CPU).

-- PMM

Ok I am sending a patch for this momentarily.

Claudio