Skip to contentSkip to conversation

openvmtools: disable -Werror

PATCH New Karoly Kasza 3 participants 3 messages Sep 15, 2014 – Sep 21, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 openvmtools: disable -Werror

Disable the mandatory flag -Werror in configure.ac. This also makes -Wno-deprecated-declarations flag unnecessary.

---
 .../openvmtools/openvmtools-04-no_cflags_werror.patch |   17 +++++++++++++++++
 package/openvmtools/openvmtools.mk                    |    4 ----
 2 files changed, 17 insertions(+), 4 deletions(-)
 create mode 100644 package/openvmtools/openvmtools-04-no_cflags_werror.patch
package/openvmtools/openvmtools-04-no_cflags_werror.patch new file +17 -0
new file mode 100644
index 0000000..96bd355
@@ -0,0 +1,17 @@
+configure.ac: disable -Werror
+
+Disable the mandatory flag -Werror in configure.ac.
+
+Signed-off-by: Karoly Kasza <[email protected]>
+
+--- open-vm-tools-9.4.6-1770165.orig/configure.ac	2014-07-02 00:21:14.000000000 +0200
++++ open-vm-tools-9.4.6-1770165/configure.ac	2014-09-15 16:03:47.565900402 +0200
+@@ -832,7 +832,7 @@
+ 
+ ### General flags / actions
+ CFLAGS="$CFLAGS -Wall"
+-CFLAGS="$CFLAGS -Werror"
++# CFLAGS="$CFLAGS -Werror"
+ 
+ # -Wno-unknown-pragmas is due to gcc not understanding '#pragma ident' in Xlib.h on OpenSolaris.
+ for TEST_CFLAG in -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing \
package/openvmtools/openvmtools.mk +0 -4
index 6361d6b..9191643 100644
@@ -13,10 +13,6 @@ OPENVMTOOLS_LICENSE_FILES = COPYING
 # See http://sourceforge.net/p/open-vm-tools/mailman/message/32550385/
 OPENVMTOOLS_AUTORECONF = YES
 OPENVMTOOLS_CONF_OPT = --without-icu --without-x --without-gtk2 --without-gtkmm --without-kernel-modules
-# -Wno-deprecated-declarations is a workaround for a bug in open-vm-tools
-# See http://sourceforge.net/p/open-vm-tools/mailman/message/31473171/
-OPENVMTOOLS_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -Wno-deprecated-declarations"
-
 OPENVMTOOLS_DEPENDENCIES = libglib2
 
 # When libfuse is available, openvmtools can build vmblock-fuse, so
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 openvmtools: disable -Werror

Karoly, All,

On 2014-09-15 16:56 +0200, Karoly Kasza spake thusly:

Quoted 4 lines

Disable the mandatory flag -Werror in configure.ac. This also makes -Wno-deprecated-declarations flag unnecessary.

I guess this is fixing a bunch of autobuild errors; these should have been referenced in the commit log, as such:

Fixes:

    http://autobuild.buildroot.net/results/440/4400abc17115d0f5eb65c4eb012f11766cbe5a56/
    http://autobuild.buildroot.net/results/02b/02b24a012dbc76e366c10d3758978eba5e597499/
    [...]

(No need to put them all, just a few; the [...] means there are a lot more, hence it is important to apply this patch.)

Regards,
Yann E. MORIN.

Quoted 47 lines
---
 .../openvmtools/openvmtools-04-no_cflags_werror.patch |   17 +++++++++++++++++
 package/openvmtools/openvmtools.mk                    |    4 ----
 2 files changed, 17 insertions(+), 4 deletions(-)
 create mode 100644 package/openvmtools/openvmtools-04-no_cflags_werror.patch
package/openvmtools/openvmtools-04-no_cflags_werror.patch new file +17 -0
new file mode 100644
index 0000000..96bd355
@@ -0,0 +1,17 @@
+configure.ac: disable -Werror
+
+Disable the mandatory flag -Werror in configure.ac.
+
+Signed-off-by: Karoly Kasza <[email protected]>
+
+--- open-vm-tools-9.4.6-1770165.orig/configure.ac	2014-07-02 00:21:14.000000000 +0200
++++ open-vm-tools-9.4.6-1770165/configure.ac	2014-09-15 16:03:47.565900402 +0200
+@@ -832,7 +832,7 @@
+ 
+ ### General flags / actions
+ CFLAGS="$CFLAGS -Wall"
+-CFLAGS="$CFLAGS -Werror"
++# CFLAGS="$CFLAGS -Werror"
+ 
+ # -Wno-unknown-pragmas is due to gcc not understanding '#pragma ident' in Xlib.h on OpenSolaris.
+ for TEST_CFLAG in -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing \
package/openvmtools/openvmtools.mk +0 -4
index 6361d6b..9191643 100644
@@ -13,10 +13,6 @@ OPENVMTOOLS_LICENSE_FILES = COPYING
 # See http://sourceforge.net/p/open-vm-tools/mailman/message/32550385/
 OPENVMTOOLS_AUTORECONF = YES
 OPENVMTOOLS_CONF_OPT = --without-icu --without-x --without-gtk2 --without-gtkmm --without-kernel-modules
-# -Wno-deprecated-declarations is a workaround for a bug in open-vm-tools
-# See http://sourceforge.net/p/open-vm-tools/mailman/message/31473171/
-OPENVMTOOLS_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -Wno-deprecated-declarations"
-
 OPENVMTOOLS_DEPENDENCIES = libglib2
 
 # When libfuse is available, openvmtools can build vmblock-fuse, so
Signature · 1 line
1.7.10.4
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 openvmtools: disable -Werror

In reply to Karoly Kasza

Dear Karoly Kasza,

Quoted 9 lines · Karoly Kasza

Disable the mandatory flag -Werror in configure.ac. This also makes -Wno-deprecated-declarations flag unnecessary.

---
 .../openvmtools/openvmtools-04-no_cflags_werror.patch |   17 +++++++++++++++++
 package/openvmtools/openvmtools.mk                    |    4 ----
 2 files changed, 17 insertions(+), 4 deletions(-)
 create mode 100644 package/openvmtools/openvmtools-04-no_cflags_werror.patch

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com