Skip to contentSkip to conversation

Makefile: enable Werror=implicit-function-declaration

PATCH In review Lucas Stach 2 participants 2 messages Sep 15, 2014 – Sep 16, 2014 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: enable Werror=implicit-function-declaration

This should prevent us from ever again missing an failure similar to that one fixed in ee3254569dab (EFI: add missing include) by throwing a build error.

---
 Makefile | 1 +
 1 file changed, 1 insertion(+)
Makefile +1 -0
index b059c3a00eaa..90b2b6368554 100644
@@ -300,6 +300,7 @@ LINUXINCLUDE    := -Iinclude -I$(srctree)/dts/include \
 CPPFLAGS        := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builtin -ffreestanding
 
 CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
+                   -Werror=implicit-function-declaration \
                    -fno-strict-aliasing -fno-common -Os -pipe
 AFLAGS          := -D__ASSEMBLY__
 
Signature · 7 lines
1.9.3


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw
Quoted 5 lines · Lucas Stach

This should prevent us from ever again missing an failure similar to that one fixed in ee3254569dab (EFI: add missing include) by throwing a build error.

Nice. I wonder why I never did that earlier. Applied, thanks

Sascha

Quoted 25 lines
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)
Makefile +1 -0
index b059c3a00eaa..90b2b6368554 100644
@@ -300,6 +300,7 @@ LINUXINCLUDE    := -Iinclude -I$(srctree)/dts/include \
 CPPFLAGS        := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builtin -ffreestanding
 
 CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
+                   -Werror=implicit-function-declaration \
                    -fno-strict-aliasing -fno-common -Os -pipe
 AFLAGS          := -D__ASSEMBLY__
 
Signature · 7 lines
1.9.3


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox