can: at91_can: prepare and unprepare the clock
Subsystems (2)
PATCH v2 1/1 can: at91_can: prepare and unprepare the clock
Make the driver work with the common clock framework.
Signed-off-by David Dueck <[email protected]>
Signed-off-by Anthony Harivel <[email protected]>
---
Changes since v1:
- improve commit message
- check return value of clk_prepare_enable
drivers/net/can/at91_can.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/net/can/at91_can.c +5 -3
@@ -1123,7 +1123,9 @@ static int at91_open(struct net_device *dev)struct at91_priv *priv =netdev_priv (dev);int err; -clk_enable (priv->clk); + err =clk_prepare_enable (priv->clk); +if (err) +return err;/* check or determine and set bittime */ err =open_candev (dev);
@@ -1149,7 +1151,7 @@ static int at91_open(struct net_device *dev) out_close:close_candev (dev); out: -clk_disable (priv->clk); +clk_disable_unprepare (priv->clk);return err; }
@@ -1166,7 +1168,7 @@ static int at91_close(struct net_device *dev)at91_chip_stop (dev,CAN_STATE_STOPPED );free_irq (dev->irq, dev); -clk_disable (priv->clk); +clk_disable_unprepare (priv->clk);close_candev (dev);
Signature · 1 line
2.1.0
PATCH v2 1/1 can: at91_can: prepare and unprepare the clock
Quoted 4 lines · On Wed, 17 Sep 2014 14:26:48 +0200 David Dueck <[email protected]>…
Make the driver work with the common clock framework.
Signed-off-by David Dueck <[email protected]>Signed-off-by Anthony Harivel <[email protected]>
Acked-by Boris Brezillon <[email protected]>
Quoted 41 lines
---
Changes since v1:
- improve commit message
- check return value ofclk_prepare_enabledrivers/net/can/at91_can.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)drivers/net/can/at91_can.c +5
-3@@ -1123,7 +1123,9 @@ static int at91_open(struct net_device *dev)struct at91_priv *priv =netdev_priv (dev);int err; -clk_enable (priv->clk); + err =clk_prepare_enable (priv->clk); +if (err) +return err;/* check or determine and set bittime */ err =open_candev (dev);@@ -1149,7 +1151,7 @@ static int at91_open(struct net_device *dev) out_close:close_candev (dev); out: -clk_disable (priv->clk); +clk_disable_unprepare (priv->clk);return err; }@@ -1166,7 +1168,7 @@ static int at91_close(struct net_device *dev)at91_chip_stop (dev,CAN_STATE_STOPPED );free_irq (dev->irq, dev); -clk_disable (priv->clk); +clk_disable_unprepare (priv->clk);close_candev (dev);
Signature · 3 lines
Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Marc Kleine-Budde
maintainerPATCH v2 1/1 can: at91_can: prepare and unprepare the clock
In reply to David DueckQuoted 4 lines · David Dueck
Make the driver work with the common clock framework.
Signed-off-by David Dueck <[email protected]>Signed-off-by Anthony Harivel <[email protected]>
Added with a some more prose commit message to the linux-can tree.
Thanks,
Marc
Signature · 12 lines
Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140917/3fc1801a/attachment.sig>