Skip to contentSkip to conversation

mfd: twl4030-power: support ti,system-power-controller

PATCH Applied Nishanth Menon 3 participants 8 messages Sep 17, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover mfd: twl4030-power: support ti,system-power-controller

This series adds ti,system-power-controller to Documentation and the driver seperately as per maintainer preference.

Based on v3.17-rc1

Changes since V1: update in documentation, picked up Tony's ack for patch #2.

V1: http://marc.info/?l=devicetree&m=140977126218800&w=2

Nishanth Menon (2):
Documentation: devicetree: mfd: twl4030-power: Use the standard
'ti,system-power-controller' to mark power control
mfd: twl4030-power: use 'ti,system-power-controller' as alternative
way to support system power off

 .../devicetree/bindings/mfd/twl4030-power.txt      |    9 +++++++--
 drivers/mfd/twl4030-power.c                        |    3 +++
 2 files changed, 10 insertions(+), 2 deletions(-)
Signature · 6 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw

PATCH v2 1/2 Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control

ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style.

So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system.

---

V2: picked up documentation suggestion from Sebastien
V1: https://patchwork.kernel.org/patch/4836381/

 .../devicetree/bindings/mfd/twl4030-power.txt      |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/mfd/twl4030-power.txt +7 -2
index b9ee7b9..a7390c7 100644
@@ -23,8 +23,13 @@ down during off-idle. Note that this does not work on all boards
 depending on how the external oscillator is wired.
 
 Optional properties:
-- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or
-		   SLEEP-to-OFF transition when the system poweroffs.
+
+- ti,system-power-controller: This indicates that TWL4030 is the
+  power supply master of the system. With this flag, the chip will
+  initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
+  system poweroffs.
+
+- ti,use_poweroff: Deprecated name for ti,system-power-controller
 
 Example:
 &i2c1 {
Signature · 6 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw

Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control

Quoted 5 lines · Nishanth Menon

ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style.

Quoted 8 lines

So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system.

---

V2: picked up documentation suggestion from Sebastien

It would be good to get Sebastian's Ack.

Quoted 25 lines

V1: https://patchwork.kernel.org/patch/4836381/

 .../devicetree/bindings/mfd/twl4030-power.txt      |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/mfd/twl4030-power.txt +7 -2
index b9ee7b9..a7390c7 100644
@@ -23,8 +23,13 @@ down during off-idle. Note that this does not work on all boards
 depending on how the external oscillator is wired.
 
 Optional properties:
-- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or
-		   SLEEP-to-OFF transition when the system poweroffs.
+
+- ti,system-power-controller: This indicates that TWL4030 is the
+  power supply master of the system. With this flag, the chip will
+  initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
+  system poweroffs.
+
+- ti,use_poweroff: Deprecated name for ti,system-power-controller
 
 Example:
 &i2c1 {
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#3 lore raw

Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control

Quoted 10 lines · Lee Jones
Quoted 9 lines · Nishanth Menon

ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style.

So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system.

Quoted 6 lines
Quoted 4 lines

---

V2: picked up documentation suggestion from Sebastien

It would be good to get Sebastian's Ack.

[...]

Quoted 4 lines

Documentation/devicetree/bindings/mfd/twl4030-power.txt down during off-idle. Note that this does not work on all boards · line 30

Quoted 4 lines

+- ti,system-power-controller: This indicates that TWL4030 is the

Documentation/devicetree/bindings/mfd/twl4030-power.txt +3 -0
+  power supply master of the system. With this flag, the chip will
+  initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
+  system poweroffs.

One minor thing: While the documentation is updated you may want to fix the typo "will initiates" to "will initiate" (or just drop the "will").

-- Sebastian

author Acked-by Sebastian Reichel
#4 lore raw

Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control

Quoted 11 lines · Sebastian Reichel
Quoted 10 lines · Lee Jones
Quoted 9 lines · Nishanth Menon

ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style.

So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

---

V2: picked up documentation suggestion from Sebastien

It would be good to get Sebastian's Ack.

Thanks.

Quoted 11 lines

[...]

Quoted 4 lines

Review

Quoted 4 lines

+- ti,system-power-controller: This indicates that TWL4030 is the

(quoted diff) +3 -0
+  power supply master of the system. With this flag, the chip will
+  initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
+  system poweroffs.

One minor thing: While the documentation is updated you may want to fix the typo "will initiates" to "will initiate" (or just drop the "will").

Updated v3 patch with your ack and correction to drop "will" below. I will assume I wont need to repost the following update. Do let me know if you'd like me to.

---8<---

Quoted 1 line

From ae3bcfc74080b14f9fd0178f6526bf8f34a8c865 Mon Sep 17 00:00:00 2001

From: Nishanth Menon <[email protected]>
Date: Wed, 3 Sep 2014 13:55:02 -0500
Subject: [PATCH V3 1/2 ] Documentation: devicetree: mfd: twl4030-power: Use the
standard 'ti,system-power-controller' to mark power control

ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style.

So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system.

---
 .../devicetree/bindings/mfd/twl4030-power.txt      |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/mfd/twl4030-power.txt +7 -2
index b9ee7b9..15a63e6 100644
@@ -23,8 +23,13 @@ down during off-idle. Note that this does not work on all boards
 depending on how the external oscillator is wired.
 
 Optional properties:
-- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or
-		   SLEEP-to-OFF transition when the system poweroffs.
+
+- ti,system-power-controller: This indicates that TWL4030 is the
+  power supply master of the system. With this flag, the chip
+  initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
+  system poweroffs.
+
+- ti,use_poweroff: Deprecated name for ti,system-power-controller
 
 Example:
 &i2c1 {
Signature · 8 lines
1.7.9.5
-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#5 lore raw

Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control

In reply to Sebastian Reichel
Quoted 22 lines · Sebastian Reichel
Quoted 10 lines · Lee Jones
Quoted 9 lines · Nishanth Menon

ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style.

So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system.

Quoted 6 lines
Quoted 4 lines

---

V2: picked up documentation suggestion from Sebastien

It would be good to get Sebastian's Ack.

[...]

Quoted 8 lines
Quoted 4 lines

Documentation/devicetree/bindings/mfd/twl4030-power.txt down during off-idle. Note that this does not work on all boards · line 30

Quoted 4 lines

+- ti,system-power-controller: This indicates that TWL4030 is the

Documentation/devicetree/bindings/mfd/twl4030-power.txt +3 -0
+  power supply master of the system. With this flag, the chip will
+  initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
+  system poweroffs.

One minor thing: While the documentation is updated you may want to fix the typo "will initiates" to "will initiate" (or just drop the "will").

Applied with Sebastian's Ack and I fixed this up too.

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#6 lore raw

PATCH v2 2/2 mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off

In reply to Nishanth Menon

ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style.

So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system.

---

V2: no change, picked up Tony's ack.
V1: https://patchwork.kernel.org/patch/4836371/

 drivers/mfd/twl4030-power.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/mfd/twl4030-power.c +3 -0
index 3bc969a..1c129ba 100644
@@ -627,6 +627,9 @@ static bool twl4030_power_use_poweroff(const struct twl4030_power_data *pdata,
 	if (pdata && pdata->use_poweroff)
 		return true;
 
+	if (of_property_read_bool(node, "ti,system-power-controller"))
+		return true;
+
 	if (of_property_read_bool(node, "ti,use_poweroff"))
 		return true;
 
Signature · 1 line
1.7.9.5
Applied
#7 lore raw

Re: [PATCH V2 2/2] mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off

Quoted 9 lines · Nishanth Menon

ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style.

So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system.

Quoted 8 lines

---

V2: no change, picked up Tony's ack.
V1: https://patchwork.kernel.org/patch/4836371/

 drivers/mfd/twl4030-power.c |    3 +++
 1 file changed, 3 insertions(+)

Applied, thanks.

Quoted 14 lines
drivers/mfd/twl4030-power.c +3 -0
index 3bc969a..1c129ba 100644
@@ -627,6 +627,9 @@ static bool twl4030_power_use_poweroff(const struct twl4030_power_data *pdata,
 	if (pdata && pdata->use_poweroff)
 		return true;
 
+	if (of_property_read_bool(node, "ti,system-power-controller"))
+		return true;
+
 	if (of_property_read_bool(node, "ti,use_poweroff"))
 		return true;
 
Signature · 8 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html