Skip to contentSkip to conversation

libpfm4: needs NPTL support

PATCH New Alexey Brodkin 2 participants 2 messages Sep 18, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 libpfm4: needs NPTL support

Fixes following build failure:
--->---
self_smpl_multi.c: In function 'my_thread':
self_smpl_multi.c:354:2: error: implicit declaration of function 'pthread_barrier_wait' [-Werror=implicit-function-declaration]
pthread_barrier_wait(&barrier);
^
self_smpl_multi.c: In function 'main':
self_smpl_multi.c:450:2: error: implicit declaration of function 'pthread_barrier_init' [-Werror=implicit-function-declaration]
pthread_barrier_init(&barrier, 0, max_thr+1);
^
cc1: all warnings being treated as errors
--->---

And since xtensa, avr32 and bfin don't support NPTL we may remove arch dependencies as well.

Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Baruch Siach <[email protected]>

---

In v2 architecture dependencies were removed as suggested by Baruch.

---
 package/libpfm4/Config.in | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
package/libpfm4/Config.in +3 -6
index 86ca8f6..441c6de 100644
@@ -1,14 +1,11 @@
 config BR2_PACKAGE_LIBPFM4
 	bool "libpfm4"
-	depends on !BR2_avr32 # no perf_event_open
-	depends on !BR2_xtensa && !BR2_bfin # no nptl or linuxthreads (new)
-	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	help
 	  A helper library to help encode Performance Events to use with
 	  Operating system kernels performance monitoring interfaces.
 
 	  http://perfmon2.sourceforge.net/
 
-comment "libpfm4 needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
-	depends on !BR2_avr32 && !BR2_xtensa && !BR2_bfin
+comment "libpfm4 needs a toolchain w/ NPTL"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
Signature · 1 line
1.9.3
#1 lore raw

PATCH v2 1/1 libpfm4: needs NPTL support

Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Alexey" == Alexey Brodkin <[email protected]> writes:

Fixes following build failure:

---> ---

Quoted 9 lines

self_smpl_multi.c: In function 'my_thread':
self_smpl_multi.c:354:2: error: implicit declaration of function 'pthread_barrier_wait' [-Werror=implicit-function-declaration]
pthread_barrier_wait(&barrier);
^
self_smpl_multi.c: In function 'main':
self_smpl_multi.c:450:2: error: implicit declaration of function 'pthread_barrier_init' [-Werror=implicit-function-declaration]
pthread_barrier_init(&barrier, 0, max_thr+1);
^
cc1: all warnings being treated as errors

---> ---

Quoted 11 lines

And since xtensa, avr32 and bfin don't support NPTL we may remove arch dependencies as well.

Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Baruch Siach <[email protected]>

---

In v2 architecture dependencies were removed as suggested by Baruch.

Committed, thanks.

Signature · 2 lines
Venlig hilsen,
Peter Korsgaard