Skip to contentSkip to conversation

MN10300: Remove dead code depending on DEPRECATED

PATCH In review Paul Bolle 1 participant 2 messages Sep 18, 2014 – Jan 14, 2015

lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

cover MN10300: Remove dead code depending on DEPRECATED

0) Raised before in
https://www.redhat.com/archives/linux-am33-list/2011-November/msg00007.html .

1) Discussed, at length, in https://lkml.org/lkml/2014/2/9/164 .

2) Compile tested only (on top of next-20140918, using arch/mn10300/configs/asb2303_defconfig).

3) Logically this should be one humongous patch. It is split into five patches to ease review. Review, or actually any reaction whatsoever, would be appreciated.

4) The last patch was basically done by checking the output of

    git grep -i gdb.*stub arch/mn10300

and make educated guesses.

Paul Bolle (5):
MN10300: Remove Kconfig symbol GDBSTUB
MN10300: Remove Kconfig symbols depending on GDBSTUB
MN10300: Remove all checks for CONFIG_GDBSTUB
MN10300: Remove checks for GDBSTUB related Kconfig macros
MN10300: Remove remnants of gdbstub

 arch/mn10300/Kconfig                            |    6 +-
 arch/mn10300/Kconfig.debug                      |  120 +-
 arch/mn10300/boot/compressed/misc.c             |    9 -
 arch/mn10300/include/asm/exceptions.h           |    7 -
 arch/mn10300/include/asm/gdb-stub.h             |  182 ---
 arch/mn10300/kernel/Makefile                    |    3 -
 arch/mn10300/kernel/entry.S                     |   21 -
 arch/mn10300/kernel/gdb-io-serial-low.S         |   91 --
 arch/mn10300/kernel/gdb-io-serial.c             |  174 --
 arch/mn10300/kernel/gdb-io-ttysm-low.S          |   93 --
 arch/mn10300/kernel/gdb-io-ttysm.c              |  303 ----
 arch/mn10300/kernel/gdb-low.S                   |  115 --
 arch/mn10300/kernel/gdb-stub.c                  | 1923 -----------------------
 arch/mn10300/kernel/head.S                      |   10 -
 arch/mn10300/kernel/mn10300-serial.c            |   28 +-
 arch/mn10300/kernel/mn10300-serial.h            |   15 -
 arch/mn10300/kernel/mn10300-watchdog.c          |   14 +-
 arch/mn10300/kernel/process.c                   |   11 -
 arch/mn10300/kernel/profile.c                   |    2 -
 arch/mn10300/kernel/smp-low.S                   |    4 -
 arch/mn10300/kernel/smp.c                       |    7 -
 arch/mn10300/kernel/traps.c                     |    4 +-
 arch/mn10300/mm/fault.c                         |    9 -
 arch/mn10300/mm/misalignment.c                  |    1 -
 arch/mn10300/mm/tlb-mn10300.S                   |   14 -
 arch/mn10300/unit-asb2303/include/unit/serial.h |   85 -
 arch/mn10300/unit-asb2303/unit-init.c           |    4 +-
 arch/mn10300/unit-asb2305/include/unit/serial.h |   78 -
 arch/mn10300/unit-asb2305/unit-init.c           |    6 +-
 arch/mn10300/unit-asb2364/include/unit/serial.h |   66 -
 arch/mn10300/unit-asb2364/unit-init.c           |    4 +-
 31 files changed, 16 insertions(+), 3393 deletions(-)
 delete mode 100644 arch/mn10300/include/asm/gdb-stub.h
 delete mode 100644 arch/mn10300/kernel/gdb-io-serial-low.S
 delete mode 100644 arch/mn10300/kernel/gdb-io-serial.c
 delete mode 100644 arch/mn10300/kernel/gdb-io-ttysm-low.S
 delete mode 100644 arch/mn10300/kernel/gdb-io-ttysm.c
 delete mode 100644 arch/mn10300/kernel/gdb-low.S
 delete mode 100644 arch/mn10300/kernel/gdb-stub.c
Signature · 1 line
1.9.3
author
#1 lore raw

David, Koichi,

Quoted 55 lines · Paul Bolle

0) Raised before in
https://www.redhat.com/archives/linux-am33-list/2011-November/msg00007.html .

1) Discussed, at length, in https://lkml.org/lkml/2014/2/9/164 .

2) Compile tested only (on top of next-20140918, using arch/mn10300/configs/asb2303_defconfig).

3) Logically this should be one humongous patch. It is split into five patches to ease review. Review, or actually any reaction whatsoever, would be appreciated.

4) The last patch was basically done by checking the output of

    git grep -i gdb.*stub arch/mn10300

and make educated guesses.

Paul Bolle (5):
MN10300: Remove Kconfig symbol GDBSTUB
MN10300: Remove Kconfig symbols depending on GDBSTUB
MN10300: Remove all checks for CONFIG_GDBSTUB
MN10300: Remove checks for GDBSTUB related Kconfig macros
MN10300: Remove remnants of gdbstub

 arch/mn10300/Kconfig                            |    6 +-
 arch/mn10300/Kconfig.debug                      |  120 +-
 arch/mn10300/boot/compressed/misc.c             |    9 -
 arch/mn10300/include/asm/exceptions.h           |    7 -
 arch/mn10300/include/asm/gdb-stub.h             |  182 ---
 arch/mn10300/kernel/Makefile                    |    3 -
 arch/mn10300/kernel/entry.S                     |   21 -
 arch/mn10300/kernel/gdb-io-serial-low.S         |   91 --
 arch/mn10300/kernel/gdb-io-serial.c             |  174 --
 arch/mn10300/kernel/gdb-io-ttysm-low.S          |   93 --
 arch/mn10300/kernel/gdb-io-ttysm.c              |  303 ----
 arch/mn10300/kernel/gdb-low.S                   |  115 --
 arch/mn10300/kernel/gdb-stub.c                  | 1923 -----------------------
 arch/mn10300/kernel/head.S                      |   10 -
 arch/mn10300/kernel/mn10300-serial.c            |   28 +-
 arch/mn10300/kernel/mn10300-serial.h            |   15 -
 arch/mn10300/kernel/mn10300-watchdog.c          |   14 +-
 arch/mn10300/kernel/process.c                   |   11 -
 arch/mn10300/kernel/profile.c                   |    2 -
 arch/mn10300/kernel/smp-low.S                   |    4 -
 arch/mn10300/kernel/smp.c                       |    7 -
 arch/mn10300/kernel/traps.c                     |    4 +-
 arch/mn10300/mm/fault.c                         |    9 -
 arch/mn10300/mm/misalignment.c                  |    1 -
 arch/mn10300/mm/tlb-mn10300.S                   |   14 -
 arch/mn10300/unit-asb2303/include/unit/serial.h |   85 -
 arch/mn10300/unit-asb2303/unit-init.c           |    4 +-
 arch/mn10300/unit-asb2305/include/unit/serial.h |   78 -
 arch/mn10300/unit-asb2305/unit-init.c           |    6 +-
 arch/mn10300/unit-asb2364/include/unit/serial.h |   66 -
 arch/mn10300/unit-asb2364/unit-init.c           |    4 +-
Quoted 8 lines
 31 files changed, 16 insertions(+), 3393 deletions(-)
 delete mode 100644 arch/mn10300/include/asm/gdb-stub.h
 delete mode 100644 arch/mn10300/kernel/gdb-io-serial-low.S
 delete mode 100644 arch/mn10300/kernel/gdb-io-serial.c
 delete mode 100644 arch/mn10300/kernel/gdb-io-ttysm-low.S
 delete mode 100644 arch/mn10300/kernel/gdb-io-ttysm.c
 delete mode 100644 arch/mn10300/kernel/gdb-low.S
 delete mode 100644 arch/mn10300/kernel/gdb-stub.c

This series still applies on top of next-20150114. Neither of you ever bothered to send even the briefest of message regarding this issue.

I'm inclined to think mn10300 is actually orphaned. Would a patch that makes MAINTAINERS reflect that thought trigger any response?

Thanks,

Paul Bolle