cirrus: add missing drm_connector_register call
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/2 cirrus: add missing drm_connector_register call
--- drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/cirrus/cirrus_mode.c +1 -0
@@ -555,6 +555,7 @@ static struct drm_connector *cirrus_vga_init(struct drm_device *dev)drm_connector_helper_add (connector, &cirrus_vga_connector_helper_funcs); +drm_connector_register (connector);return connector; }
Signature · 1 line
1.8.3.1
Hi
Quoted 10 lines · Gerd Hoffmann
Signed-off-by Gerd Hoffmann <[email protected]>--- drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/cirrus/cirrus_mode.c +0
-0
drivers/gpu/drm/cirrus/cirrus_mode.c static struct drm_connector *cirrus_vga_init(struct drm_device *dev) · line 558
Quoted 4 lines
drivers/gpu/drm/cirrus/cirrus_mode.c +1
-0@@ -555,6 +555,7 @@ static struct drm_connector *cirrus_vga_init(struct drm_device *dev)drm_connector_helper_add (connector, &cirrus_vga_connector_helper_funcs); +drm_connector_register (connector);
Error checking?
And should probably include "Cc: <[email protected]> # v3.15+".
Thanks
David
Quoted 10 lines
drivers/gpu/drm/cirrus/cirrus_mode.c +0
-1return connector; } --1.8.3.1
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 14 lines · David Herrmann
Hi
Quoted 11 lines · Gerd Hoffmann
Signed-off-by Gerd Hoffmann <[email protected]>--- drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/cirrus/cirrus_mode.c +0
-0@@ -555,6 +555,7 @@ static struct drm_connector *cirrus_vga_init(struct drm_device *dev)
Quoted 5 lines
drivers/gpu/drm/cirrus/cirrus_mode.c static struct drm_connector *cirrus_vga_init(struct drm_device *dev) · line 558
Quoted 3 lines
drivers/gpu/drm/cirrus/cirrus_mode.c +1
-0drm_connector_helper_add (connector, &cirrus_vga_connector_helper_funcs); +drm_connector_register (connector);Error checking?
Hmm, I see plenty of calls like this in the kernel.
Also: What should happen on error? The driver itself and cirrusdrmfb works just fine without that, so I don't feel like failing driver initialization because of that, as that would break the console ...
Quoted 1 line
And should probably include "Cc: <[email protected]> # v3.15+".
Commit 2ee39452fa2fff1e8edb954ccb7e0daee9646557 (v3.17 merge window) exposes the bug, so stable kernels are working just fine.
cheers,
Gerd
PATCH 2/2 bochs: add missing drm_connector_register call
In reply to a message not in the archive--- drivers/gpu/drm/bochs/bochs_kms.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/bochs/bochs_kms.c +1 -0
@@ -250,6 +250,7 @@ static void bochs_connector_init(struct drm_device *dev) DRM_MODE_CONNECTOR_VIRTUAL);drm_connector_helper_add (connector, &bochs_connector_connector_helper_funcs); +drm_connector_register (connector); }
Signature · 1 line
1.8.3.1