Use the gssproxy damon for GSSAPI credentials (v2)
Subsystems (2)
cover Use the gssproxy damon for GSSAPI credentials (v2)
The gssproxy(8) daemon will now be used to manage the GSSAPI credentials on the server.
The nfs-server systemd script will now start gssproxy and the building/installing of rpc.svcgssd is now off by default.
Steve Dickson (2):
nfs-server: Replace rpc.svcgssd with gssproxy in systemd script rpc.svcgssd: the build of rpc.svcgssd is off by default
configure.ac | 23 +++++++++++++++++++---- systemd/nfs-server.service | 4 ++-- utils/gssd/Makefile.am | 11 +++++++++-- 3 files changed, 30 insertions(+), 8 deletions(-)
Signature · 1 line
1.9.3
PATCH 1/2 nfs-server: Replace rpc.svcgssd with gssproxy in systemd script
Have the nfs-server depend/start on the gssproxy daemon instead of rpc.svcgssd to manage GSSAPI credentials
--- systemd/nfs-server.service | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
systemd/nfs-server.service +2 -2
@@ -2,12 +2,12 @@ Description=NFS server and services Requires= network.target proc-fs-nfsd.mount rpcbind.target Requires= nfs-mountd.service -Wants=rpc-statd.service nfs-idmapd.service rpc-gssd.service rpc-svcgssd.service +Wants=rpc-statd.service nfs-idmapd.service rpc-gssd.service gssproxy.service Wants=rpc-statd-notify.service After= network.target proc-fs-nfsd.mount rpcbind.target nfs-mountd.service After= nfs-idmapd.service rpc-statd.service -After= rpc-gssd.service rpc-svcgssd.service +After= rpc-gssd.service gssproxy.service Before= rpc-statd-notify.service Wants=nfs-config.service
Signature · 1 line
1.9.3
Re: [PATCH 1/2] nfs-server: Replace rpc.svcgssd with gssproxy in systemd script
Neil,
Quoted 14 lines · Steve Dickson
Have the nfs-server depend/start on the gssproxy daemon instead of rpc.svcgssd to manage GSSAPI credentials
Signed-off-by Steve Dickson <[email protected]>--- systemd/nfs-server.service | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)systemd/nfs-server.service +0
-0@@ -2,12 +2,12 @@ Description=NFS server and services
systemd/nfs-server.service line 10
Quoted 10 lines
systemd/nfs-server.service +2
-2Requires= network.target proc-fs-nfsd.mount rpcbind.target Requires= nfs-mountd.service -Wants=rpc-statd.service nfs-idmapd.service rpc-gssd.service rpc-svcgssd.service +Wants=rpc-statd.service nfs-idmapd.service rpc-gssd.service gssproxy.service Wants=rpc-statd-notify.service After= network.target proc-fs-nfsd.mount rpcbind.target nfs-mountd.service After= nfs-idmapd.service rpc-statd.service -After= rpc-gssd.service rpc-svcgssd.service +After= rpc-gssd.service gssproxy.service
Is there a better way to do this, to be more backwards compatible?
Maybe figure out that gssproxy is installed so would start that daemon if not fall back to rpc.svcgssd?
Unfortunately systemd is still somewhat of a mystery to me.... :-(
steved.
Quoted 4 lines
systemd/nfs-server.service +0
-0Before= rpc-statd-notify.service Wants=nfs-config.service
Re: [PATCH 1/2] nfs-server: Replace rpc.svcgssd with gssproxy in systemd script
Quoted 29 lines · On Fri, 19 Sep 2014 15:51:09 -0400 Steve Dickson <[email protected]> wrote:
Neil,
Quoted 14 lines · Steve Dickson
Have the nfs-server depend/start on the gssproxy daemon instead of rpc.svcgssd to manage GSSAPI credentials
Signed-off-by Steve Dickson <[email protected]>--- systemd/nfs-server.service | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)systemd/nfs-server.service +0
-0@@ -2,12 +2,12 @@ Description=NFS server and servicessystemd/nfs-server.service line 10
Quoted 10 lines
systemd/nfs-server.service +2
-2Requires= network.target proc-fs-nfsd.mount rpcbind.target Requires= nfs-mountd.service -Wants=rpc-statd.service nfs-idmapd.service rpc-gssd.service rpc-svcgssd.service +Wants=rpc-statd.service nfs-idmapd.service rpc-gssd.service gssproxy.service Wants=rpc-statd-notify.service After= network.target proc-fs-nfsd.mount rpcbind.target nfs-mountd.service After= nfs-idmapd.service rpc-statd.service -After= rpc-gssd.service rpc-svcgssd.service +After= rpc-gssd.service gssproxy.serviceIs there a better way to do this, to be more backwards compatible?
Quoted 10 lines
Maybe figure out that gssproxy is installed so would start that daemon if not fall back to rpc.svcgssd?
Unfortunately systemd is still somewhat of a mystery to me.... :-(
steved.
Quoted 4 lines
systemd/nfs-server.service +0
-0Before= rpc-statd-notify.service Wants=nfs-config.service
Hi Steve,
as gssproxy is part of a separate package, I don't think it is appropriate for and nfs-utils service file to 'want' it. I don't know that there are any "rules" about this so I make it up as I go along, but that seems right to me.
Instead, the .service file which the gssproxy package installs should/could/might declare
WantedBy=nfs-server.service
so if that is enabled, the linkage gets created.
Either way, my idea is that starting nfs-server should try to start both svcgssd and gssproxy.
rpc-svcgssd.service already declares itself as being *after* gssproxy so if both are available, gssproxy will be run first.
If gssproxy starts and finds the kernel supports it, then it will be running when rpc-svcgssd.service starts up and the Conditions in there will cause it to not start the actual daemon.
So the nfs-utils .service files should not need changing. All that should be needed for gssproxy to be used is:
- gssproxy needs to be installed (of course)
- gssproxy.service needs to declare "WantedBy=nfs-server.service" in the [Install] section
- 'systemctl enable gssproxy' needs to have been run somehow. There are various ways to get this to happen at install time.
However I haven't really tested this much. I know I said I would do some testing of these unit files and I really do want to, but it just hasn't happened yet because ... you know, "life".
I had a look at the gssproxy.service file and it already has 'WantedBy=multi-user.target' the same as nfs-server.service. So if they are both enabled, they should both be started at the same time, and if should all *just*work*.
I assume it doesn't *just*work* at present. What is actually happening? Do you have gssproxy.service 'enabled'??
Thanks,
NeilBrown
Re: [PATCH 1/2] nfs-server: Replace rpc.svcgssd with gssproxy in systemd script
Hello,
Quoted 6 lines · NeilBrown
Hi Steve,
as gssproxy is part of a separate package, I don't think it is appropriate for and nfs-utils service file to 'want' it. I don't know that there are any "rules" about this so I make it up as I go along, but that seems right to me.
I was wondering about this... From a distro its easy... Just add a requirement in the spec file and you'll know the package will exist... But upstream it may not so straightforward...
Quoted 10 lines
Instead, the .service file which the gssproxy package installs should/could/might declare
WantedBy=nfs-server.service
so if that is enabled, the linkage gets created.
Either way, my idea is that starting nfs-server should try to start both svcgssd and gssproxy.
Right... this is the general consensuses...
Quoted 2 lines
rpc-svcgssd.service already declares itself as being *after* gssproxy so if both are available, gssproxy will be run first.
Ah.. I did miss this fact... That is very important!
Quoted 3 lines
If gssproxy starts and finds the kernel supports it, then it will be running when rpc-svcgssd.service starts up and the Conditions in there will cause it to not start the actual daemon.
Those ConditionPathExists do indeed work... I think both of them need to stay...
Quoted 6 lines
So the nfs-utils .service files should not need changing. All that should be needed for gssproxy to be used is:
- gssproxy needs to be installed (of course)
- gssproxy.service needs to declare "WantedBy=nfs-server.service" in the [Install] section
Right now gssproxy.service has:
[Unit]
Before=nfs-secure.service nfs-secure-server.service Requires=proc-fs-nfsd.mount
^^^^ this Requires actually loads sunrpc, nfsd, auth_rpcgss
another important fact!
[Install]
WantedBy=multi-user.target
So I went ahead and added "WantedBy=nfs-server.service" to the gssproxy.service file and re-installed the package... I didn't see it make much difference.... both packages have to be enabled for them to be started.
Quoted 2 lines
- 'systemctl enable gssproxy' needs to have been run somehow. There are various ways to get this to happen at install time.
When gssproxy is enabled, it will be *always* started, whether the server is running or not... I was working toward only starting gssproxy when its needed, like rpc.svcgssd is today.
Quoted 5 lines
However I haven't really tested this much. I know I said I would do some testing of these unit files and I really do want to, but it just hasn't happened yet because ... you know, "life".
No problem... ;-) thanks for the help!
Quoted 5 lines
I had a look at the gssproxy.service file and it already has 'WantedBy=multi-user.target' the same as nfs-server.service. So if they are both enabled, they should both be started at the same time, and if should all *just*work*.
They do... I enable them both... everything comes up just fine...
Quoted 3 lines
I assume it doesn't *just*work* at present. What is actually happening? Do you have gssproxy.service 'enabled'??
This is the problem... gssproxy has to be enabled... I don't think that's is good... and not necessary... What (I think) is necessary is we create a dependency on gssproxy (like we do for rpcbind, keyutils, libevent, etc) and have the server bring up gssproxy when it comes up. That is achieved by simply adding gssproxy.service to the nfs-server.service files:
systemd/nfs-server.service 2014-09-23 10:39:17.604412641 -0400 renamed from systemd/nfs-server.service.orig 2014-09-23 10:38:39.572726403 -0400 +3 -2
@@ -2,12 +2,13 @@ Description=NFS server and services Requires= network.target proc-fs-nfsd.mount rpcbind.target Requires= nfs-mountd.service -Wants=rpc-statd.service nfs-idmapd.service rpc-gssd.service rpc-svcgssd.service +Wants=rpc-statd.service nfs-idmapd.service +Wants=rpc-gssd.service gssproxy.service rpc-svcgssd.service Wants=rpc-statd-notify.service After= network.target proc-fs-nfsd.mount rpcbind.target nfs-mountd.service After= nfs-idmapd.service rpc-statd.service -After= rpc-gssd.service rpc-svcgssd.service +After= rpc-gssd.service gssproxy.service rpc-svcgssd.service Before= rpc-statd-notify.service Wants=nfs-config.service
The patch does not require gssproxy to be enabled so gssproxy will be started only when the server is started. Now if an admin what to enable gssproxy for some other reason so be it... Things will still work.
Through this discussion both of my concerns about this patch have been address:
1) Having both gssproxy and rpc.gssd started/running at the same time because systemd starts everything at once... but that can't happen because of the 'After=gssproxy.service' in rpc-svcgssd.service. That's something I missed... thank you for pointing that out! That is very good foresight on your part! IMHO...
2) This whole business about how auth_rpcgss gets loaded... It is crystal to me that the "Requires=proc-fs-nfsd.mount" in gssproxy.service is loading the modules. You disable the server, disable the client and enable gssproxy then reboot... lsmod | grep rpc show sunrpc, nfsd, and auth_rpcgss are loaded. So nothing has to change in gssproxy.service and another unit file to load the modules is not needed.
So I guess at the end of the day... I want to break the 'Unknown' Wants rule... ;-) By adding a dependency to gssproxy and by having nfs-server 'want' the gssproxy service... Its the cleanest way... IMHO...
steved.
Re: [PATCH 1/2] nfs-server: Replace rpc.svcgssd with gssproxy in systemd script
Quoted 3 lines · Steve Dickson
So I guess at the end of the day... I want to break the 'Unknown' Wants rule... ;-) By adding a dependency to gssproxy and by having nfs-server 'want' the gssproxy service... Its the cleanest way... IMHO...
As Simo just pointed out... nfs-utils does not need to require gssproxy to be installed... When its not installed, rpc.svcgssd will be started when it is, gssproxy will be started.
steved.
PATCH 2/2 rpc.svcgssd: the build of rpc.svcgssd is off by default
In reply to Steve DicksonDue to the fact the gssproxy is not managing the
GASSAPI credentials, on the server, there is
no need to build/install rpc.svcgssd.
To re-enable the build use the --enable-svcgss
configure flag
--- configure.ac | 23 +++++++++++++++++++---- utils/gssd/Makefile.am | 11 +++++++++-- 2 files changed, 28 insertions(+), 6 deletions(-)
configure.ac +19 -4
@@ -90,21 +90,36 @@ AC_ARG_ENABLE(nfsv41, AC_ARG_ENABLE(gss, [AC_HELP_STRING([--enable-gss], - [enable support for rpcsec_gss @<:@default=yes@:>@])], + [enable client support for rpcsec_gss @<:@default=yes@:>@])], enable_gss=$enableval, enable_gss=yes) if test "$enable_gss" = yes; then GSSD=gssd - SVCGSSD=svcgssd else enable_gss= GSSD= - SVCGSSD= fi AC_SUBST(GSSD) - AC_SUBST(SVCGSSD) AC_SUBST(enable_gss) AM_CONDITIONAL(CONFIG_GSS, [test "$enable_gss" = "yes"]) + +AC_ARG_ENABLE(svcgss, + [AC_HELP_STRING([--enable-svcgss], + [enable server support for rpcsec_gss @<:@default=no@:>@])], + enable_svcgss=$enableval, + enable_svcgss=no) + if test "$enable_gss" = yes; then + if "enable_svcgss" = yes; then + SVCGSSD=svcgssd + fi + else + enable_svcgss= + SVCGSSD= + fi + AC_SUBST(SVCGSSD) + AC_SUBST(enable_svcgss) + AM_CONDITIONAL(CONFIG_SVCGSS, [test "$enable_svcgss" = "yes"]) + AC_ARG_ENABLE(kprefix, [AC_HELP_STRING([--enable-kprefix], [install progs as rpc.knfsd etc])], test "$enableval" = "yes" && kprefix=k,
utils/gssd/Makefile.am +9 -2
@@ -1,10 +1,17 @@ ## Process this file with automake to produce Makefile.in -man8_MANS = gssd.man svcgssd.man +man8_MANS = gssd.man +if CONFIG_SVCGSS +man8_MANS += svcgssd.man +endif RPCPREFIX = rpc. KPREFIX = @kprefix@ -sbin_PREFIXED = gssd svcgssd +sbin_PREFIXED = gssd +if CONFIG_SVCGSS +sbin_PREFIXED += svcgssd +endif + sbin_PROGRAMS = $(sbin_PREFIXED) EXTRA_DIST = \
Signature · 1 line
1.9.3